From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huan Wang Date: Mon, 22 Sep 2014 06:46:20 +0000 Subject: [U-Boot] [PATCH 6/7] arm: ls102xa: Add SD boot support for LS1021AQDS board In-Reply-To: References: <1411019239-12360-1-git-send-email-b18965@freescale.com> <1411019239-12360-7-git-send-email-b18965@freescale.com> <1411053355745.66856@freescale.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Albert, > > On Thu, 18 Sep 2014 13:47:18 +0800, Alison Wang > > wrote: > > > > > + > > > + . = ALIGN(4); > > > + .u_boot_list : { > > > + KEEP(*(SORT(.u_boot_list*_i2c_*))); > > > + } > > > > IS this required? And if it is, could it not be added to the > > arch/arm/cpu/u-boot-spl.lds file? This way you would not need an .lds > > file at all. > > > > [Alison Wang] Yes, it is required. > > Ok -- what for? :) [Alison Wang] In SPL part, DDR is initialized by reading SPD through I2C interface. For I2C, ll_entry_count() is called, and it returns the number of elements of a linker-generated array placed into subsection of .u_boot_list section specified by _list argument. So I need to add this to make I2C work in SPL. > > > I would like to add it in arch/arm/cpu/u-boot-spl.lds. I was not sure > > adding it in arch/arm/cpu/u-boot-spl.lds is acceptable or not. > > (assuming the reason why it is needed is valid) If it causes no change > to boards which do not use it right now (and I mean 'no change' ad > 'binary identical') then this is acceptable. Make sure you check the > binary invariance and that you mention it in the commit. > [Alison Wang] It will cause the binary is not identical for other board. I think it may be not good to add in arch/arm/cpu/u-boot-spl.lds. What's your opinion about it? Best Regards, Alison Wang