All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	zachm1996@gmail.com, Claudia <claudia1@disroot.org>
Subject: Re: [Xen-devel] Xen fails to resume on AMD Fam15h (and Fam17h?) because of CPUID mismatch
Date: Mon, 10 Feb 2020 09:55:06 +0100	[thread overview]
Message-ID: <a6b9455d-dea1-6c61-ff7f-4fbaaba9a953@suse.com> (raw)
In-Reply-To: <20200209230655.GA32524@mail-itl>

On 10.02.2020 00:06, Marek Marczykowski-Górecki wrote:
> Hi,
> 
> Multiple Qubes users have reported issues with resuming from S3 on AMD
> systems (Ryzen 2500U, Ryzen Pro 3700U, maybe more). The error message
> is:
> 
> (XEN) CPU0: cap[ 1] is 7ed8320b (expected f6d8320b)
> 
> If I read it right, this is:
>   - OSXSAVE: 0 -> 1
>   - HYPERVISOR: 1 -> 0
> 
> Commenting out the panic on a failed recheck_cpu_features() in power.c
> makes the system work after resume, reportedly stable. But that doesn't
> sounds like a good idea generally.
> 
> Is this difference a Xen fault (some missing MSR / other register
> restore on resume)? Or BIOS vendor / AMD, that could be worked around in
> Xen?

The transition of the HYPERVISOR bit is definitely a Xen issue,
with Andrew having sent a patch already (iirc). The OSXSAVE part
is a little more surprising, as I wouldn't think behavior there
should differ between Intel and AMD. I take your report though
to imply that you see the issue on AMD systems only? (You also
don't mention the Xen version, which may matter as there may
have been ordering changes of when the full original CR4 value
gets restored.)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-02-10  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 23:06 [Xen-devel] Xen fails to resume on AMD Fam15h (and Fam17h?) because of CPUID mismatch Marek Marczykowski-Górecki
2020-02-10  8:55 ` Jan Beulich [this message]
2020-02-10 11:17   ` Andrew Cooper
2020-02-10 12:14     ` Marek Marczykowski-Górecki
2020-02-10 12:46       ` Andrew Cooper
2020-02-11 12:59     ` Claudia
2020-02-11 21:08       ` Marek Marczykowski-Górecki
2020-02-12  4:20       ` Claudia
2020-05-02 21:12         ` Z M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6b9455d-dea1-6c61-ff7f-4fbaaba9a953@suse.com \
    --to=jbeulich@suse.com \
    --cc=claudia1@disroot.org \
    --cc=marmarek@invisiblethingslab.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zachm1996@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.