From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F39C433F5 for ; Mon, 22 Nov 2021 15:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239878AbhKVPez (ORCPT ); Mon, 22 Nov 2021 10:34:55 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:48200 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238634AbhKVPex (ORCPT ); Mon, 22 Nov 2021 10:34:53 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1AMFVYFt003275; Mon, 22 Nov 2021 09:31:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1637595094; bh=l4IE6N+ggau1s09k9ExcCLkrfbZHkOUKLDDQDp1KkTA=; h=Subject:To:References:From:Date:In-Reply-To; b=l7LsCNtvzUMzFMuyiNF67DnAM7iMIP0ll3kwFq7xWAKzmhqREcSCt4sDkNZ8UuCyh a2BvTVweEtziNS4jMvRhRyk/GxHtxo+D6eC62j5Dopqk8PlAuoF4eG4HqoQmBO75sn +WGNb0FXjnRvvx58rhdzDQE0VMj6DgUk1fziZlz8= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1AMFVYZh074258 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Nov 2021 09:31:34 -0600 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 22 Nov 2021 09:30:10 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 22 Nov 2021 09:30:10 -0600 Received: from [10.249.45.167] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1AMFUAlL007225; Mon, 22 Nov 2021 09:30:10 -0600 Subject: Re: [PATCH] soc: ti: pruss: fix referenced node in error message To: Jan Kiszka , Santosh Shilimkar , Linux Kernel Mailing List , linux-arm-kernel , Grzegorz Jaszczyk , Kishon Vijay Abraham , Nishanth Menon References: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com> <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> From: Suman Anna Message-ID: Date: Mon, 22 Nov 2021 09:30:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Nishanth On 11/20/21 1:53 AM, Jan Kiszka wrote: > On 01.09.21 17:03, Jan Kiszka wrote: >> On 23.06.21 17:51, Suman Anna wrote: >>> On 6/21/21 1:08 PM, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> So far, "(null)" is reported for the node that is missing clocks. >>>> >>>> Signed-off-by: Jan Kiszka >>> >>> Acked-by: Suman Anna >>> >>>> --- >>>> drivers/soc/ti/pruss.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>> index f22ac1edbdd0..afc8aae68035 100644 >>>> --- a/drivers/soc/ti/pruss.c >>>> +++ b/drivers/soc/ti/pruss.c >>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node) >>>> >>>> clks_np = of_get_child_by_name(cfg_node, "clocks"); >>>> if (!clks_np) { >>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np); >>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node); >>>> return -ENODEV; >>>> } >>>> >>>> >>> >> >> This was not merged yet. Is it queued somewhere? >> >> Jan >> > > Second reminder - still not seeing this in upstream. Nishanth, Can you pick this up? regards Suman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B643EC433EF for ; Mon, 22 Nov 2021 15:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=87HS8rdYLPnSmfiOBgKrG6hUVgLpqJXJVAkQtHdT/5Y=; b=a0czhodEYaScyPpi38JGcDlX3T 0A0EjDzI5P6zyt/E0GigRPNTmHGSDxPZPDPOrgVuUYCLbr6KoFtmAxwsyP8k3sf4DzAIjpCA7TlR+ SFjdFPf021OyFU4GLaovs45zho92dHZKEayQ1HHm7FE+iYxew+vZFA0OSECl6Y3Yrqmw3RJ9RwQKL B3EM7nJtI6ZLRN7oWfrV5ca2GZqwBC/aWO7bS0xBvepINPtL6sOBqc5FuQjBjWjYg2abTc0g+J1i0 8i0aXaPpWf3mgwhdyJTpcSDGqpqp2qmtg0xa+fLcZjwTD/8+b6aGAt4YkKrwwrbvW0LU8qWA09QPP obJNhWbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpBIH-00H2qT-0D; Mon, 22 Nov 2021 15:31:45 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpBID-00H2px-6n for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 15:31:42 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1AMFVYFt003275; Mon, 22 Nov 2021 09:31:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1637595094; bh=l4IE6N+ggau1s09k9ExcCLkrfbZHkOUKLDDQDp1KkTA=; h=Subject:To:References:From:Date:In-Reply-To; b=l7LsCNtvzUMzFMuyiNF67DnAM7iMIP0ll3kwFq7xWAKzmhqREcSCt4sDkNZ8UuCyh a2BvTVweEtziNS4jMvRhRyk/GxHtxo+D6eC62j5Dopqk8PlAuoF4eG4HqoQmBO75sn +WGNb0FXjnRvvx58rhdzDQE0VMj6DgUk1fziZlz8= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1AMFVYZh074258 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Nov 2021 09:31:34 -0600 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 22 Nov 2021 09:30:10 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 22 Nov 2021 09:30:10 -0600 Received: from [10.249.45.167] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1AMFUAlL007225; Mon, 22 Nov 2021 09:30:10 -0600 Subject: Re: [PATCH] soc: ti: pruss: fix referenced node in error message To: Jan Kiszka , Santosh Shilimkar , Linux Kernel Mailing List , linux-arm-kernel , Grzegorz Jaszczyk , Kishon Vijay Abraham , Nishanth Menon References: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com> <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> From: Suman Anna Message-ID: Date: Mon, 22 Nov 2021 09:30:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_073141_440306_3729E46A X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Nishanth On 11/20/21 1:53 AM, Jan Kiszka wrote: > On 01.09.21 17:03, Jan Kiszka wrote: >> On 23.06.21 17:51, Suman Anna wrote: >>> On 6/21/21 1:08 PM, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> So far, "(null)" is reported for the node that is missing clocks. >>>> >>>> Signed-off-by: Jan Kiszka >>> >>> Acked-by: Suman Anna >>> >>>> --- >>>> drivers/soc/ti/pruss.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>> index f22ac1edbdd0..afc8aae68035 100644 >>>> --- a/drivers/soc/ti/pruss.c >>>> +++ b/drivers/soc/ti/pruss.c >>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node) >>>> >>>> clks_np = of_get_child_by_name(cfg_node, "clocks"); >>>> if (!clks_np) { >>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np); >>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node); >>>> return -ENODEV; >>>> } >>>> >>>> >>> >> >> This was not merged yet. Is it queued somewhere? >> >> Jan >> > > Second reminder - still not seeing this in upstream. Nishanth, Can you pick this up? regards Suman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel