From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C0CC0C4338F
	for <linux-kernel@archiver.kernel.org>; Mon, 16 Aug 2021 01:54:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 91DF46135E
	for <linux-kernel@archiver.kernel.org>; Mon, 16 Aug 2021 01:54:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230455AbhHPBzC (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 15 Aug 2021 21:55:02 -0400
Received: from mail.kernel.org ([198.145.29.99]:46304 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229527AbhHPBzB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 15 Aug 2021 21:55:01 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D78B6136A;
        Mon, 16 Aug 2021 01:54:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1629078870;
        bh=0LbfQkM7HZueVzmxBHA9CYfz7kOuxLMPYbK6Xw0q8y8=;
        h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
        b=MAJB6c3us1VKhpzx3Qdh5KFrxV0ozR3opnGdhI8BVYhgcfYc9KGoM3xLzap9OHoZy
         yZoeCLG9AUOdQ36lZeA07li0HQ2x0p4V+OVUWeZToeROGQlfBhFCxiuhvI2opqvdE8
         +RaZd5NOQWAm3SVrrxRqDT7TwA1uBUw64LZ/NevrCaCziVzoFgvY9SaELrkpfNbugJ
         nlNoSGJZw/WWm/RCssCVwsYwIJfvcIBkUPA16pCajoa575Dqh+0owdrB6ABDC3ObzC
         bOY6YMYRLhHJmbMO0kTIFo3cmbLXwYrRhvwNeLZAFHCNgyDalUbdDYwPRy/m3w23qY
         8Nfg4brMigCdg==
Subject: Re: [PATCH v5 1/2] f2fs: introduce proc/fs/f2fs/<dev>/fsck_stack node
To:     =?UTF-8?B?5p2O5oms6Z+s?= <frank.li@vivo.com>
Cc:     jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <AEMABgAWDwhd8*f2P*fotqoY.3.1628906905520.Hmail.frank.li@vivo.com>
From:   Chao Yu <chao@kernel.org>
Message-ID: <a6e1f93c-b45e-019b-273f-b5019052739e@kernel.org>
Date:   Mon, 16 Aug 2021 09:54:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <AEMABgAWDwhd8*f2P*fotqoY.3.1628906905520.Hmail.frank.li@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/8/14 10:08, 李扬韬 wrote:
>>> We can't remove stack from depot, as we store them contiguously one after
>>> another in a contiguous memory allocation.
>>>
>>> Or we can limit the recorded stack number.
>>>
>>> $ grep -nr "SBI_NEED_FSCK" fs/f2fs/ --include=*.c --include=*.h | wc -l
>>> 53
>>> $ grep -nr "f2fs_bug_on" fs/f2fs/ --include=*.c --include=*.h | wc -l
>>> 135
>>
>> I didn't look into details of stack_depot_save(), two stack handles from below
>> call paths will be the same?
>>
>> - move_data_block
>>   - f2fs_wait_on_page_writeback
>>    - f2fs_bug_on
>>
>> - ra_data_block
>>   - f2fs_wait_on_page_writeback
>>    - f2fs_bug_on
>>
>> If they have different stack handles, combination number of
>> set_sbi_flag(NEED_FSCK)/f2fs_bug_on and their callers will be far more than two
>> hundred.
>>
> 
> Yes, these will be two different stacks. In the most extreme case, there will be 1000 (I guess) different places to set fsck?

It may be according to call stack height of each handle record.

> Or we limit the number of recorded stacks to 10?

Yes, please limit the record number, maybe 8? and stack height could be 16 at
maximum?

Thanks,

> what do you think. The stack depot design does not consider removing the stack from the depot.
> 
> MBR,
> Yangtao
> 

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ksoz=NH=lists.sourceforge.net=linux-f2fs-devel-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E2D16C4338F
	for <linux-f2fs-devel@archiver.kernel.org>; Mon, 16 Aug 2021 01:54:38 +0000 (UTC)
Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 934066135E;
	Mon, 16 Aug 2021 01:54:38 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 934066135E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net
Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com)
	by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1)
	(envelope-from <linux-f2fs-devel-bounces@lists.sourceforge.net>)
	id 1mFRpm-0001EQ-3c; Mon, 16 Aug 2021 01:54:38 +0000
Received: from [172.30.20.202] (helo=mx.sourceforge.net)
 by sfs-ml-1.v29.lw.sourceforge.com with esmtps
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1)
 (envelope-from <chao@kernel.org>) id 1mFRpl-0001EI-OH
 for linux-f2fs-devel@lists.sourceforge.net; Mon, 16 Aug 2021 01:54:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
 MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=8bT4u3RXzRTl3/5FEWy9djrHW19lsPmELxPtW8iQE0M=; b=Kb6EtSnPhJz+0P7r5Rq+FC3zFP
 tCiacpItzMMKLtpOcG+gvZZA/XBRTl+QhYE2eQHkw4WSHWpF1sB1n1QGu887SfoeYqlIqPuemtDNQ
 gzLrzufYpOguhEufTbYsUddZK+gMYEW0LCh3OM+VFqGPb5sSqigtuExAgG+LJjPAruNM=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
 ;
 h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:
 Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=8bT4u3RXzRTl3/5FEWy9djrHW19lsPmELxPtW8iQE0M=; b=ix/HEuvQ/aVtYM8eHxDqj/tMmr
 kgtUxvrBD6YNFCOj/rTuDDaWRWd6UJbrvnxn+yiUHo2Gr7ttX9xV4vEKj1I9svQK70bZOYX4qg13v
 zgYgVjB/odAIxCxn5ADGx6h3VnvIjV1QpwRSnKzr7nuMlVb9TlnUNNwZNJKRi57wQnbg=;
Received: from mail.kernel.org ([198.145.29.99])
 by sfi-mx-2.v28.lw.sourceforge.com with esmtps
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3)
 id 1mFRpk-0000tm-AM
 for linux-f2fs-devel@lists.sourceforge.net; Mon, 16 Aug 2021 01:54:37 +0000
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D78B6136A;
 Mon, 16 Aug 2021 01:54:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1629078870;
 bh=0LbfQkM7HZueVzmxBHA9CYfz7kOuxLMPYbK6Xw0q8y8=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
 b=MAJB6c3us1VKhpzx3Qdh5KFrxV0ozR3opnGdhI8BVYhgcfYc9KGoM3xLzap9OHoZy
 yZoeCLG9AUOdQ36lZeA07li0HQ2x0p4V+OVUWeZToeROGQlfBhFCxiuhvI2opqvdE8
 +RaZd5NOQWAm3SVrrxRqDT7TwA1uBUw64LZ/NevrCaCziVzoFgvY9SaELrkpfNbugJ
 nlNoSGJZw/WWm/RCssCVwsYwIJfvcIBkUPA16pCajoa575Dqh+0owdrB6ABDC3ObzC
 bOY6YMYRLhHJmbMO0kTIFo3cmbLXwYrRhvwNeLZAFHCNgyDalUbdDYwPRy/m3w23qY
 8Nfg4brMigCdg==
To: =?UTF-8?B?5p2O5oms6Z+s?= <frank.li@vivo.com>
References: <AEMABgAWDwhd8*f2P*fotqoY.3.1628906905520.Hmail.frank.li@vivo.com>
From: Chao Yu <chao@kernel.org>
Message-ID: <a6e1f93c-b45e-019b-273f-b5019052739e@kernel.org>
Date: Mon, 16 Aug 2021 09:54:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <AEMABgAWDwhd8*f2P*fotqoY.3.1628906905520.Hmail.frank.li@vivo.com>
Content-Language: en-US
X-Headers-End: 1mFRpk-0000tm-AM
Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: introduce
 proc/fs/f2fs/<dev>/fsck_stack node
X-BeenThere: linux-f2fs-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <linux-f2fs-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/linux-f2fs-devel>, 
 <mailto:linux-f2fs-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=linux-f2fs-devel>
List-Post: <mailto:linux-f2fs-devel@lists.sourceforge.net>
List-Help: <mailto:linux-f2fs-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel>, 
 <mailto:linux-f2fs-devel-request@lists.sourceforge.net?subject=subscribe>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net
Content-Transfer-Encoding: base64
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net

T24gMjAyMS84LzE0IDEwOjA4LCDmnY7miazpn6wgd3JvdGU6Cj4+PiBXZSBjYW4ndCByZW1vdmUg
c3RhY2sgZnJvbSBkZXBvdCwgYXMgd2Ugc3RvcmUgdGhlbSBjb250aWd1b3VzbHkgb25lIGFmdGVy
Cj4+PiBhbm90aGVyIGluIGEgY29udGlndW91cyBtZW1vcnkgYWxsb2NhdGlvbi4KPj4+Cj4+PiBP
ciB3ZSBjYW4gbGltaXQgdGhlIHJlY29yZGVkIHN0YWNrIG51bWJlci4KPj4+Cj4+PiAkIGdyZXAg
LW5yICJTQklfTkVFRF9GU0NLIiBmcy9mMmZzLyAtLWluY2x1ZGU9Ki5jIC0taW5jbHVkZT0qLmgg
fCB3YyAtbAo+Pj4gNTMKPj4+ICQgZ3JlcCAtbnIgImYyZnNfYnVnX29uIiBmcy9mMmZzLyAtLWlu
Y2x1ZGU9Ki5jIC0taW5jbHVkZT0qLmggfCB3YyAtbAo+Pj4gMTM1Cj4+Cj4+IEkgZGlkbid0IGxv
b2sgaW50byBkZXRhaWxzIG9mIHN0YWNrX2RlcG90X3NhdmUoKSwgdHdvIHN0YWNrIGhhbmRsZXMg
ZnJvbSBiZWxvdwo+PiBjYWxsIHBhdGhzIHdpbGwgYmUgdGhlIHNhbWU/Cj4+Cj4+IC0gbW92ZV9k
YXRhX2Jsb2NrCj4+ICAgLSBmMmZzX3dhaXRfb25fcGFnZV93cml0ZWJhY2sKPj4gICAgLSBmMmZz
X2J1Z19vbgo+Pgo+PiAtIHJhX2RhdGFfYmxvY2sKPj4gICAtIGYyZnNfd2FpdF9vbl9wYWdlX3dy
aXRlYmFjawo+PiAgICAtIGYyZnNfYnVnX29uCj4+Cj4+IElmIHRoZXkgaGF2ZSBkaWZmZXJlbnQg
c3RhY2sgaGFuZGxlcywgY29tYmluYXRpb24gbnVtYmVyIG9mCj4+IHNldF9zYmlfZmxhZyhORUVE
X0ZTQ0spL2YyZnNfYnVnX29uIGFuZCB0aGVpciBjYWxsZXJzIHdpbGwgYmUgZmFyIG1vcmUgdGhh
biB0d28KPj4gaHVuZHJlZC4KPj4KPiAKPiBZZXMsIHRoZXNlIHdpbGwgYmUgdHdvIGRpZmZlcmVu
dCBzdGFja3MuIEluIHRoZSBtb3N0IGV4dHJlbWUgY2FzZSwgdGhlcmUgd2lsbCBiZSAxMDAwIChJ
IGd1ZXNzKSBkaWZmZXJlbnQgcGxhY2VzIHRvIHNldCBmc2NrPwoKSXQgbWF5IGJlIGFjY29yZGlu
ZyB0byBjYWxsIHN0YWNrIGhlaWdodCBvZiBlYWNoIGhhbmRsZSByZWNvcmQuCgo+IE9yIHdlIGxp
bWl0IHRoZSBudW1iZXIgb2YgcmVjb3JkZWQgc3RhY2tzIHRvIDEwPwoKWWVzLCBwbGVhc2UgbGlt
aXQgdGhlIHJlY29yZCBudW1iZXIsIG1heWJlIDg/IGFuZCBzdGFjayBoZWlnaHQgY291bGQgYmUg
MTYgYXQKbWF4aW11bT8KClRoYW5rcywKCj4gd2hhdCBkbyB5b3UgdGhpbmsuIFRoZSBzdGFjayBk
ZXBvdCBkZXNpZ24gZG9lcyBub3QgY29uc2lkZXIgcmVtb3ZpbmcgdGhlIHN0YWNrIGZyb20gdGhl
IGRlcG90Lgo+IAo+IE1CUiwKPiBZYW5ndGFvCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGlu
dXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vm
b3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo=