From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCHv3 2/4] drm/tilcdc: Stop using struct drm_driver load() callback Date: Thu, 3 Nov 2016 22:11:26 +0200 Message-ID: References: <14637959.KONjiNb2SJ@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67CB489182 for ; Thu, 3 Nov 2016 20:11:36 +0000 (UTC) In-Reply-To: <14637959.KONjiNb2SJ@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: khilman@baylibre.com, dri-devel@lists.freedesktop.org, bgolaszewski@baylibre.com, tomi.valkeinen@ti.com List-Id: dri-devel@lists.freedesktop.org T24gMTEvMDMvMTYgMjA6MTUsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gSGkgSnlyaSwKPiAK PiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KPiAKPiBPbiBXZWRuZXNkYXkgMDIgTm92IDIwMTYg MTc6NTc6NTAgSnlyaSBTYXJoYSB3cm90ZToKPj4gU3RvcCB1c2luZyBzdHJ1Y3QgZHJtX2RyaXZl ciBsb2FkKCkgYW5kIHVubG9hZCgpIGNhbGxiYWNrcy4gVGhlCj4+IGNhbGxiYWNrcyBzaG91bGQg bm90IGJlIHVzZWQgYW55bW9yZS4gSW5zdGVhZCBvZiB1c2luZyBsb2FkIHRoZQo+PiBkcm1fZGV2 aWNlIGlzIGFsbG9jYXRlZCB3aXRoIGRybV9kZXZfYWxsb2MoKSBhbmQgcmVnaXN0ZXJlZCB3aXRo Cj4+IGRybV9kZXZfcmVnaXN0ZXIoKSBvbmx5IGFmdGVyIHRoZSBkcml2ZXIgaXMgY29tcGxldGVs eSBpbml0aWFsaXplZC4KPj4gVGhlIGRlaW5pdGlhbGl6YXRpb24gaXMgZG9uZSBkaXJlY3RseSBl aXRoZXIgaW4gY29tcG9uZW50IHVuYmluZAo+PiBjYWxsYmFjayBvciBpbiBwbGF0Zm9ybSBkcml2 ZXIgZGVtb3ZlIGNhbGxiYWNrLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKeXJpIFNhcmhhIDxqc2Fy aGFAdGkuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX2Rydi5j IHwgMTI0ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdl ZCwgNzAgaW5zZXJ0aW9ucygrKSwgNTQgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19kcnYuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS90 aWxjZGMvdGlsY2RjX2Rydi5jIGluZGV4IDVjZjUzNGMuLjExZjMyNjIgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX2Rydi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS90aWxjZGMvdGlsY2RjX2Rydi5jCj4+IEBAIC0xOTQsMTggKzE5NCwyMiBAQCBzdGF0aWMg aW50IGNwdWZyZXFfdHJhbnNpdGlvbihzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sKPj4gKm5iLCAqIERS TSBvcGVyYXRpb25zOgo+PiAgICovCj4+Cj4+IC1zdGF0aWMgaW50IHRpbGNkY191bmxvYWQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPj4gK3N0YXRpYyB2b2lkIHRpbGNkY19maW5pKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4+ICB7Cj4+ICAJc3RydWN0IHRpbGNkY19kcm1fcHJpdmF0ZSAqcHJp diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4+Cj4+IC0JdGlsY2RjX3JlbW92ZV9leHRlcm5hbF9lbmNv ZGVycyhkZXYpOwo+PiArCWRybV9tb2Rlc2V0X2xvY2tfY3J0Yyhwcml2LT5jcnRjLCBOVUxMKTsK Pj4gKwl0aWxjZGNfY3J0Y19kaXNhYmxlKHByaXYtPmNydGMpOwo+PiArCWRybV9tb2Rlc2V0X3Vu bG9ja19jcnRjKHByaXYtPmNydGMpOwo+PiArCj4+ICsJZHJtX2Rldl91bnJlZ2lzdGVyKGRldik7 Cj4+Cj4+IC0JZHJtX2ZiZGV2X2NtYV9maW5pKHByaXYtPmZiZGV2KTsKPj4gIAlkcm1fa21zX2hl bHBlcl9wb2xsX2ZpbmkoZGV2KTsKPj4gKwlkcm1fZmJkZXZfY21hX2ZpbmkocHJpdi0+ZmJkZXYp Owo+IAo+IElzIHRoZXJlIGEgbmVlZCB0byByZW9yZGVyIHRoZXNlID8KCkkgYW0gbm90IHN1cmUg YWN0dWFsbHkuIFdoZW4gdGhlIHRoaW5ncyBkaWQgbm90IHdvcmsgcHJvcGVybHkgaW4gdGhlCmJl Z2lubmluZyBJIGp1c3Qgb3JkZXJlZCB1bmxvYWRpbmcgdG8gaGFwcGVuIHN0cmljdGx5IGluIHRo ZSByZXZlcnNlCm9yZGVyIGNvbXBhcmVkIHRvIGxvYWRpbmcuIEkgZGlkIG5vdCBnbyBiYWNrIHRv IGNoZWNrIHdoYXQgY2hhbmdlcyB3ZXJlCmFjdHVhbGx5IG5lZWRlZCB3aGVuIEkgZ290IHRoaW5n cyB3b3JraW5nLgoKPiAKPj4gKwlkcm1faXJxX3VuaW5zdGFsbChkZXYpOwo+PiAgCWRybV9tb2Rl X2NvbmZpZ19jbGVhbnVwKGRldik7Cj4+IC0JZHJtX3ZibGFua19jbGVhbnVwKGRldik7Cj4+Cj4+ IC0JZHJtX2lycV91bmluc3RhbGwoZGV2KTsKPj4gKwl0aWxjZGNfcmVtb3ZlX2V4dGVybmFsX2Vu Y29kZXJzKGRldik7Cj4+Cj4+ICAjaWZkZWYgQ09ORklHX0NQVV9GUkVRCj4+ICAJY3B1ZnJlcV91 bnJlZ2lzdGVyX25vdGlmaWVyKCZwcml2LT5mcmVxX3RyYW5zaXRpb24sCj4+IEBAIC0yMjUsMjgg KzIyOSwzNCBAQCBzdGF0aWMgaW50IHRpbGNkY191bmxvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPj4KPj4gIAlwbV9ydW50aW1lX2Rpc2FibGUoZGV2LT5kZXYpOwo+Pgo+PiAtCXJldHVybiAw Owo+PiArCWRybV9kZXZfdW5yZWYoZGV2KTsKPj4gIH0KPj4KPj4gLXN0YXRpYyBpbnQgdGlsY2Rj X2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgbG9uZyBmbGFncykKPj4gK3N0 YXRpYyBpbnQgdGlsY2RjX2luaXQoc3RydWN0IGRybV9kcml2ZXIgKmRkcnYsIHN0cnVjdCBkZXZp Y2UgKmRldikKPj4gIHsKPj4gLQlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gZGV2LT5w bGF0Zm9ybWRldjsKPj4gLQlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUgPSBwZGV2LT5kZXYub2Zf bm9kZTsKPj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGRldjsKPj4gKwlzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2ID0gdG9fcGxhdGZvcm1fZGV2aWNlKGRldik7Cj4+ICsJc3RydWN0IGRldmlj ZV9ub2RlICpub2RlID0gZGV2LT5vZl9ub2RlOwo+PiAgCXN0cnVjdCB0aWxjZGNfZHJtX3ByaXZh dGUgKnByaXY7Cj4+ICAJc3RydWN0IHJlc291cmNlICpyZXM7Cj4+ICAJdTMyIGJwcCA9IDA7Cj4+ ICAJaW50IHJldDsKPj4KPj4gLQlwcml2ID0gZGV2bV9remFsbG9jKGRldi0+ZGV2LCBzaXplb2Yo KnByaXYpLCBHRlBfS0VSTkVMKTsKPj4gKwlwcml2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9m KCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4+ICAJaWYgKCFwcml2KSB7Cj4+IC0JCWRldl9lcnIoZGV2 LT5kZXYsICJmYWlsZWQgdG8gYWxsb2NhdGUgcHJpdmF0ZSBkYXRhXG4iKTsKPj4gKwkJZGV2X2Vy cihkZXYsICJmYWlsZWQgdG8gYWxsb2NhdGUgcHJpdmF0ZSBkYXRhXG4iKTsKPj4gIAkJcmV0dXJu IC1FTk9NRU07Cj4+ICAJfQo+Pgo+PiAtCWRldi0+ZGV2X3ByaXZhdGUgPSBwcml2Owo+PiArCWRk ZXYgPSBkcm1fZGV2X2FsbG9jKGRkcnYsIGRldik7Cj4gCj4gQXMgYSBmb2xsb3ctdXAgcGF0Y2gg eW91IG1pZ2h0IHdhbnQgdG8gbW92ZSB0aWxjZGNfZHJpdmVyIGFib3ZlIHRoaXMgZnVuY3Rpb24g Cj4gYW5kIHVzZSBpdCBkaXJlY3RseSB0byByZW1vdmUgdGhlIGRkcnYgYXJndW1lbnQuCj4gCgpP aywgdGhhbmtzLgoKPiBBcGFydCBmcm9tIHRoYXQsCj4gCj4gUmV2aWV3ZWQtYnk6IExhdXJlbnQg UGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPj4gKwlpZiAo SVNfRVJSKGRkZXYpKQo+PiArCQlyZXR1cm4gUFRSX0VSUihkZGV2KTsKPj4gKwo+PiArCWRkZXYt PnBsYXRmb3JtZGV2ID0gcGRldjsKPj4gKwlkZGV2LT5kZXZfcHJpdmF0ZSA9IHByaXY7Cj4gCj4g W3NuaXBdCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK