From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46690C388F9 for ; Fri, 23 Oct 2020 07:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0111E21527 for ; Fri, 23 Oct 2020 07:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S373930AbgJWHNc (ORCPT ); Fri, 23 Oct 2020 03:13:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:34118 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S373852AbgJWHNc (ORCPT ); Fri, 23 Oct 2020 03:13:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 10B61ABD1; Fri, 23 Oct 2020 07:13:31 +0000 (UTC) Subject: Re: [PATCH] gpu/drm/mgag200:remove break after return To: Bernard Zhao , Dave Airlie , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com References: <20201023070004.55105-1-bernard@vivo.com> From: Thomas Zimmermann Message-ID: Date: Fri, 23 Oct 2020 09:13:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201023070004.55105-1-bernard@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 23.10.20 09:00, Bernard Zhao wrote: > In function mgag200_set_pci_regs, there are some switch cases > returned, then break. These break will never run. > This patch is to make the code a bit readable. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c > index 38672f9e5c4f..de873a5d276e 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -794,20 +794,17 @@ static int mgag200_crtc_set_plls(struct mga_device *mdev, long clock) > case G200_SE_A: > case G200_SE_B: > return mga_g200se_set_plls(mdev, clock); > - break; > case G200_WB: > case G200_EW3: > return mga_g200wb_set_plls(mdev, clock); > - break; > case G200_EV: > return mga_g200ev_set_plls(mdev, clock); > - break; > case G200_EH: > case G200_EH3: > return mga_g200eh_set_plls(mdev, clock); > - break; > case G200_ER: > return mga_g200er_set_plls(mdev, clock); > + default: No default case here. If one of the enum values is not handled by the switch, the compiler should warn about it. Best regards Thomas > break; > } > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58132C55178 for ; Fri, 23 Oct 2020 07:13:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBE7720878 for ; Fri, 23 Oct 2020 07:13:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBE7720878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54E746E497; Fri, 23 Oct 2020 07:13:33 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82BF66E497 for ; Fri, 23 Oct 2020 07:13:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 10B61ABD1; Fri, 23 Oct 2020 07:13:31 +0000 (UTC) Subject: Re: [PATCH] gpu/drm/mgag200:remove break after return To: Bernard Zhao , Dave Airlie , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20201023070004.55105-1-bernard@vivo.com> From: Thomas Zimmermann Message-ID: Date: Fri, 23 Oct 2020 09:13:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201023070004.55105-1-bernard@vivo.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkKCk9uIDIzLjEwLjIwIDA5OjAwLCBCZXJuYXJkIFpoYW8gd3JvdGU6Cj4gSW4gZnVuY3Rpb24g bWdhZzIwMF9zZXRfcGNpX3JlZ3MsIHRoZXJlIGFyZSBzb21lIHN3aXRjaCBjYXNlcwo+IHJldHVy bmVkLCB0aGVuIGJyZWFrLiBUaGVzZSBicmVhayB3aWxsIG5ldmVyIHJ1bi4KPiBUaGlzIHBhdGNo IGlzIHRvIG1ha2UgdGhlIGNvZGUgYSBiaXQgcmVhZGFibGUuCj4gCj4gU2lnbmVkLW9mZi1ieTog QmVybmFyZCBaaGFvIDxiZXJuYXJkQHZpdm8uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v bWdhZzIwMC9tZ2FnMjAwX21vZGUuYyB8IDUgKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vbWdhZzIwMC9tZ2FnMjAwX21vZGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcy MDBfbW9kZS5jCj4gaW5kZXggMzg2NzJmOWU1YzRmLi5kZTg3M2E1ZDI3NmUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9tb2RlLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX21vZGUuYwo+IEBAIC03OTQsMjAgKzc5NCwxNyBAQCBz dGF0aWMgaW50IG1nYWcyMDBfY3J0Y19zZXRfcGxscyhzdHJ1Y3QgbWdhX2RldmljZSAqbWRldiwg bG9uZyBjbG9jaykKPiAgCWNhc2UgRzIwMF9TRV9BOgo+ICAJY2FzZSBHMjAwX1NFX0I6Cj4gIAkJ cmV0dXJuIG1nYV9nMjAwc2Vfc2V0X3BsbHMobWRldiwgY2xvY2spOwo+IC0JCWJyZWFrOwo+ICAJ Y2FzZSBHMjAwX1dCOgo+ICAJY2FzZSBHMjAwX0VXMzoKPiAgCQlyZXR1cm4gbWdhX2cyMDB3Yl9z ZXRfcGxscyhtZGV2LCBjbG9jayk7Cj4gLQkJYnJlYWs7Cj4gIAljYXNlIEcyMDBfRVY6Cj4gIAkJ cmV0dXJuIG1nYV9nMjAwZXZfc2V0X3BsbHMobWRldiwgY2xvY2spOwo+IC0JCWJyZWFrOwo+ICAJ Y2FzZSBHMjAwX0VIOgo+ICAJY2FzZSBHMjAwX0VIMzoKPiAgCQlyZXR1cm4gbWdhX2cyMDBlaF9z ZXRfcGxscyhtZGV2LCBjbG9jayk7Cj4gLQkJYnJlYWs7Cj4gIAljYXNlIEcyMDBfRVI6Cj4gIAkJ cmV0dXJuIG1nYV9nMjAwZXJfc2V0X3BsbHMobWRldiwgY2xvY2spOwo+ICsJZGVmYXVsdDoKCk5v IGRlZmF1bHQgY2FzZSBoZXJlLiBJZiBvbmUgb2YgdGhlIGVudW0gdmFsdWVzIGlzIG5vdCBoYW5k bGVkIGJ5IHRoZQpzd2l0Y2gsIHRoZSBjb21waWxlciBzaG91bGQgd2FybiBhYm91dCBpdC4KCkJl c3QgcmVnYXJkcwpUaG9tYXMKCj4gIAkJYnJlYWs7Cj4gIAl9Cj4gIAo+IAoKLS0gClRob21hcyBa aW1tZXJtYW5uCkdyYXBoaWNzIERyaXZlciBEZXZlbG9wZXIKU1VTRSBTb2Z0d2FyZSBTb2x1dGlv bnMgR2VybWFueSBHbWJICk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQoo SFJCIDM2ODA5LCBBRyBOw7xybmJlcmcpCkdlc2Now6RmdHNmw7xocmVyOiBGZWxpeCBJbWVuZMO2 cmZmZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==