From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9 Date: Fri, 21 Dec 2018 14:34:59 +0000 Message-ID: References: <1545372231-45810-1-git-send-email-zengxhsh@cn.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Zeng To: David Zeng , dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0F73C1BE46 for ; Fri, 21 Dec 2018 15:35:03 +0100 (CET) In-Reply-To: <1545372231-45810-1-git-send-email-zengxhsh@cn.ibm.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/21/2018 6:03 AM, David Zeng wrote: > Signed-off-by: David Zeng > --- > kernel/linux/kni/compat.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h > index 5aadebb..1afa3b8 100644 > --- a/kernel/linux/kni/compat.h > +++ b/kernel/linux/kni/compat.h > @@ -102,8 +102,14 @@ > #undef NET_NAME_UNKNOWN > #endif > > +/* > + * RHEL has two different version with different kernel version: > + * 3.10 is for AMD, Intel, IBM POWER7 and POWER8; > + * 4.14 is for ARM and IBM POWER9 > + */ > #if (defined(RHEL_RELEASE_CODE) && \ > - (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5))) > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \ > + (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0))) > #define ndo_change_mtu ndo_change_mtu_rh74 > #endif Do you need to update 'kernel/linux/kni/ethtool/igb/kcompat.h' for same check? Also there is another update on same line for RHEL8 fix [1], if you can rebase on top of it makes maintainers life easier. [1] https://patches.dpdk.org/patch/49104/ Thanks, ferruh