From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2987C433F5 for ; Thu, 19 May 2022 04:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbiESE25 (ORCPT ); Thu, 19 May 2022 00:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233690AbiESE2y (ORCPT ); Thu, 19 May 2022 00:28:54 -0400 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B221BC03B3; Wed, 18 May 2022 21:28:51 -0700 (PDT) Received: by mail-ej1-f42.google.com with SMTP id y13so6822333eje.2; Wed, 18 May 2022 21:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YVivavOUL0ESIMZFNZScTS19Sf8/enmueYLabJ2OE/Y=; b=CBornHqjfnGVwj5upL0hltJQXF12obal81yYfJNKbTJCwtF1I/4zscM+3sx4zH0ryJ oxK3yzvveydI6GKDDqmaSZKqBToSz8haEzOLpf268lYy9YNEXOVEwsRcO/Mlm3QBh87u KmX8n6lJEAm/JPxvk4+D4UfSoQ7CwDDV1UOuPNy8qcPA8IRP34RnNIIrmhSsPhA9I47q rTRzDEo0jFcU/qOuxWpsLT2ijubwfMsw16ZAElfV8okh0GKqrmd2ZhnY5RFx+k4UibOf Ep5m/bU+PsDanxusmt8Z2dDDsoabZeVWfkZjnrTV86mNCZrBKit5GWinEy05jj8Z7xYP vtgA== X-Gm-Message-State: AOAM530mzrCKOK5kSfd3TOZ957LuGbCyQbzV8fcU9Aofks2ZZXxBsBNj 0xK6I6nlg7VKDLI5L9NEchQ= X-Google-Smtp-Source: ABdhPJzXxQYKbFgoabOZaX/s0jFlh6Qe1bCTr8yivdy0VI4mQ0BqjcpdFza+l8OONL0UjyyjAcvynw== X-Received: by 2002:a17:906:6a16:b0:6f4:63ae:76c with SMTP id qw22-20020a1709066a1600b006f463ae076cmr2422674ejc.705.1652934530204; Wed, 18 May 2022 21:28:50 -0700 (PDT) Received: from [192.168.50.14] (178-117-55-239.access.telenet.be. [178.117.55.239]) by smtp.gmail.com with ESMTPSA id eo20-20020a1709069b1400b006f3ef214e58sm1651339ejc.190.2022.05.18.21.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 21:28:49 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 06:28:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCHv2 1/3] block/bio: remove duplicate append pages code Content-Language: en-US To: Keith Busch , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: axboe@kernel.dk, Kernel Team , hch@lst.de, damien.lemoal@opensource.wdc.com, Keith Busch References: <20220518171131.3525293-1-kbusch@fb.com> <20220518171131.3525293-2-kbusch@fb.com> From: Bart Van Assche In-Reply-To: <20220518171131.3525293-2-kbusch@fb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/18/22 19:11, Keith Busch wrote: > + for (left = size, i = 0; left > 0; left -= len, i++) { > + struct page *page = pages[i]; > + bool same_page = false; > + > + len = min_t(size_t, PAGE_SIZE - offset, left); > + if (bio_add_hw_page(q, bio, page, len, offset, > + max_append_sectors, &same_page) != len) { > + bio_put_pages(pages + i, left, offset); > + ret = -EINVAL; > + break; > + } > + if (same_page) > + put_page(page); > + offset = 0; > + } Consider renaming 'same_page' into 'merged'. I think that name reflects much better the purpose of that variable. Thanks, Bart.