All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH DPDK-KMODS] igb_uio: add compile instructions
Date: Mon, 23 Nov 2020 17:08:49 +0000	[thread overview]
Message-ID: <a701b22d-face-d66f-bd06-aac6397d5330@intel.com> (raw)
In-Reply-To: <6ba21a558bc1d6049a77d09ed52d12627055db8a.1605891269.git.anatoly.burakov@intel.com>

On 11/20/2020 4:54 PM, Anatoly Burakov wrote:
> Currently, compilation instructions for igb_uio are missing. Add them,
> as well as a top-level INSTALL file referring users to per-OS
> subdirectories.

patch title should start with 'linux/igb_uio:'

> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Thanks for doc update.

<...>

> @@ -0,0 +1,45 @@
> +Building Linux Drivers
> +======================
> +
> +Prerequisites
> +-------------
> +
> +The system must have relevant Linux kernel headers or source code installed.
> +
> +Build
> +-----
> +
> +To build ``igb_uio`` driver, simple run ``make`` command inside the
> +``linux/igb_uio`` directry:
> +

Just detail but since we are in the 'linux' folder while reading this file, I 
wonder if the reference path should be ``igb_uio`` instead of ``linux/igb_uio``?
Both are OK I think.

  reply	other threads:[~2020-11-23 17:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 16:54 [dpdk-dev] [PATCH DPDK-KMODS] igb_uio: add compile instructions Anatoly Burakov
2020-11-23 17:08 ` Ferruh Yigit [this message]
2020-11-24 13:26 ` [dpdk-dev] [PATCH DPDK-KMODS v2] linux/igb_uio: " Anatoly Burakov
2020-11-24 14:27   ` Ajit Khaparde
2021-02-11 11:04     ` Burakov, Anatoly
2021-02-15 11:40   ` Thomas Monjalon
2021-02-15 12:00     ` Burakov, Anatoly
2022-01-11 13:35       ` Thomas Monjalon
2023-02-05 18:23         ` [kmods PATCH v3] linux/igb_uio: add build instructions Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a701b22d-face-d66f-bd06-aac6397d5330@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.