From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755091AbdK2OkS (ORCPT ); Wed, 29 Nov 2017 09:40:18 -0500 Received: from mga04.intel.com ([192.55.52.120]:40484 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754964AbdK2OkP (ORCPT ); Wed, 29 Nov 2017 09:40:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,473,1505804400"; d="scan'208";a="8458921" Subject: Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails. To: Thomas Voegtle , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org References: <20171128111603.62757-1-maarten.lankhorst@linux.intel.com> <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local> From: Maarten Lankhorst Message-ID: Date: Wed, 29 Nov 2017 15:40:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 28-11-17 om 16:13 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Daniel Vetter wrote: > >> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >>> Some drivers like i915 start with crtc's enabled, but with deferred >>> fbcon setup they were no longer disabled as part of fbdev setup. >>> Headless units could no longer enter pc3 state because the crtc was >>> still enabled. >>> >>> Fix this by calling restore_fbdev_mode when we would have called >>> it otherwise once during initial fbdev setup. >>> >>> Signed-off-by: Maarten Lankhorst >>> Fixes: ca91a2758fce ("drm/fb-helper: Support deferred setup") >> >> Please use dim fixes to get a more complete Cc: list for regression fixes. >> >>> Cc: # v4.14+ >>> Reported-by: Thomas Voegtle >> >> Reviewed-by: Daniel Vetter >> >> But please confirm with the reporter that it indeed fixes the issue before >> pushing. >> -Daniel > > I re-checked the latest version of the patch and it indeed fixes the problem. > > Thanks, > >    Thomas > Pushed, thanks for the report. :) ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails. Date: Wed, 29 Nov 2017 15:40:04 +0100 Message-ID: References: <20171128111603.62757-1-maarten.lankhorst@linux.intel.com> <20171128114943.dn4hpgxb6st3ng23@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Voegtle , Daniel Vetter Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMjgtMTEtMTcgb20gMTY6MTMgc2NocmVlZiBUaG9tYXMgVm9lZ3RsZToKPiBPbiBUdWUsIDI4 IE5vdiAyMDE3LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Cj4+IE9uIFR1ZSwgTm92IDI4LCAyMDE3 IGF0IDEyOjE2OjAzUE0gKzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+Pj4gU29tZSBk cml2ZXJzIGxpa2UgaTkxNSBzdGFydCB3aXRoIGNydGMncyBlbmFibGVkLCBidXQgd2l0aCBkZWZl cnJlZAo+Pj4gZmJjb24gc2V0dXAgdGhleSB3ZXJlIG5vIGxvbmdlciBkaXNhYmxlZCBhcyBwYXJ0 IG9mIGZiZGV2IHNldHVwLgo+Pj4gSGVhZGxlc3MgdW5pdHMgY291bGQgbm8gbG9uZ2VyIGVudGVy IHBjMyBzdGF0ZSBiZWNhdXNlIHRoZSBjcnRjIHdhcwo+Pj4gc3RpbGwgZW5hYmxlZC4KPj4+Cj4+ PiBGaXggdGhpcyBieSBjYWxsaW5nIHJlc3RvcmVfZmJkZXZfbW9kZSB3aGVuIHdlIHdvdWxkIGhh dmUgY2FsbGVkCj4+PiBpdCBvdGhlcndpc2Ugb25jZSBkdXJpbmcgaW5pdGlhbCBmYmRldiBzZXR1 cC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5r aG9yc3RAbGludXguaW50ZWwuY29tPgo+Pj4gRml4ZXM6IGNhOTFhMjc1OGZjZSAoImRybS9mYi1o ZWxwZXI6IFN1cHBvcnQgZGVmZXJyZWQgc2V0dXAiKQo+Pgo+PiBQbGVhc2UgdXNlIGRpbSBmaXhl cyB0byBnZXQgYSBtb3JlIGNvbXBsZXRlIENjOiBsaXN0IGZvciByZWdyZXNzaW9uIGZpeGVzLgo+ Pgo+Pj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0LjE0Kwo+Pj4gUmVwb3J0ZWQt Ynk6IFRob21hcyBWb2VndGxlIDx0dkBsaW85Ni5kZT4KPj4KPj4gUmV2aWV3ZWQtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4+Cj4+IEJ1dCBwbGVhc2UgY29uZmly bSB3aXRoIHRoZSByZXBvcnRlciB0aGF0IGl0IGluZGVlZCBmaXhlcyB0aGUgaXNzdWUgYmVmb3Jl Cj4+IHB1c2hpbmcuCj4+IC1EYW5pZWwKPgo+IEkgcmUtY2hlY2tlZCB0aGUgbGF0ZXN0IHZlcnNp b24gb2YgdGhlIHBhdGNoIGFuZCBpdCBpbmRlZWQgZml4ZXMgdGhlIHByb2JsZW0uCj4KPiBUaGFu a3MsCj4KPiDCoMKgIFRob21hcwo+ClB1c2hlZCwgdGhhbmtzIGZvciB0aGUgcmVwb3J0LiA6KQoK fk1hYXJ0ZW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=