From: Pavel Hofman <pavel.hofman@ivitera.com>
To: Jack Pham <jackp@codeaurora.org>, Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] usb: gadget: f_uac2: fixed EP-IN wMaxPacketSize
Date: Sat, 25 Sep 2021 08:55:17 +0200 [thread overview]
Message-ID: <a70511c6-7118-b153-de73-059bb62a3e3d@ivitera.com> (raw)
In-Reply-To: <20210924184659.GA13104@jackp-linux.qualcomm.com>
Hi Jack,
Dne 24. 09. 21 v 20:46 Jack Pham napsal(a):
> Hi Pavel,
>
> Thanks for sending out the patch.
>
> On Fri, Sep 24, 2021 at 10:35:07AM +0200, Pavel Hofman wrote:
>> Hi Greg,
>>
>> Dne 24. 09. 21 v 10:20 Greg KH napsal(a):
>>> On Fri, Sep 24, 2021 at 10:00:27AM +0200, Pavel Hofman wrote:
>>>> Async feedback patches broke enumeration on Windows 10 previously fixed
>>>> by commit 789ea77310f0 ("usb: gadget: f_uac2: always increase endpoint
>>>> max_packet_size by one audio slot").
>>>>
>>>> While the existing calculation for EP OUT capture for async mode yields
>>>> size+1 frame due to uac2_opts->fb_max > 0, playback side lost the +1
>>>> feature. Therefore the +1 frame addition must be re-introduced for
>>>> playback. Win10 enumerates the device only when both EP IN and EP OUT
>>>> max packet sizes are (at least) +1 frame.
>>>>
>>>> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
>>>> Tested-by: Henrik Enquist <henrik.enquist@gmail.com>
>>>> Tested-by: Jack Pham <jackp@codeaurora.org>
>>>> ---
>>>> drivers/usb/gadget/function/f_uac2.c | 14 ++++++++++----
>>>> 1 file changed, 10 insertions(+), 4 deletions(-)
>>>
>>> What commit does this fix?
>
> IMO it Fixes: e89bb4288378 ("usb: gadget: u_audio: add real feedback
> implementation").
>
>>> Should it go to stable kernel(s)?
>
> Yes, but probably just to 5.14 since the commit I pointed out with the
> Fixes tag was introduced in 5.14-rc1 but don't think it was ever
> backported to earlier stable kernels.
>
>> It's the same effort direction as commit https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/usb/+/f5dfd98a80ff8d50cf4ae2820857d7f5a46cbab9
>> which you added to your usb-linus branch https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/usb/+log/refs/heads/usb-linus/drivers/usb/gadget/function
>> Therefore I would say usb-linus.
>>
>> Please what are your rules for usb-linus and usb-next? There are some
>> different commits in usb-next and usb-linus changing the same file -
>> f_uac2.c . Likely not, but a conflict could potentially occur. I do not know
>> what head to rebase my further patches which also make larger changes to
>> that file.
>
> Since this is a fix, I'd suggest you base on Greg's usb-linus since
> patches queued there will be going out during the current 5.15-rc cycle.
>
Thanks for the explanation. I do not have any more small patches fixing
the Win10 support now. Patches implementing EP-IN async (Playback Pitch
1000000) and the rebased Julian's multiple samplerates patch will go to
Greg's usb-next and will be rebased on top of your latest SS patches.
Best regards,
Pavel.
prev parent reply other threads:[~2021-09-25 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:00 [PATCH] usb: gadget: f_uac2: fixed EP-IN wMaxPacketSize Pavel Hofman
2021-09-24 8:20 ` Greg KH
2021-09-24 8:35 ` Pavel Hofman
2021-09-24 18:46 ` Jack Pham
2021-09-25 6:55 ` Pavel Hofman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a70511c6-7118-b153-de73-059bb62a3e3d@ivitera.com \
--to=pavel.hofman@ivitera.com \
--cc=balbi@kernel.org \
--cc=greg@kroah.com \
--cc=jackp@codeaurora.org \
--cc=jbrunet@baylibre.com \
--cc=linux-usb@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.