From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F7DC2BA80 for ; Tue, 7 Apr 2020 15:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41A9820753 for ; Tue, 7 Apr 2020 15:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="dKwo/ZV2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729383AbgDGPS6 (ORCPT ); Tue, 7 Apr 2020 11:18:58 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:31646 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbgDGPS5 (ORCPT ); Tue, 7 Apr 2020 11:18:57 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586272736; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=MkHWeN7jEYivOg5ls6MEofDm2yhzyIloU6lj3iDRPEs=; b=dKwo/ZV25eoEOHn5mobbkJbkvkxMh09wV1XYP2tVpQFRPjLqV+9NUEY5kWYc0lAlDiy4YXm9 DQWwWgWmGX9j8ngnrpUUkbJQnwSSWAa2wFaUfZ23LEt1F66MdWw81vRaSasCO9A/MQ75dBR3 R+4cAROcnR5aS0B2A9KN3WtYinA= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8c99e0.7f42bc7b51f0-smtp-out-n05; Tue, 07 Apr 2020 15:18:56 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 390D5C44788; Tue, 7 Apr 2020 15:18:55 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 63272C433D2; Tue, 7 Apr 2020 15:18:54 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 07 Apr 2020 20:48:54 +0530 From: Sai Prakash Ranjan To: Suzuki K Poulose Cc: mike.leach@linaro.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections In-Reply-To: References: <20200405102819.28460-1-saiprakash.ranjan@codeaurora.org> <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> <906d374d-a4d6-f2f2-6845-88b97a5ff7d9@arm.com> <39a2b3fff165a108fa59d72b630b5f14@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Suzuki, On 2020-04-07 20:23, Suzuki K Poulose wrote: > On 04/07/2020 02:56 PM, Sai Prakash Ranjan wrote: >> Hi Suzuki, >> >> On 2020-04-07 18:38, Suzuki K Poulose wrote: >>> On 04/07/2020 12:29 PM, Sai Prakash Ranjan wrote: >>>> Hi Suzuki, >>>> >>>> Thanks for looking into this issue. >>>> >>>> On 2020-04-07 15:54, Suzuki K Poulose wrote: >>>>> On 04/07/2020 10:46 AM, Sai Prakash Ranjan wrote: >>>>> >>>>> There seems to be two replicators back to back here. What is >>>>> connected >>>>> to the other output of both of them ? Are there any TPIUs ? What >>>>> happens >>>>> if you choose a sink on the other end of "swao_replicator" (ETB ?) >>>>> >>>> >>>> The other outport of swao replicator is connected to EUD which is a >>>> QCOM specific HW which can be used as a sink like USB. >>>> And the other outport of other replicator(replicator_out) is >>>> connected to >>>> TPIU. >>>> >>>>> After boot, what do the idfilter registers read for both the >>>>> replicators ? >>>>> >>>> >>>> Added some prints in replicator_probe. >>>> >>>>   replicator probe ret=-517 devname=6046000.replicator idfilter0=0x0 >>>> idfilter1=0x0 >>>>   replicator probe ret=0 devname=6b06000.replicator idfilter0=0xff >>>> idfilter1=0xff >>>>   replicator probe ret=0 devname=6046000.replicator idfilter0=0xff >>>> idfilter1=0xff >>> >>> Curious to see how the idfilterX is set to 0: >>>      if that is never used. >>>         Or >>>      if the user doesn't reset it back to 0xff. >>> >> >> For both replicators, the default value seems to be 0x0. >> >>  replicator probe in res ret=0 devname=6046000.replicator >> idfilter0=0x0 idfilter1=0x0 >>  replicator probe ret=-517 devname=6046000.replicator idfilter0=0x0 >> idfilter1=0x0 >>  replicator probe in res ret=0 devname=6b06000.replicator >> idfilter0=0x0 idfilter1=0x0 >>  replicator probe ret=0 devname=6b06000.replicator idfilter0=0xff >> idfilter1=0xff >>  replicator probe in res ret=0 devname=6046000.replicator >> idfilter0=0x0 idfilter1=0x0 >>  replicator probe ret=0 devname=6046000.replicator idfilter0=0xff >> idfilter1=0xff > > I am not sure how you have added the debugs, but it looks like the > drivers set 0xff for both the port filters on a successful probe. > Yes, thats done by replicator_reset in probe right? Below is the diff: @@ -242,6 +244,9 @@ static int replicator_probe(struct device *dev, struct resource *res) } drvdata->base = base; desc.groups = replicator_groups; + pr_info("replicator probe in res ret=%d devname=%s idfilter0=%#lx idfilter1=%#lx\n", + ret, dev_name(dev), (readl_relaxed(base + REPLICATOR_IDFILTER0)), + (readl_relaxed(base + REPLICATOR_IDFILTER1))); } dev_set_drvdata(dev, drvdata); @@ -272,6 +277,12 @@ static int replicator_probe(struct device *dev, struct resource *res) out_disable_clk: if (ret && !IS_ERR_OR_NULL(drvdata->atclk)) clk_disable_unprepare(drvdata->atclk); + + if (res) + pr_info("replicator probe ret=%d devname=%s idfilter0=%#lx idfilter1=%#lx\n", + ret, dev_name(dev), (readl_relaxed(base + REPLICATOR_IDFILTER0)), + (readl_relaxed(base + REPLICATOR_IDFILTER1))); + return ret; } >> >>> Does your test ever touch EUD (enable the port for EUD at >>> swao-replicator) ? What are the values before you run your test ? >>> >>> >> >> No, we do not use EUD, downstream it is used as dummy sink. >> And I just try to select the ETR as the sink and enable ETM0 as the >> trace source. >> >> echo 1 > /sys/bus/coresight/devices/tmc_etr0/enable_sink >> echo 1 > /sys/bus/coresight/devices/etm0/enable_source >> >> Also I see the KASAN warning but that seems like some other issue. >> > > Does your funnel have sparse input described ? I think we have an > issue with the "refcnt" tracking for funnels (especially). When we > have a sparse input ports described (ie. if only input ports 0, 3, > 5 are described to protect the secure side connections), we could > end up accessing beyond the memory allocated for csdev->refcnts. > i.e, csdev->pdata->nr_inport = 3, and we could access > csdev->refcnts[5], > while sizeof(csdev->refcnts) = sizeof(atomic_t) * 3. > > I will send a patch. > Thanks, I can test it out. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEDAC2BB55 for ; Tue, 7 Apr 2020 15:19:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E102720692 for ; Tue, 7 Apr 2020 15:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gRhn5QAX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="YE+I/RA5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E102720692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CF6wZ2v4Fl+7Og7qyTcqnqTZdi6PGm7Obl4K6lzHytQ=; b=gRhn5QAX67O9IA+iT98r7R/EU E9fv8S4ZdWn7CJHcmYQiYwGacJVo2MvhLB4C1m2WqFtwWNYQlpiVRtncv27WWk9FDIvqrryYIekVc QkJaBxi3IbtQwBIGiOwB6islXHR7eNLnXYQjDm9fgKd8QQlJb0J0cSxmPvHWYpcMHb9V8f3zYLaiH t6LVxVzleUBNl/NeVJmGktEgfdEpVEZHKEFiyNjPMGTuvmhPIBiChk7S9s4KAVZSKWC7+nyQH6bDj CHETbAO/PGeHKsSuAEjqp8zxoHUA6Zm/smm0z3zIXYUKHmpiadx3NQusU0iiQIHSP39+SU3/8/2W2 Yz9yJhiNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLq0D-0002Ck-7t; Tue, 07 Apr 2020 15:19:01 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLq09-0002CG-Rl for linux-arm-kernel@lists.infradead.org; Tue, 07 Apr 2020 15:18:59 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586272737; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=MkHWeN7jEYivOg5ls6MEofDm2yhzyIloU6lj3iDRPEs=; b=YE+I/RA5EvgkU94B/H6mr+LfTnDo+GGlIRePo439Jrap65qdbIfQYr3uK65BG2SZpebExzEk A3sqFdG+2BLifR/q5J+4evgo5J9jSap50LCeF5++CEh3ufW3VFELyW4wAA0uz7KbWPNBWIXO EmBOIEODeongHf5h1kiUoFJ/7Ok= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8c99e0.7fc3d97aef48-smtp-out-n03; Tue, 07 Apr 2020 15:18:56 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 29411C43636; Tue, 7 Apr 2020 15:18:55 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 63272C433D2; Tue, 7 Apr 2020 15:18:54 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 07 Apr 2020 20:48:54 +0530 From: Sai Prakash Ranjan To: Suzuki K Poulose Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections In-Reply-To: References: <20200405102819.28460-1-saiprakash.ranjan@codeaurora.org> <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> <906d374d-a4d6-f2f2-6845-88b97a5ff7d9@arm.com> <39a2b3fff165a108fa59d72b630b5f14@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_081857_960295_3FF6CCD9 X-CRM114-Status: GOOD ( 21.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3V6dWtpLAoKT24gMjAyMC0wNC0wNyAyMDoyMywgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToK PiBPbiAwNC8wNy8yMDIwIDAyOjU2IFBNLCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6Cj4+IEhp IFN1enVraSwKPj4gCj4+IE9uIDIwMjAtMDQtMDcgMTg6MzgsIFN1enVraSBLIFBvdWxvc2Ugd3Jv dGU6Cj4+PiBPbiAwNC8wNy8yMDIwIDEyOjI5IFBNLCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6 Cj4+Pj4gSGkgU3V6dWtpLAo+Pj4+IAo+Pj4+IFRoYW5rcyBmb3IgbG9va2luZyBpbnRvIHRoaXMg aXNzdWUuCj4+Pj4gCj4+Pj4gT24gMjAyMC0wNC0wNyAxNTo1NCwgU3V6dWtpIEsgUG91bG9zZSB3 cm90ZToKPj4+Pj4gT24gMDQvMDcvMjAyMCAxMDo0NiBBTSwgU2FpIFByYWthc2ggUmFuamFuIHdy b3RlOgo+Pj4+PiAKPj4+Pj4gVGhlcmUgc2VlbXMgdG8gYmUgdHdvIHJlcGxpY2F0b3JzIGJhY2sg dG8gYmFjayBoZXJlLiBXaGF0IGlzIAo+Pj4+PiBjb25uZWN0ZWQKPj4+Pj4gdG8gdGhlIG90aGVy IG91dHB1dCBvZiBib3RoIG9mIHRoZW0gPyBBcmUgdGhlcmUgYW55IFRQSVVzID8gV2hhdCAKPj4+ Pj4gaGFwcGVucwo+Pj4+PiBpZiB5b3UgY2hvb3NlIGEgc2luayBvbiB0aGUgb3RoZXIgZW5kIG9m ICJzd2FvX3JlcGxpY2F0b3IiIChFVEIgPykKPj4+Pj4gCj4+Pj4gCj4+Pj4gVGhlIG90aGVyIG91 dHBvcnQgb2Ygc3dhbyByZXBsaWNhdG9yIGlzIGNvbm5lY3RlZCB0byBFVUQgd2hpY2ggaXMgYQo+ Pj4+IFFDT00gc3BlY2lmaWMgSFcgd2hpY2ggY2FuIGJlIHVzZWQgYXMgYSBzaW5rIGxpa2UgVVNC Lgo+Pj4+IEFuZCB0aGUgb3RoZXIgb3V0cG9ydCBvZiBvdGhlciByZXBsaWNhdG9yKHJlcGxpY2F0 b3Jfb3V0KSBpcyAKPj4+PiBjb25uZWN0ZWQgdG8KPj4+PiBUUElVLgo+Pj4+IAo+Pj4+PiBBZnRl ciBib290LCB3aGF0IGRvIHRoZSBpZGZpbHRlciByZWdpc3RlcnMgcmVhZCBmb3IgYm90aCB0aGUg Cj4+Pj4+IHJlcGxpY2F0b3JzID8KPj4+Pj4gCj4+Pj4gCj4+Pj4gQWRkZWQgc29tZSBwcmludHMg aW4gcmVwbGljYXRvcl9wcm9iZS4KPj4+PiAKPj4+PiDCoMKgcmVwbGljYXRvciBwcm9iZSByZXQ9 LTUxNyBkZXZuYW1lPTYwNDYwMDAucmVwbGljYXRvciBpZGZpbHRlcjA9MHgwIAo+Pj4+IGlkZmls dGVyMT0weDAKPj4+PiDCoMKgcmVwbGljYXRvciBwcm9iZSByZXQ9MCBkZXZuYW1lPTZiMDYwMDAu cmVwbGljYXRvciBpZGZpbHRlcjA9MHhmZiAKPj4+PiBpZGZpbHRlcjE9MHhmZgo+Pj4+IMKgwqBy ZXBsaWNhdG9yIHByb2JlIHJldD0wIGRldm5hbWU9NjA0NjAwMC5yZXBsaWNhdG9yIGlkZmlsdGVy MD0weGZmIAo+Pj4+IGlkZmlsdGVyMT0weGZmCj4+PiAKPj4+IEN1cmlvdXMgdG8gc2VlIGhvdyB0 aGUgaWRmaWx0ZXJYIGlzIHNldCB0byAwOgo+Pj4gwqDCoMKgwqAgaWYgdGhhdCBpcyBuZXZlciB1 c2VkLgo+Pj4gwqDCoMKgwqDCoMKgwqAgT3IKPj4+IMKgwqDCoMKgIGlmIHRoZSB1c2VyIGRvZXNu J3QgcmVzZXQgaXQgYmFjayB0byAweGZmLgo+Pj4gCj4+IAo+PiBGb3IgYm90aCByZXBsaWNhdG9y cywgdGhlIGRlZmF1bHQgdmFsdWUgc2VlbXMgdG8gYmUgMHgwLgo+PiAKPj4gIMKgcmVwbGljYXRv ciBwcm9iZSBpbiByZXMgcmV0PTAgZGV2bmFtZT02MDQ2MDAwLnJlcGxpY2F0b3IgCj4+IGlkZmls dGVyMD0weDAgaWRmaWx0ZXIxPTB4MAo+PiAgwqByZXBsaWNhdG9yIHByb2JlIHJldD0tNTE3IGRl dm5hbWU9NjA0NjAwMC5yZXBsaWNhdG9yIGlkZmlsdGVyMD0weDAgCj4+IGlkZmlsdGVyMT0weDAK Pj4gIMKgcmVwbGljYXRvciBwcm9iZSBpbiByZXMgcmV0PTAgZGV2bmFtZT02YjA2MDAwLnJlcGxp Y2F0b3IgCj4+IGlkZmlsdGVyMD0weDAgaWRmaWx0ZXIxPTB4MAo+PiAgwqByZXBsaWNhdG9yIHBy b2JlIHJldD0wIGRldm5hbWU9NmIwNjAwMC5yZXBsaWNhdG9yIGlkZmlsdGVyMD0weGZmIAo+PiBp ZGZpbHRlcjE9MHhmZgo+PiAgwqByZXBsaWNhdG9yIHByb2JlIGluIHJlcyByZXQ9MCBkZXZuYW1l PTYwNDYwMDAucmVwbGljYXRvciAKPj4gaWRmaWx0ZXIwPTB4MCBpZGZpbHRlcjE9MHgwCj4+ICDC oHJlcGxpY2F0b3IgcHJvYmUgcmV0PTAgZGV2bmFtZT02MDQ2MDAwLnJlcGxpY2F0b3IgaWRmaWx0 ZXIwPTB4ZmYgCj4+IGlkZmlsdGVyMT0weGZmCj4gCj4gSSBhbSBub3Qgc3VyZSBob3cgeW91IGhh dmUgYWRkZWQgdGhlIGRlYnVncywgYnV0IGl0IGxvb2tzIGxpa2UgdGhlCj4gZHJpdmVycyBzZXQg MHhmZiBmb3IgYm90aCB0aGUgcG9ydCBmaWx0ZXJzIG9uIGEgc3VjY2Vzc2Z1bCBwcm9iZS4KPiAK ClllcywgdGhhdHMgZG9uZSBieSByZXBsaWNhdG9yX3Jlc2V0IGluIHByb2JlIHJpZ2h0PyBCZWxv dyBpcyB0aGUgZGlmZjoKCkBAIC0yNDIsNiArMjQ0LDkgQEAgc3RhdGljIGludCByZXBsaWNhdG9y X3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgCnN0cnVjdCByZXNvdXJjZSAqcmVzKQogICAgICAg ICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBkcnZkYXRhLT5iYXNlID0gYmFzZTsKICAgICAg ICAgICAgICAgICBkZXNjLmdyb3VwcyA9IHJlcGxpY2F0b3JfZ3JvdXBzOworICAgICAgICAgICAg ICAgcHJfaW5mbygicmVwbGljYXRvciBwcm9iZSBpbiByZXMgcmV0PSVkIGRldm5hbWU9JXMgCmlk ZmlsdGVyMD0lI2x4IGlkZmlsdGVyMT0lI2x4XG4iLAorICAgICAgICAgICAgICAgICAgICAgICBy ZXQsIGRldl9uYW1lKGRldiksIChyZWFkbF9yZWxheGVkKGJhc2UgKyAKUkVQTElDQVRPUl9JREZJ TFRFUjApKSwKKyAgICAgICAgICAgICAgICAgICAgICAgKHJlYWRsX3JlbGF4ZWQoYmFzZSArIFJF UExJQ0FUT1JfSURGSUxURVIxKSkpOwogICAgICAgICB9CgogICAgICAgICBkZXZfc2V0X2RydmRh dGEoZGV2LCBkcnZkYXRhKTsKQEAgLTI3Miw2ICsyNzcsMTIgQEAgc3RhdGljIGludCByZXBsaWNh dG9yX3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwgCnN0cnVjdCByZXNvdXJjZSAqcmVzKQogIG91 dF9kaXNhYmxlX2NsazoKICAgICAgICAgaWYgKHJldCAmJiAhSVNfRVJSX09SX05VTEwoZHJ2ZGF0 YS0+YXRjbGspKQogICAgICAgICAgICAgICAgIGNsa19kaXNhYmxlX3VucHJlcGFyZShkcnZkYXRh LT5hdGNsayk7CisKKyAgICAgICBpZiAocmVzKQorICAgICAgICAgICAgICAgcHJfaW5mbygicmVw bGljYXRvciBwcm9iZSByZXQ9JWQgZGV2bmFtZT0lcyAKaWRmaWx0ZXIwPSUjbHggaWRmaWx0ZXIx PSUjbHhcbiIsCisgICAgICAgICAgICAgICAgICAgICAgIHJldCwgZGV2X25hbWUoZGV2KSwgKHJl YWRsX3JlbGF4ZWQoYmFzZSArIApSRVBMSUNBVE9SX0lERklMVEVSMCkpLAorICAgICAgICAgICAg ICAgICAgICAgICAocmVhZGxfcmVsYXhlZChiYXNlICsgUkVQTElDQVRPUl9JREZJTFRFUjEpKSk7 CisKICAgICAgICAgcmV0dXJuIHJldDsKICB9Cgo+PiAKPj4+IERvZXMgeW91ciB0ZXN0IGV2ZXIg dG91Y2ggRVVEIChlbmFibGUgdGhlIHBvcnQgZm9yIEVVRCBhdAo+Pj4gc3dhby1yZXBsaWNhdG9y KSA/IFdoYXQgYXJlIHRoZSB2YWx1ZXMgYmVmb3JlIHlvdSBydW4geW91ciB0ZXN0ID8KPj4+IAo+ Pj4gCj4+IAo+PiBObywgd2UgZG8gbm90IHVzZSBFVUQsIGRvd25zdHJlYW0gaXQgaXMgdXNlZCBh cyBkdW1teSBzaW5rLgo+PiBBbmQgSSBqdXN0IHRyeSB0byBzZWxlY3QgdGhlIEVUUiBhcyB0aGUg c2luayBhbmQgZW5hYmxlIEVUTTAgYXMgdGhlIAo+PiB0cmFjZSBzb3VyY2UuCj4+IAo+PiBlY2hv IDEgPiAvc3lzL2J1cy9jb3Jlc2lnaHQvZGV2aWNlcy90bWNfZXRyMC9lbmFibGVfc2luawo+PiBl Y2hvIDEgPiAvc3lzL2J1cy9jb3Jlc2lnaHQvZGV2aWNlcy9ldG0wL2VuYWJsZV9zb3VyY2UKPj4g Cj4+IEFsc28gSSBzZWUgdGhlIEtBU0FOIHdhcm5pbmcgYnV0IHRoYXQgc2VlbXMgbGlrZSBzb21l IG90aGVyIGlzc3VlLgo+PiAKPiAKPiBEb2VzIHlvdXIgZnVubmVsIGhhdmUgc3BhcnNlIGlucHV0 IGRlc2NyaWJlZCA/IEkgdGhpbmsgd2UgaGF2ZSBhbgo+IGlzc3VlIHdpdGggdGhlICJyZWZjbnQi IHRyYWNraW5nIGZvciBmdW5uZWxzIChlc3BlY2lhbGx5KS4gV2hlbiB3ZQo+IGhhdmUgYSBzcGFy c2UgaW5wdXQgcG9ydHMgZGVzY3JpYmVkIChpZS4gaWYgb25seSBpbnB1dCBwb3J0cyAwLCAzLAo+ IDUgYXJlIGRlc2NyaWJlZCB0byBwcm90ZWN0IHRoZSBzZWN1cmUgc2lkZSBjb25uZWN0aW9ucyks IHdlIGNvdWxkCj4gZW5kIHVwIGFjY2Vzc2luZyBiZXlvbmQgdGhlIG1lbW9yeSBhbGxvY2F0ZWQg Zm9yIGNzZGV2LT5yZWZjbnRzLgo+IGkuZSwgY3NkZXYtPnBkYXRhLT5ucl9pbnBvcnQgPSAzLCBh bmQgd2UgY291bGQgYWNjZXNzIAo+IGNzZGV2LT5yZWZjbnRzWzVdLAo+IHdoaWxlIHNpemVvZihj c2Rldi0+cmVmY250cykgPSBzaXplb2YoYXRvbWljX3QpICogMy4KPiAKPiBJIHdpbGwgc2VuZCBh IHBhdGNoLgo+IAoKVGhhbmtzLCBJIGNhbiB0ZXN0IGl0IG91dC4KClRoYW5rcywKU2FpCgotLSAK UVVBTENPTU0gSU5ESUEsIG9uIGJlaGFsZiBvZiBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwg SW5jLiBpcyBhIAptZW1iZXIKb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGlu dXggRm91bmRhdGlvbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=