All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 3/3] bpftool: add gen subcommand manpage
Date: Tue, 17 Dec 2019 21:27:46 +0000	[thread overview]
Message-ID: <a722caf8-a4af-4476-d560-396dd30dfb0a@fb.com> (raw)
In-Reply-To: <20191217053626.2158870-4-andriin@fb.com>



On 12/16/19 9:36 PM, Andrii Nakryiko wrote:
> Add bpftool-gen.rst describing skeleton on the high level. Also include
> a small, but complete, example BPF app (BPF side, userspace side, generated
> skeleton) in example section to demonstrate skeleton API and its usage.
> 
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

When applying the patch locally (git apply <>), I see below:
-bash-4.4$ git apply ~/p3.txt
/home/yhs/p3.txt:183: trailing whitespace.

/home/yhs/p3.txt:187: trailing whitespace.

/home/yhs/p3.txt:189: space before tab in indent.
         __uint(type, BPF_MAP_TYPE_HASH);
/home/yhs/p3.txt:190: space before tab in indent.
         __uint(max_entries, 128);
/home/yhs/p3.txt:191: space before tab in indent.
         __type(key, int);
warning: squelched 77 whitespace errors
warning: 82 lines add whitespace errors.
-bash-4.4$

space before tab might be fine since it is an code in the example file.
But tailing whitespaces probably should be fixed.

With the above in mind,

Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2019-12-17 21:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  5:36 [PATCH bpf-next 0/3] Skeleton improvements and documnetation Andrii Nakryiko
2019-12-17  5:36 ` [PATCH bpf-next 1/3] bpftool, selftests/bpf: embed object file inside skeleton Andrii Nakryiko
2019-12-17 21:23   ` Yonghong Song
2019-12-17  5:36 ` [PATCH bpf-next 2/3] libbpf: remove BPF_EMBED_OBJ macro from libbpf.h Andrii Nakryiko
2019-12-17 21:24   ` Yonghong Song
2019-12-17  5:36 ` [PATCH bpf-next 3/3] bpftool: add gen subcommand manpage Andrii Nakryiko
2019-12-17 21:27   ` Yonghong Song [this message]
2019-12-17 22:54     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a722caf8-a4af-4476-d560-396dd30dfb0a@fb.com \
    --to=yhs@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.