All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Jerome Glisse <glisse@freedesktop.org>
Cc: airlied@linux.ie, dri-devel@lists.sf.net
Subject: Re: Fix r6xx/r7xx cs checker
Date: Thu, 11 Feb 2010 10:54:49 -0500	[thread overview]
Message-ID: <a728f9f91002110754l281f8b97kb77fd64065edc643@mail.gmail.com> (raw)
In-Reply-To: <a728f9f91002110714i58dbc3fbi555d2d26c76c1378@mail.gmail.com>

On Thu, Feb 11, 2010 at 10:14 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Thu, Feb 11, 2010 at 6:49 AM, Jerome Glisse <glisse@freedesktop.org> wrote:
>> Hi,
>>
>> Ok never do small change which looks innocuous late at night.
>> There was an double free. Attached is too patch, either one
>> that apply on top of your free or a new big cs checker patch
>> with the fix inside. I let you chose :)
>>
>
> Cubemaps require 8 face alignment on r6xx+
>

Also some warnings:
drivers/gpu/drm/radeon/r600_cs.c: In function ‘r600_cs_track_check’:
drivers/gpu/drm/radeon/r600_cs.c:166: warning: ‘bpe’ may be used
uninitialized in this function
drivers/gpu/drm/radeon/r600_cs.c:166: note: ‘bpe’ was declared here
drivers/gpu/drm/radeon/r600_cs.c: In function ‘r600_cs_parse’:
drivers/gpu/drm/radeon/r600_cs.c:938: warning: ‘bpe’ may be used
uninitialized in this function
drivers/gpu/drm/radeon/r600_cs.c:938: note: ‘bpe’ was declared here

Alex

> Alex
>
>
>> Cheers,
>> Jerome
>>
>> ------------------------------------------------------------------------------
>> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>> http://p.sf.net/sfu/solaris-dev2dev
>> --
>> _______________________________________________
>> Dri-devel mailing list
>> Dri-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/dri-devel
>>
>>
>

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--

      reply	other threads:[~2010-02-11 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 11:49 Fix r6xx/r7xx cs checker Jerome Glisse
2010-02-11 15:14 ` Alex Deucher
2010-02-11 15:54   ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a728f9f91002110754l281f8b97kb77fd64065edc643@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.sf.net \
    --cc=glisse@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.