All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Patrick Keroulas <patrick.keroulas@radio-canada.ca>, dev@dpdk.org
Cc: Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [dpdk-dev] [RFC] [PATCH v1 3/3] net/pcap: dump hardware timestamps
Date: Tue, 9 Jun 2020 15:41:02 +0100	[thread overview]
Message-ID: <a749815e-2b6d-2614-dd6d-af9d8fbaec1e@intel.com> (raw)
In-Reply-To: <20200609141713.11614-4-patrick.keroulas@radio-canada.ca>

On 6/9/2020 3:17 PM, Patrick Keroulas wrote:
> When hardware timestamping is activated, system time should no longer be
> used to timestamp dumped the packets. Instead, use value held by
> forwarded and assume they were converted to nanoseconds.
> 
> Signed-off-by: Patrick Keroulas <patrick.keroulas@radio-canada.ca>
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>

I think better to get the Vivien's patch that enables 'nanosecond timestamp',
with requested change first and later this patch can be on top of it to add
PKT_RX_TIMESTAMP support.

Or you can split the patch into two, as mentioned above, both are OK but I don't
want pcap nanosecond timestamp patch blocked from this hw timestamp patchset
discussions.


  reply	other threads:[~2020-06-09 14:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 14:17 [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5 Patrick Keroulas
2020-06-09 14:17 ` [dpdk-dev] [RFC] [PATCH v1 1/3] net/mlx5: add timestamp-to-ns converter from libibverbs Patrick Keroulas
2020-06-09 14:17 ` [dpdk-dev] [RFC] [PATCH v1 2/3] ethdev: add API to convert raw timestamps to nsec Patrick Keroulas
2020-06-09 14:17 ` [dpdk-dev] [RFC] [PATCH v1 3/3] net/pcap: dump hardware timestamps Patrick Keroulas
2020-06-09 14:41   ` Ferruh Yigit [this message]
2020-06-10 13:51     ` Ferruh Yigit
2020-06-23 15:07 ` [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5 Slava Ovsiienko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a749815e-2b6d-2614-dd6d-af9d8fbaec1e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=patrick.keroulas@radio-canada.ca \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.