From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54DE68 for ; Sun, 31 Oct 2021 19:17:48 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id j9so7127186pgh.1 for ; Sun, 31 Oct 2021 12:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IAQ9nS8zKiAKP+4KgFuPNyKJDmfU+i6EpAM9T4tSUtw=; b=i0EYSUQ7VpH5A/MnbnEC0gEINup6xLh2LbKSvdklw8xQz5OpPD4PcA8WrICnUcqkc5 gRxQhg8nasVHZldUCompSYSz3D9ugrVPh81OOI394f5AwDcVna0XSJK1XXp0KqhjKz/S 1g7xXRWIWtrnv/N7sfgnmdERZNiXZtKvEqR1VQ3WB0IXwAwLk4DBJ0p0hC0pqtTGnKsj bcDRsGG0tOExnllq2RNzJYPtKt1f4jtkXDVyMSstzHN59ehMW6xtSeGUZ8n6tLnPAsCK WSGAMtI5dDXmq35UuCHxMg+L++HJHbDXjXXSmLlwkCKG3bVe+hLeGcyEas9TVe+F/ZsT +8MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IAQ9nS8zKiAKP+4KgFuPNyKJDmfU+i6EpAM9T4tSUtw=; b=Pa6Vr7rtfpfYs1PCq+sssgsQvlRBNVYKxm+gd0LxE3R1b6KETLTOhjJUAfP+u4mmeF GBrX1qjhLUVNPWKXxcfac4R8Y9eBEW+fP+qPo56SHjR+Sg/9K2H6XkU6wzcwBRSck2ch Uu15/oytZNFnds8ntB4ZvYUg5M1EvbltfwnzCfEYLiv947taEH6GdgnWFZL+KoPRO9Xk rstH3L24z4sl1WsSzdf02rw8kPcboJLBHLPYWkZfl9P6TZ8dU68qs2yEPthe1b7HJMcM xlIwJGG8x74S26Pfrl1liLipKpZ2ue0vthJbn1DV8bsGi0SxLGRnuHA6tbF4s1CvQYlc ztuQ== X-Gm-Message-State: AOAM531AMSGlC+X9suSmWvqpTVfYNiorjgJ1p+F6S6PvdrG4Aqu+ArtP 0uHEBG2haYlI1OL44jMA07abqgN+bk4= X-Google-Smtp-Source: ABdhPJyfyL7jHzp387xHqNSgFcLlUrBgq9kV4JwSY6f7SCVTQqhZEIWgEkv7sKTZsI5cMno3Ob49zA== X-Received: by 2002:a05:6a00:1906:b0:44c:b35d:71a8 with SMTP id y6-20020a056a00190600b0044cb35d71a8mr24421320pfi.51.1635707868249; Sun, 31 Oct 2021 12:17:48 -0700 (PDT) Received: from [192.168.1.2] ([59.95.88.136]) by smtp.gmail.com with ESMTPSA id z10sm13461694pfh.106.2021.10.31.12.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 12:17:48 -0700 (PDT) Message-ID: Date: Mon, 1 Nov 2021 00:47:40 +0530 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement Content-Language: en-GB To: Pavel Skripkin , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Saurav Girepunje In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/11/21 12:13 am, Pavel Skripkin wrote: > On 10/31/21 21:10, Saurav Girepunje wrote: >> Remove the goto statement from rtw_init_drv_sw(). In this function goto >> can be replace by return statement. As on goto label exit, function >> only return it is not performing any cleanup. Avoiding goto will >> improve the function readability. >> >> Signed-off-by: Saurav Girepunje >> --- >>   drivers/staging/r8188eu/os_dep/os_intfs.c | 39 +++++++---------------- >>   1 file changed, 12 insertions(+), 27 deletions(-) >> >> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c >> index 1418c9c4916c..4b409479108e 100644 >> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c >> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c >> @@ -480,48 +480,34 @@ u8 rtw_init_drv_sw(struct adapter *padapter) >>   { >>       u8    ret8 = _SUCCESS; >> > > > Btw, this variable can be removed completely then. It's used only for: > > ret8 = rtw_init_default_value(padapter); > > with your patch applied, but rtw_init_default_value() always returns _SUCCESS. > I think rtw_init_default_value should return void. It's return value is not useful. > >> -exit: >>      return ret8; >>  } > > > And just `return _SUCCESS;` here. > However rtw_init_drv_sw should return _SUCCESS here. > > With regards, > Pavel Skripkin Regards, Saurav