From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932160AbeE1KAb (ORCPT ); Mon, 28 May 2018 06:00:31 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:38974 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173AbeE1KA2 (ORCPT ); Mon, 28 May 2018 06:00:28 -0400 Subject: Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device To: Jan Kiszka , Bjorn Helgaas , Linux Kernel Mailing List , , References: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> CC: Jingoo Han , Joao Pinto , Lorenzo Pieralisi From: Vladimir Zapolskiy Message-ID: Date: Mon, 28 May 2018 13:00:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.87] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Another step towards a managed version of > of_pci_get_host_bridge_resources(): Feed in the underlying device, > rather than just the OF node. This will allow to use managed resource > allocation internally later on. > > CC: Jingoo Han > CC: Joao Pinto > CC: Lorenzo Pieralisi > Signed-off-by: Jan Kiszka [snip] > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c > index a6af62e0256d..61802e55a00c 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) > { > int err, res_valid = 0; > struct device *dev = &pcie->pdev->dev; > - struct device_node *np = dev->of_node; > struct resource_entry *win; > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, > - NULL); > + err = of_pci_get_host_bridge_resources(dev, 0, 0xff > + &pcie->resources, NULL); > if (err) > return err; > In case if it is an undiscovered issue, a comma was mistakenly removed, which will result it compilation error. The problem is also found in pci/next , see commit 88e3909aa125. -- With best wishes, Vladimir From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device To: Jan Kiszka , Bjorn Helgaas , Linux Kernel Mailing List , , References: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> From: Vladimir Zapolskiy Message-ID: Date: Mon, 28 May 2018 13:00:21 +0300 MIME-Version: 1.0 In-Reply-To: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Joao Pinto , Lorenzo Pieralisi Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Another step towards a managed version of > of_pci_get_host_bridge_resources(): Feed in the underlying device, > rather than just the OF node. This will allow to use managed resource > allocation internally later on. > > CC: Jingoo Han > CC: Joao Pinto > CC: Lorenzo Pieralisi > Signed-off-by: Jan Kiszka [snip] > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c > index a6af62e0256d..61802e55a00c 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) > { > int err, res_valid = 0; > struct device *dev = &pcie->pdev->dev; > - struct device_node *np = dev->of_node; > struct resource_entry *win; > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, > - NULL); > + err = of_pci_get_host_bridge_resources(dev, 0, 0xff > + &pcie->resources, NULL); > if (err) > return err; > In case if it is an undiscovered issue, a comma was mistakenly removed, which will result it compilation error. The problem is also found in pci/next , see commit 88e3909aa125. -- With best wishes, Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: vladimir_zapolskiy@mentor.com (Vladimir Zapolskiy) Date: Mon, 28 May 2018 13:00:21 +0300 Subject: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device In-Reply-To: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> References: <5f2226585c6af9920b266d0503e32042d4c9e440.1526375226.git.jan.kiszka@siemens.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Another step towards a managed version of > of_pci_get_host_bridge_resources(): Feed in the underlying device, > rather than just the OF node. This will allow to use managed resource > allocation internally later on. > > CC: Jingoo Han > CC: Joao Pinto > CC: Lorenzo Pieralisi > Signed-off-by: Jan Kiszka [snip] > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c > index a6af62e0256d..61802e55a00c 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) > { > int err, res_valid = 0; > struct device *dev = &pcie->pdev->dev; > - struct device_node *np = dev->of_node; > struct resource_entry *win; > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, > - NULL); > + err = of_pci_get_host_bridge_resources(dev, 0, 0xff > + &pcie->resources, NULL); > if (err) > return err; > In case if it is an undiscovered issue, a comma was mistakenly removed, which will result it compilation error. The problem is also found in pci/next , see commit 88e3909aa125. -- With best wishes, Vladimir