From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] configs: icorem6: Use imx6 cratch register for bootcount
Date: Thu, 21 Mar 2019 10:05:34 +0100 [thread overview]
Message-ID: <a75767e1-b530-3111-8a3a-31115b0ccecb@denx.de> (raw)
In-Reply-To: <20190321083553.4068-1-jagan@amarulasolutions.com>
Hi Jagan,
nitpick: cratch ==> scratch
On 21/03/19 09:35, Jagan Teki wrote:
> SRAM address used for bootcount on exiting code is erasing
> previous count value when system reset from Linux. So use
> the dedicated imx6 scratch register, GPR2 to preserve the
> contents even if the system reset from Linux.
>
> Fixes: 4eb9aa39350e ("configs: imx6qdl_icore_mmc: Enable watchdog and bootcounter")
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> configs/imx6qdl_icore_mmc_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/imx6qdl_icore_mmc_defconfig b/configs/imx6qdl_icore_mmc_defconfig
> index 68ad1c6d20..24e99718e6 100644
> --- a/configs/imx6qdl_icore_mmc_defconfig
> +++ b/configs/imx6qdl_icore_mmc_defconfig
> @@ -16,7 +16,7 @@ CONFIG_CMD_BOOTCOUNT=y
> CONFIG_BOOTCOUNT_LIMIT=y
> CONFIG_BOOTCOUNT_BOOTLIMIT=3
> CONFIG_SYS_BOOTCOUNT_SINGLEWORD=y
> -CONFIG_SYS_BOOTCOUNT_ADDR=0x00900000
> +CONFIG_SYS_BOOTCOUNT_ADDR=0x020D8024
> CONFIG_SYS_BOOTCOUNT_MAGIC=0x0B01C041
> CONFIG_IMX_WATCHDOG=y
> CONFIG_DEBUG_UART=y
>
Just as info: I confirm that using start address of SRAM does not work.
Rather even the GPRx registers are not a common solution. I have already
seen that even the GPRx registers are touched and cannot be used on some
i.MX6 variant. Anyway, if this works on your board, fine.
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2019-03-21 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 8:35 [U-Boot] [PATCH] configs: icorem6: Use imx6 cratch register for bootcount Jagan Teki
2019-03-21 8:45 ` Shyam Saini
2019-03-21 9:05 ` Stefano Babic [this message]
2019-03-21 9:51 ` Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a75767e1-b530-3111-8a3a-31115b0ccecb@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.