From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D5AC388F9 for ; Wed, 11 Nov 2020 10:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FF472075A for ; Wed, 11 Nov 2020 10:25:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHudV4l+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbgKKKZj (ORCPT ); Wed, 11 Nov 2020 05:25:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726644AbgKKKZi (ORCPT ); Wed, 11 Nov 2020 05:25:38 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2F4C0613D1; Wed, 11 Nov 2020 02:25:38 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id r9so2421177lfn.11; Wed, 11 Nov 2020 02:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YDPQOCu1Q0bKCPL6C42R2nt86MKzHJcXkgJe5Eo+/zI=; b=nHudV4l+RFcBpr3axrfNNEScRTyu6drP6JREhMmAoVRKbdS57PvlkXk9toKfclED2s 5G/GJ7KJRJsFYOl4i6+hz5/nD17g2tiqobNLOl91ANza33Te94/voQb5CZ0zp8lD2BIl PU7rMO+1CqahgPqwQycUOiQXXBNmJQk5SzllsR4JSzuOTWV21BW2AOMl66pxwuXjhOh/ Vjvfq/UE6EkhNOnrClbk3roh6SxJVnCQ9D2Ww2U+TE3x7kVzsAdfFNebF1olzKADUOvJ t9JGDbP2u/DDS6t4RZ6L5CjtUW62hY2Z2f/G4Lmf7wPuz8IPXZquX5zg6jtdtLe8EzzV WHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YDPQOCu1Q0bKCPL6C42R2nt86MKzHJcXkgJe5Eo+/zI=; b=m76ZrIGuZ980yAWKz1yFwTgrCiIPxwEMyEVEb17o+Ta4y/Y/bmkjAB9DOM+m/ZEzsJ XKZDkMmGy4ryp5nCp8cOYROit8neLzq5xu9NxjgOMeRdw4AVrjiJgGIKSVs/pTMrgoV5 PlUMgLZFKfxF5XDo3nXTiJgvj5myQX+yJ85LjH/LRvXdqGhO58Gzf5WRrwAVM3ELmx4z I41LRsYIk4fquZa6xg5VAnhSm/g2aQVEZ8k4VfEFgtIWoKGdJYutHA6Iaw83b3BS5Xcc 5RWLCtdT5Sr1mDGqmGgyQ3c2oGAZ4P5Ni6w2DAX4TKoXzTG1DbaPjN3r9lsuo3p5Kmzc BxwQ== X-Gm-Message-State: AOAM530PAsYMwTQ+eij4Y/U+nFhhflS6JtV4d8rabMZx6d68uUtV8xUN aRwxSM5mudlnEKXO6GgRfoQ= X-Google-Smtp-Source: ABdhPJzTv9Jyb7R3JTGhtKOKkgm12/bRzXfaFk0KiQNWX12jN9WFCPB0iS0jN9FOqsksEXFAwAJolg== X-Received: by 2002:ac2:53a1:: with SMTP id j1mr8775060lfh.236.1605090336653; Wed, 11 Nov 2020 02:25:36 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id t13sm62578lfl.294.2020.11.11.02.25.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 02:25:35 -0800 (PST) Subject: Re: [PATCH v8 11/26] memory: tegra124-emc: Make driver modular To: Krzysztof Kozlowski Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20201111011456.7875-1-digetx@gmail.com> <20201111011456.7875-12-digetx@gmail.com> <20201111090434.GB4050@kozik-lap> <20201111092619.GD4050@kozik-lap> From: Dmitry Osipenko Message-ID: Date: Wed, 11 Nov 2020 13:25:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201111092619.GD4050@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 11.11.2020 12:26, Krzysztof Kozlowski пишет: >> 11.11.2020 12:04, Krzysztof Kozlowski пишет: >>>> -obj-$(CONFIG_TEGRA124_EMC) += clk-tegra124-emc.o >>>> +obj-$(CONFIG_ARCH_TEGRA_124_SOC) += clk-tegra124-emc.o >>>> +obj-$(CONFIG_ARCH_TEGRA_132_SOC) += clk-tegra124-emc.o >>> How is it related to modularization? It looks like different issue is >>> fixed here. >> The CONFIG_TEGRA124_EMC now could be 'm', while the clock code must be >> built-in. The TEGRA124 EMC driver is used by T124 and T132 SoCs.\ > Mhmm, the CONFIG_TEGRA124_EMC depends on ARCH_TEGRA_124_SOC so on the > config !ARCH_TEGRA_124_SOC && ARCH_TEGRA_132_SOC this was not > selected. Now it will be selected. > The driver isn't exposed on ARM64 probably because nobody bothered to do it so far. But it's not also the memory driver which depends on clk-tegra124-emc.o, it's also the main clk/tegra/clk-tegra124.c driver itself, which is also used by both T124/132. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBEBC55ABD for ; Thu, 12 Nov 2020 08:16:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0784222228 for ; Thu, 12 Nov 2020 08:16:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHudV4l+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0784222228 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76D0E6E193; Thu, 12 Nov 2020 08:15:52 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97ADC89F24 for ; Wed, 11 Nov 2020 10:25:38 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id 74so2462476lfo.5 for ; Wed, 11 Nov 2020 02:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YDPQOCu1Q0bKCPL6C42R2nt86MKzHJcXkgJe5Eo+/zI=; b=nHudV4l+RFcBpr3axrfNNEScRTyu6drP6JREhMmAoVRKbdS57PvlkXk9toKfclED2s 5G/GJ7KJRJsFYOl4i6+hz5/nD17g2tiqobNLOl91ANza33Te94/voQb5CZ0zp8lD2BIl PU7rMO+1CqahgPqwQycUOiQXXBNmJQk5SzllsR4JSzuOTWV21BW2AOMl66pxwuXjhOh/ Vjvfq/UE6EkhNOnrClbk3roh6SxJVnCQ9D2Ww2U+TE3x7kVzsAdfFNebF1olzKADUOvJ t9JGDbP2u/DDS6t4RZ6L5CjtUW62hY2Z2f/G4Lmf7wPuz8IPXZquX5zg6jtdtLe8EzzV WHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YDPQOCu1Q0bKCPL6C42R2nt86MKzHJcXkgJe5Eo+/zI=; b=BCoaAV/OXiuKrEtpL7Wrt7rClntTraTSZcqlnTiLWinwagkuYL8jcTgTvtfg4g9zp1 FjigfdXoA7ciebiBz2A5DB9A49Kq6Hh067bb8UyNgWGmvs2nSclcR4q6lC6z9cB3wMUu yn0pWJIOxZhZyHXAWcaNkuLz0CPyWkw1nXESm5gBQqnURyo+aErOFDqrwBHVrlDPvS1Z cbVwsGH099iJc2ML488PL+h83tJB0cZ5bnOlQWcJi9DBTFb4ywSiQLq5OY301Ey5jZHm E5RY2lvLVXzN8p+nH1KEW9Z5im4624Zy/wfKDBjcm/LdesF6xFJdZxtmLzd0+fLUKqIu QWTw== X-Gm-Message-State: AOAM532TAmE5Ap6juhD+O0rve3psbUNDczwtg77kHGlCNbM49hRcjfvX gl3QQW8iJvVrEb7RXwo15n+bpkE6IBw= X-Google-Smtp-Source: ABdhPJzTv9Jyb7R3JTGhtKOKkgm12/bRzXfaFk0KiQNWX12jN9WFCPB0iS0jN9FOqsksEXFAwAJolg== X-Received: by 2002:ac2:53a1:: with SMTP id j1mr8775060lfh.236.1605090336653; Wed, 11 Nov 2020 02:25:36 -0800 (PST) Received: from [192.168.2.145] (109-252-193-159.dynamic.spd-mgts.ru. [109.252.193.159]) by smtp.googlemail.com with ESMTPSA id t13sm62578lfl.294.2020.11.11.02.25.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 02:25:35 -0800 (PST) Subject: Re: [PATCH v8 11/26] memory: tegra124-emc: Make driver modular To: Krzysztof Kozlowski References: <20201111011456.7875-1-digetx@gmail.com> <20201111011456.7875-12-digetx@gmail.com> <20201111090434.GB4050@kozik-lap> <20201111092619.GD4050@kozik-lap> From: Dmitry Osipenko Message-ID: Date: Wed, 11 Nov 2020 13:25:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201111092619.GD4050@kozik-lap> Content-Language: en-US X-Mailman-Approved-At: Thu, 12 Nov 2020 08:15:51 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTEuMTEuMjAyMCAxMjoyNiwgS3J6eXN6dG9mIEtvemxvd3NraSDQv9C40YjQtdGCOgo+PiAxMS4x MS4yMDIwIDEyOjA0LCBLcnp5c3p0b2YgS296bG93c2tpINC/0LjRiNC10YI6Cj4+Pj4gLW9iai0k KENPTkZJR19URUdSQTEyNF9FTUMpCQkrPSBjbGstdGVncmExMjQtZW1jLm8KPj4+PiArb2JqLSQo Q09ORklHX0FSQ0hfVEVHUkFfMTI0X1NPQykJKz0gY2xrLXRlZ3JhMTI0LWVtYy5vCj4+Pj4gK29i ai0kKENPTkZJR19BUkNIX1RFR1JBXzEzMl9TT0MpCSs9IGNsay10ZWdyYTEyNC1lbWMubwo+Pj4g SG93IGlzIGl0IHJlbGF0ZWQgdG8gbW9kdWxhcml6YXRpb24/IEl0IGxvb2tzIGxpa2UgZGlmZmVy ZW50IGlzc3VlIGlzCj4+PiBmaXhlZCBoZXJlLgo+PiBUaGUgQ09ORklHX1RFR1JBMTI0X0VNQyBu b3cgY291bGQgYmUgJ20nLCB3aGlsZSB0aGUgY2xvY2sgY29kZSBtdXN0IGJlCj4+IGJ1aWx0LWlu LiBUaGUgVEVHUkExMjQgRU1DIGRyaXZlciBpcyB1c2VkIGJ5IFQxMjQgYW5kIFQxMzIgU29Dcy5c Cj4gTWhtbSwgIHRoZSBDT05GSUdfVEVHUkExMjRfRU1DIGRlcGVuZHMgb24gQVJDSF9URUdSQV8x MjRfU09DIHNvIG9uIHRoZQo+IGNvbmZpZyAhQVJDSF9URUdSQV8xMjRfU09DICYmIEFSQ0hfVEVH UkFfMTMyX1NPQyB0aGlzIHdhcyBub3QKPiBzZWxlY3RlZC4gTm93IGl0IHdpbGwgYmUgc2VsZWN0 ZWQuCj4gCgpUaGUgZHJpdmVyIGlzbid0IGV4cG9zZWQgb24gQVJNNjQgcHJvYmFibHkgYmVjYXVz ZSBub2JvZHkgYm90aGVyZWQgdG8gZG8KaXQgc28gZmFyLiBCdXQgaXQncyBub3QgYWxzbyB0aGUg bWVtb3J5IGRyaXZlciB3aGljaCBkZXBlbmRzIG9uCmNsay10ZWdyYTEyNC1lbWMubywgaXQncyBh bHNvIHRoZSBtYWluIGNsay90ZWdyYS9jbGstdGVncmExMjQuYyBkcml2ZXIKaXRzZWxmLCB3aGlj aCBpcyBhbHNvIHVzZWQgYnkgYm90aCBUMTI0LzEzMi4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==