From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 2/4] drm/i915: Fix WaProgramMgsrForL3BankSpecificMmioReads Date: Fri, 12 Jul 2019 06:32:07 +0100 Message-ID: References: <20190709210620.15805-3-tvrtko.ursulin@linux.intel.com> <20190711155939.18059-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 870A46E2C4 for ; Fri, 12 Jul 2019 05:32:10 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Summers, Stuart" , "Intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA3LzIwMTkgMDA6NTEsIFN1bW1lcnMsIFN0dWFydCB3cm90ZToKPiBPbiBUaHUsIDIw MTktMDctMTEgYXQgMTY6NTkgKzAxMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+PiBGcm9tOiBU dnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IAo+IFRoaXMgaXMgZ2Vu ZXJhbGx5IG11Y2ggbW9yZSByZWFkYWJsZSB0aGFuIHRoZSBwcmV2aW91cyBpbXBsZW1lbnRhdGlv biwKPiB0aGFua3MhIFNvbWUgbWlub3IgY29tbWVudHMgYmVsb3cuLi4KPiAKPj4KPj4gVHdvIGlz c3VlcyBpbiB0aGlzIGNvZGU6Cj4+Cj4+IDEuCj4+IGZscygpIHVzYWdlIGlzIGluY29ycmVjdCBj YXVzaW5nIG9mZiBieSBvbmUgaW4gc3Vic2xpY2UgbWFzayBsb29rdXAsCj4+IHdoaWNoIGluIG90 aGVyIHdvcmRzIG1lYW5zIHN1YnNsaWNlIG1hc2sgb2YgYWxsIHplcm9lcyBpcyBhbHdheXMgdXNl ZAo+PiAoc3Vic2xpY2UgbWFzayBvZiBhIHNsaWNlIHdoaWNoIGlzIG5vdCBwcmVzZW50LCBvciBl dmVuIG91dCBvZiBib3VuZHMKPj4gYXJyYXkgYWNjZXNzKSwgcmVuZGVyaW5nIHRoZSBjaGVja3Mg aW4gd2FfaW5pdF9tY3IgZWl0aGVyIGZ1dGlsZSBvcgo+PiByYW5kb20uCj4+Cj4+IDIuCj4+IENv bmRpdGlvbiBpbiBXQVJOX09OIGlzIG5vdCBjb3JyZWN0LiBJdCBpcyBkb2luZyBhIGJpdHdpc2Ug YW5kCj4+IG9wZXJhdGlvbgo+PiBiZXR3ZWVuIGEgcG9zaXRpdmUgKHByZXNlbnQgc3Vic2xpY2Vz KSBhbmQgbmVnYXRpdmUgbWFzayAoZGlzYWJsZWQgTDMKPj4gYmFua3MpLgo+Pgo+PiBUaGlzIG1l YW5zIHRoYXQgd2l0aCBjb3JyZWN0ZWQgZmxzKCkgdXNhZ2UgdGhlIGFzc2VydCB3b3VsZCBhbHdh eXMKPj4gaW5jb3JyZWN0bHkgZmFpbC4KPj4KPj4gV2UgY2FuIGZpeCB0aGlzIGJ5IGludmVydGlu ZyB0aGUgZnVzZSBiaXRzIGluIHRoZSBjaGVjay4KPj4KPj4gdjI6Cj4+ICAgKiBTaW1wbGlmeSBj aGVjayBmb3IgbG9naWMgYW5kIHJlZGFiaWxpdHkuCj4+ICAgKiBJbXByb3ZlIGNvbW1lbnRhcnkg ZXhwbGFpbmluZyB3aGF0IGlzIHJlYWxseSBoYXBwZW5pbmcgaWUuIHdoYXQKPj4gdGhlCj4+ICAg ICBhc3NlcnQgaXMgcmVhbGx5IHRyeWluZyB0byBjaGVjayBhbmQgd2h5Lgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBGaXhl czogZmU4NjRiNzZjMmFiICgiZHJtL2k5MTU6IEltcGxlbWVudAo+PiBXYVByb2dyYW1NZ3NyRm9y TDNCYW5rU3BlY2lmaWNNbWlvUmVhZHMiKQo+PiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+ICMgdjEKPj4gQ2M6IE1pY2hhxYIgV2luaWFyc2tpIDxt aWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfd29ya2Fyb3VuZHMuYyB8IDgwICsrKysrKysrKystLS0tLS0tLS0KPj4gLS0K Pj4gICAxIGZpbGUgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRpb25zKC0pCj4+ Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5k cy5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfd29ya2Fyb3VuZHMuYwo+PiBp bmRleCA5ZTA2OTI4NmQzY2UuLjgwZjExNTllNWNkYSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZ3QvaW50ZWxfd29ya2Fyb3VuZHMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4+IEBAIC03NjEsNyArNzYxLDI3IEBAIHN0 YXRpYyB2b2lkCj4+ICAgd2FfaW5pdF9tY3Ioc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUs IHN0cnVjdCBpOTE1X3dhX2xpc3QgKndhbCkKPj4gICB7Cj4+ICAgCWNvbnN0IHN0cnVjdCBzc2V1 X2Rldl9pbmZvICpzc2V1ID0gJlJVTlRJTUVfSU5GTyhpOTE1KS0+c3NldTsKPj4gLQl1MzIgbWNy X3NsaWNlX3N1YnNsaWNlX21hc2s7Cj4+ICsJdTMyIG1jcl9tYXNrLCBtY3I7Cj4+ICsKPj4gKwkv Kgo+PiArCSAqIFdhUHJvZ3JhbU1nc3JGb3JDb3JyZWN0U2xpY2VTcGVjaWZpY01taW9SZWFkczpj bmwsaWNsCj4+ICsJICogQmVmb3JlIGFueSBNTUlPIHJlYWQgaW50byBzbGljZS9zdWJzbGljZSBz cGVjaWZpYyByZWdpc3RlcnMsCj4+IE1DUgo+PiArCSAqIHBhY2tldCBjb250cm9sIHJlZ2lzdGVy IG5lZWRzIHRvIGJlIHByb2dyYW1tZWQgdG8gcG9pbnQgdG8KPj4gYW55Cj4+ICsJICogZW5hYmxl ZCBzL3NzIHBhaXIuIE90aGVyd2lzZSwgaW5jb3JyZWN0IHZhbHVlcyB3aWxsIGJlCj4+IHJldHVy bmVkLgo+PiArCSAqIFRoaXMgbWVhbnMgZWFjaCBzdWJzZXF1ZW50IE1NSU8gcmVhZCB3aWxsIGJl IGZvcndhcmRlZCB0byBhbgo+PiArCSAqIHNwZWNpZmljIHMvc3MgY29tYmluYXRpb24sIGJ1dCB0 aGlzIGlzIE9LIHNpbmNlIHRoZXNlCj4+IHJlZ2lzdGVycwo+PiArCSAqIGFyZSBjb25zaXN0ZW50 IGFjcm9zcyBzL3NzIGluIGFsbW9zdCBhbGwgY2FzZXMuIEluIHRoZSByYXJlCj4+ICsJICogb2Nj YXNpb25zLCBzdWNoIGFzIElOU1RET05FLCB3aGVyZSB0aGlzIHZhbHVlIGlzIGRlcGVuZGVudAo+ PiArCSAqIG9uIHMvc3MgY29tYm8sIHRoZSByZWFkIHNob3VsZCBiZSBkb25lIHdpdGgKPj4gcmVh ZF9zdWJzbGljZV9yZWcuCj4+ICsJICovCj4+ICsJbWNyID0gaW50ZWxfY2FsY3VsYXRlX21jcl9z X3NzX3NlbGVjdChpOTE1KTsKPj4gKwo+PiArCWlmIChJTlRFTF9HRU4oaTkxNSkgPj0gMTEpCj4+ ICsJCW1jcl9tYXNrID0gR0VOMTFfTUNSX1NMSUNFX01BU0sgfAo+PiBHRU4xMV9NQ1JfU1VCU0xJ Q0VfTUFTSzsKPj4gKwllbHNlCj4+ICsJCW1jcl9tYXNrID0gR0VOOF9NQ1JfU0xJQ0VfTUFTSyB8 Cj4+IEdFTjhfTUNSX1NVQlNMSUNFX01BU0s7Cj4+ICsKPj4gKwl3YV93cml0ZV9tYXNrZWRfb3Io d2FsLCBHRU44X01DUl9TRUxFQ1RPUiwgbWNyX21hc2ssIG1jcik7Cj4gCj4gV2FzIHRoZXJlIGEg c3BlY2lmaWMgcmVhc29uIHRvIG1vdmUgdGhpcyB1cCB0byB0aGUgdG9wPyBPciB0aGlzIGlzCgpZ ZXMsIHNvIGJlbG93IGNhbiBjaGVjayB0aGUgYWN0dWFsbHkgc2VsZWN0ZWQgTUNSIGluc3RlYWQg b2YgZGVyaXZpbmcgaXQgCmZyb20gc2xpY2Uvc3Vic2xpY2UgbWFzayBhcyBzdG9yZWQgaW4gdGhl IGRyaXZlci4KCj4gcHVyZWx5IHRvIG1vdmUgdGhpcyBmdW5jdGlvbmFsaXR5IGFsbCB0b2dldGhl ciByYXRoZXIgdGhhbiBzcHJlYWQgb3V0Cj4gdGhyb3VnaCB0aGUgZnVuY3Rpb24/IExvb2tpbmcg YXQgdGhlIGRvY3VtZW50YXRpb24sIHdlIGRvIHdhbnQgdG8KPiBzcGVjaWZpY2FsbHkgYXBwbHkg V2FQcm9ncmFtTWdzckZvckwzQmFua1NwZWNpZmljTW1pb1JlYWRzIGJlZm9yZSBhbnkKPiBvdGhl ciB3b3JrYXJvdW5kcy4gU28gbWF5YmUganVzdCBtb3ZlIHRoaXMgd2hvbGUgYmxvY2sgdG8gdGhl IGJvdHRvbSBvZgo+IHRoZSBmdW5jdGlvbiBpbnN0ZWFkPwoKSSB0aGluayBpdCB3b3JrcyBiZXR0 ZXIgaWYgTUNSIHNlbGVjdGlvbiBpcyBmaXJzdC4gR29pbmcgZm9yd2FyZCwgYW5kIApmb3Igcm9i dXN0bmVzcywgdGhpcyBwcm9iYWJseSBuZWVkcyB0byBiZSBpbXByb3ZlZCB0byBkbyBib3RoIAp3 b3JrYXJvdW5kcyBpbiBhIHNpbmdsZSBibG9jay4gQWxvbmcgdGhlIGxpbmVzIG9mIGZmcyhzc19l bmEgJiBsM19lbmEpLiAKQW5kIFdBUk5fT04gaWYgbm8gY29tbW9uIGJpdHMuIE9oIHdlbGwuLiBu b3cgSSBnb3Qgbm8gZXhjdXNlcyBub3QgdG8gZG8gCml0Li4uCgo+PiAgIAo+PiAgIAkvKgo+PiAg IAkgKiBXYVByb2dyYW1NZ3NyRm9yTDNCYW5rU3BlY2lmaWNNbWlvUmVhZHM6IGNubCxpY2wKPj4g QEAgLTc3Niw0OSArNzk2LDI5IEBAIHdhX2luaXRfbWNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1LAo+PiBzdHJ1Y3QgaTkxNV93YV9saXN0ICp3YWwpCj4+ICAgCSAqIHNvbWV0aGluZyBt b3JlIGNvbXBsZXggdGhhdCByZXF1aXJlcyBjaGVja2luZyB0aGUgcmFuZ2Ugb2YKPj4gZXZlcnkK Pj4gICAJICogTU1JTyByZWFkKS4KPj4gICAJICovCj4+IC0JaWYgKElOVEVMX0dFTihpOTE1KSA+ PSAxMCAmJgo+PiAtCSAgICBpc19wb3dlcl9vZl8yKHNzZXUtPnNsaWNlX21hc2spKSB7Cj4+ICsJ aWYgKElOVEVMX0dFTihpOTE1KSA+PSAxMCAmJiBpc19wb3dlcl9vZl8yKHNzZXUtPnNsaWNlX21h c2spKSB7Cj4+ICAgCQkvKgo+PiAtCQkgKiByZWFkIEZVU0UzIGZvciBlbmFibGVkIEwzIEJhbmsg SURzLCBpZiBMMyBCYW5rCj4+IG1hdGNoZXMKPj4gLQkJICogZW5hYmxlZCBzdWJzbGljZSwgbm8g bmVlZCB0byByZWRpcmVjdCBNQ1IgcGFja2V0Cj4+ICsJCSAqIEdFTjhfTUNSX1NFTEVDVE9SIGNv bnRhaW5zIGR1YWwtcHVycG9zZSBiaXRzIHdoaWNoCj4+IHNlbGVjdAo+PiArCQkgKiBib3RoIHRv IHdoaWNoIHN1YnNsaWNlLCBvciB0byB3aGljaCBMMyBiYW5rLCB0aGUKPj4gcmVzcGVjdGl2ZQo+ PiArCQkgKiBtbWlvIHJlYWRzIHdpbGwgZ28uCj4+ICsJCSAqIFNpbmNlIHdlIGhhdmUgc2VsZWN0 ZWQgb25lIGVuYWJsZWQgc3Vic2xpY2UgaW4KPj4gKwkJICogV2FQcm9ncmFtTWdzckZvckNvcnJl Y3RTbGljZVNwZWNpZmljTW1pb1JlYWRzLCB3ZQo+PiBub3cKPj4gKwkJICogbmVlZCB0byBjaGVj ayBpZiB0aGUgTDMgYmFuayBvZiB0aGUgZXF1YWwgImluc3RhbmNlIgo+PiBpcyBhbHNvCj4+ICsJ CSAqIGVuYWJsZWQuCj4+ICsJCSAqIElmIHRoYXQgaXMgbm90IHRoZSBjYXNlIHdlIGNvdWxkIHRy eSB0byBmaW5kIGEKPj4gbnVtYmVyIHdoaWNoCj4+ICsJCSAqIHdvcmtzIGZvciBib3RoLCBvciBn b2luZyBldmVuIGZ1cnRoZXIsIGltcGxlbWVudCBhCj4+IGR5bmFtaWMKPj4gKwkJICogc2NoZW1l IHdoZXJlIHdlIHN3aXRjaCBhdCBiZWZvcmUgZXZlcnkgYWZmZWN0ZWQgbW1pbwo+IAo+IHMvYXQg Ly8/Cj4gCj4+IHJlYWQuCj4+ICsJCSAqIEZvcnR1bmF0ZWx5IG5laXRoZXIgc2VlbXMgdG8gYmUg bmVlZGVkIGF0IHRoZSBtb21lbnQKPj4gZm9yCj4+ICsJCSAqIGN1cnJlbnQgcGFydHMgYW5kIGN1 cnJlbnQgZHJpdmVyIGJlaGF2aW91ci4KPj4gICAJCSAqLwo+PiAtCQl1MzIgc2xpY2UgPSBmbHMo c3NldS0+c2xpY2VfbWFzayk7Cj4+IC0JCXUzMiBmdXNlMyA9Cj4+IC0JCQlpbnRlbF91bmNvcmVf cmVhZCgmaTkxNS0+dW5jb3JlLAo+PiBHRU4xMF9NSVJST1JfRlVTRTMpOwo+PiAtCQl1OCBzc19t YXNrID0gc3NldS0+c3Vic2xpY2VfbWFza1tzbGljZV07Cj4+IC0KPj4gLQkJdTggZW5hYmxlZF9t YXNrID0gKHNzX21hc2sgfCBzc19tYXNrID4+Cj4+IC0JCQkJICAgR0VOMTBfTDNCQU5LX1BBSVJf Q09VTlQpICYKPj4gR0VOMTBfTDNCQU5LX01BU0s7Cj4+IC0JCXU4IGRpc2FibGVkX21hc2sgPSBm dXNlMyAmIEdFTjEwX0wzQkFOS19NQVNLOwo+PiArCQl1bnNpZ25lZCBpbnQgbWNyX3NzID0gQklU KChtY3IgPj4gMjQpICYgMHg3KTsKPiAKPiBDYW4geW91IGFkZCBtYWNyb3MgZm9yIHRoZXNlIG1h Z2ljIG51bWJlcnM/Cj4gCj4+ICsJCXVuc2lnbmVkIGludCBsM19mdXNlID0KPj4gKwkJCWludGVs X3VuY29yZV9yZWFkKCZpOTE1LT51bmNvcmUsCj4+IEdFTjEwX01JUlJPUl9GVVNFMykgJgo+PiAr CQkJR0VOMTBfTDNCQU5LX01BU0s7Cj4+ICsJCXVuc2lnbmVkIGludCBsM19lbiA9IH4obDNfZnVz ZSA8PCA0IHwgbDNfZnVzZSk7Cj4gCj4gTWFjcm8gaGVyZSBmb3IgdGhlIDQ/CgpJIGtuZXcgc29t ZW9uZSB3b3VsZCBhc2sgZm9yIGl0LiBZb3UgZ2l2ZSBmaXhlcywgcGVvcGxlIHdhbnQgcGVyZmVj dGlvbi4gCjspIFdpbGwgZG8uCgpSZWdhcmRzLAoKVHZydGtvCgo+IFRoYW5rcywKPiBTdHVhcnQK PiAKPj4gICAKPj4gLQkJLyoKPj4gLQkJICogUHJvZHVjdGlvbiBzaWxpY29uIHNob3VsZCBoYXZl IG1hdGNoZWQgTDNCYW5rIGFuZAo+PiAtCQkgKiBzdWJzbGljZSBlbmFibGVkCj4+IC0JCSAqLwo+ PiAtCQlXQVJOX09OKChlbmFibGVkX21hc2sgJiBkaXNhYmxlZF9tYXNrKSAhPQo+PiBlbmFibGVk X21hc2spOwo+PiArCQlXQVJOX09OKCEobWNyX3NzICYgbDNfZW4pKTsKPj4gICAJfQo+PiAtCj4+ IC0JaWYgKElOVEVMX0dFTihpOTE1KSA+PSAxMSkKPj4gLQkJbWNyX3NsaWNlX3N1YnNsaWNlX21h c2sgPSBHRU4xMV9NQ1JfU0xJQ0VfTUFTSyB8Cj4+IC0JCQkJCSAgR0VOMTFfTUNSX1NVQlNMSUNF X01BU0s7Cj4+IC0JZWxzZQo+PiAtCQltY3Jfc2xpY2Vfc3Vic2xpY2VfbWFzayA9IEdFTjhfTUNS X1NMSUNFX01BU0sgfAo+PiAtCQkJCQkgIEdFTjhfTUNSX1NVQlNMSUNFX01BU0s7Cj4+IC0JLyoK Pj4gLQkgKiBXYVByb2dyYW1NZ3NyRm9yQ29ycmVjdFNsaWNlU3BlY2lmaWNNbWlvUmVhZHM6Y25s LGljbAo+PiAtCSAqIEJlZm9yZSBhbnkgTU1JTyByZWFkIGludG8gc2xpY2Uvc3Vic2xpY2Ugc3Bl Y2lmaWMgcmVnaXN0ZXJzLAo+PiBNQ1IKPj4gLQkgKiBwYWNrZXQgY29udHJvbCByZWdpc3RlciBu ZWVkcyB0byBiZSBwcm9ncmFtbWVkIHRvIHBvaW50IHRvCj4+IGFueQo+PiAtCSAqIGVuYWJsZWQg cy9zcyBwYWlyLiBPdGhlcndpc2UsIGluY29ycmVjdCB2YWx1ZXMgd2lsbCBiZQo+PiByZXR1cm5l ZC4KPj4gLQkgKiBUaGlzIG1lYW5zIGVhY2ggc3Vic2VxdWVudCBNTUlPIHJlYWQgd2lsbCBiZSBm b3J3YXJkZWQgdG8gYW4KPj4gLQkgKiBzcGVjaWZpYyBzL3NzIGNvbWJpbmF0aW9uLCBidXQgdGhp cyBpcyBPSyBzaW5jZSB0aGVzZQo+PiByZWdpc3RlcnMKPj4gLQkgKiBhcmUgY29uc2lzdGVudCBh Y3Jvc3Mgcy9zcyBpbiBhbG1vc3QgYWxsIGNhc2VzLiBJbiB0aGUgcmFyZQo+PiAtCSAqIG9jY2Fz aW9ucywgc3VjaCBhcyBJTlNURE9ORSwgd2hlcmUgdGhpcyB2YWx1ZSBpcyBkZXBlbmRlbnQKPj4g LQkgKiBvbiBzL3NzIGNvbWJvLCB0aGUgcmVhZCBzaG91bGQgYmUgZG9uZSB3aXRoCj4+IHJlYWRf c3Vic2xpY2VfcmVnLgo+PiAtCSAqLwo+PiAtCXdhX3dyaXRlX21hc2tlZF9vcih3YWwsCj4+IC0J CQkgICBHRU44X01DUl9TRUxFQ1RPUiwKPj4gLQkJCSAgIG1jcl9zbGljZV9zdWJzbGljZV9tYXNr LAo+PiAtCQkJICAgaW50ZWxfY2FsY3VsYXRlX21jcl9zX3NzX3NlbGVjdChpOTE1KSk7Cj4+ICAg fQo+PiAgIAo+PiAgIHN0YXRpYyB2b2lkCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==