From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6F4C433F5 for ; Sat, 21 May 2022 16:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239132AbiEUQhn (ORCPT ); Sat, 21 May 2022 12:37:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245666AbiEUQhl (ORCPT ); Sat, 21 May 2022 12:37:41 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA0426161A for ; Sat, 21 May 2022 09:37:39 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id v9so3386162lja.12 for ; Sat, 21 May 2022 09:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=xrngHl+k++nVK8AbvZFVt0lPwWgRKfDuqq3cdMG2V38=; b=f1PXoIqYpQV8rPyrcOXuJMO+8R6A7YB7wOl2JgT1Hf6DAW3jEWx8DiwYevJN9foxuT xqiD1JUsuSwtjJZzckPQ3HIyQb9qTI5GEoRhiia9vtQ1x5RRZdszPcxAfZwYVEI5c33b VjnW9ysQLT9rOXQIiehcO96AGCYWBcl4Amg6kyIghtr3Q0+4ub1xxGeYiUIjoUksEB7o X/6VCEapIUnJBuwQ/DxpPiakNFhwFkl9PWhuGlK64PbQVDgPjgD5RGN8Q/2bPlNgcAPY 6q7Eymqt7gNxIWnXR/Qc5Ho3xK7NewmCD2fraMyhTaUzx2AQl+FnXT2wNDTbKpRYFgAj gQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=xrngHl+k++nVK8AbvZFVt0lPwWgRKfDuqq3cdMG2V38=; b=PN/i/XQFdX2F8C7GruCT7ieZZCY7a6POomids+HhqP0zqTdyhpJ/HRn7sXnOP3aOGW 7NuqGApqAkeW1RRty+zO7yuQ2tw+THKE/FQhJi52AxAlUsM/BNcjWmRR020igaC0nV4W X2BxU4Zf7gMqrSK30PQQDKnp+EaSgNFnHI+wCWV/SgyIUSaxL4NUK6jq+z8e7+Oy5XkW i7GrjPksj9H3Q56tKvQWGZCXtwshk1wB0oyoMWL3SNwCsZP0yEqoK3I5vDxvr4JOHIEi gAkz+kMwdyQxMxd49ew8CuzKZZ8GAjgs3ycCpibx3L/LR1wQz8/9MP5Yt9nmpjJIfhXm joZg== X-Gm-Message-State: AOAM531uxuTrodgZBbU4nACe7JSFbhHhIJrD4pdRy5zuiqAmNkxjXEkm FDiu7QhHz/QWtKgKtbOx2gQk9g== X-Google-Smtp-Source: ABdhPJyK+2dAF2mDmvzbdrtAY2ubkJvsKXq+zufNECKywzZuKACWqwQFPtM6ejdRbkkXoekoqH7oSw== X-Received: by 2002:a2e:a493:0:b0:253:d23f:16d9 with SMTP id h19-20020a2ea493000000b00253d23f16d9mr8212181lji.446.1653151058102; Sat, 21 May 2022 09:37:38 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.185]) by smtp.gmail.com with ESMTPSA id f5-20020ac24e45000000b0047255d21141sm1116573lfr.112.2022.05.21.09.37.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 09:37:37 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 19:37:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v2 1/9] memcg: enable accounting for struct cgroup To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Creating each new cgroup allocates 4Kb for struct cgroup. This is the largest memory allocation in this scenario and is epecially important for small VMs with 1-2 CPUs. Common part of the cgroup creation: Allocs Alloc $1*$2 Sum Allocation number size -------------------------------------------- 16 ~ 352 5632 5632 KERNFS 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) 1 192 192 10504 (__d_alloc+0x29) 2 72 144 10648 (avc_alloc_node+0x27) 2 64 128 10776 (percpu_ref_init+0x6a) 1 64 64 10840 (memcg_list_lru_alloc+0x21a) percpu: 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f 2 12 24 312 call_site=percpu_ref_init+0x23 1 6 6 318 call_site=__percpu_counter_init+0x22 '+' -- to be accounted, '~' -- partially accounted Accounting of this memory helps to avoid misuse inside memcg-limited containers. Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index adb820e98f24..7595127c5b3a 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5353,7 +5353,7 @@ static struct cgroup *cgroup_create(struct cgroup *parent, const char *name, /* allocate the cgroup and its ID, 0 is reserved for the root */ cgrp = kzalloc(struct_size(cgrp, ancestor_ids, (level + 1)), - GFP_KERNEL); + GFP_KERNEL_ACCOUNT); if (!cgrp) return ERR_PTR(-ENOMEM); -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v2 1/9] memcg: enable accounting for struct cgroup Date: Sat, 21 May 2022 19:37:36 +0300 Message-ID: References: Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=xrngHl+k++nVK8AbvZFVt0lPwWgRKfDuqq3cdMG2V38=; b=f1PXoIqYpQV8rPyrcOXuJMO+8R6A7YB7wOl2JgT1Hf6DAW3jEWx8DiwYevJN9foxuT xqiD1JUsuSwtjJZzckPQ3HIyQb9qTI5GEoRhiia9vtQ1x5RRZdszPcxAfZwYVEI5c33b VjnW9ysQLT9rOXQIiehcO96AGCYWBcl4Amg6kyIghtr3Q0+4ub1xxGeYiUIjoUksEB7o X/6VCEapIUnJBuwQ/DxpPiakNFhwFkl9PWhuGlK64PbQVDgPjgD5RGN8Q/2bPlNgcAPY 6q7Eymqt7gNxIWnXR/Qc5Ho3xK7NewmCD2fraMyhTaUzx2AQl+FnXT2wNDTbKpRYFgAj gQMA== Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="macroman" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Q3JlYXRpbmcgZWFjaCBuZXcgY2dyb3VwIGFsbG9jYXRlcyA0S2IgZm9yIHN0cnVjdCBjZ3JvdXAu IFRoaXMgaXMgdGhlCmxhcmdlc3QgbWVtb3J5IGFsbG9jYXRpb24gaW4gdGhpcyBzY2VuYXJpbyBh bmQgaXMgZXBlY2lhbGx5IGltcG9ydGFudApmb3Igc21hbGwgVk1zIHdpdGggMS0yIENQVXMuCgpD b21tb24gcGFydCBvZiB0aGUgY2dyb3VwIGNyZWF0aW9uOgpBbGxvY3MgIEFsbG9jICAgJDEqJDIg ICBTdW0gICAgIEFsbG9jYXRpb24KbnVtYmVyICBzaXplCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCjE2ICB+ICAgMzUyICAgICA1NjMyICAgIDU2MzIgICAgS0VS TkZTCjEgICArICAgNDA5NiAgICA0MDk2ICAgIDk3MjggICAgKGNncm91cF9ta2RpcisweGU0KQox ICAgICAgIDU4NCAgICAgNTg0ICAgICAxMDMxMiAgIChyYWRpeF90cmVlX25vZGVfYWxsb2MuY29u c3Rwcm9wLjArMHg4OSkKMSAgICAgICAxOTIgICAgIDE5MiAgICAgMTA1MDQgICAoX19kX2FsbG9j KzB4MjkpCjIgICAgICAgNzIgICAgICAxNDQgICAgIDEwNjQ4ICAgKGF2Y19hbGxvY19ub2RlKzB4 MjcpCjIgICAgICAgNjQgICAgICAxMjggICAgIDEwNzc2ICAgKHBlcmNwdV9yZWZfaW5pdCsweDZh KQoxICAgICAgIDY0ICAgICAgNjQgICAgICAxMDg0MCAgIChtZW1jZ19saXN0X2xydV9hbGxvYysw eDIxYSkKcGVyY3B1OgoxICAgKyAgIDE5MiAgICAgMTkyICAgICAxOTIgICAgIGNhbGxfc2l0ZT1w c2lfY2dyb3VwX2FsbG9jKzB4MWUKMSAgICsgICA5NiAgICAgIDk2ICAgICAgMjg4ICAgICBjYWxs X3NpdGU9Y2dyb3VwX3JzdGF0X2luaXQrMHg1ZgoyICAgICAgIDEyICAgICAgMjQgICAgICAzMTIg ICAgIGNhbGxfc2l0ZT1wZXJjcHVfcmVmX2luaXQrMHgyMwoxICAgICAgIDYgICAgICAgNiAgICAg ICAzMTggICAgIGNhbGxfc2l0ZT1fX3BlcmNwdV9jb3VudGVyX2luaXQrMHgyMgoKICcrJyAtLSB0 byBiZSBhY2NvdW50ZWQsCiAnficgLS0gcGFydGlhbGx5IGFjY291bnRlZAoKQWNjb3VudGluZyBv ZiB0aGlzIG1lbW9yeSBoZWxwcyB0byBhdm9pZCBtaXN1c2UgaW5zaWRlIG1lbWNnLWxpbWl0ZWQK Y29udGFpbmVycy4KClNpZ25lZC1vZmYtYnk6IFZhc2lseSBBdmVyaW4gPHZ2cy1HRUZBUXpaWDdy OGRubSt5Uk9mRTBBQHB1YmxpYy5nbWFuZS5vcmc+ClJldmlld2VkLWJ5OiBSb21hbiBHdXNoY2hp biA8cm9tYW4uZ3VzaGNoaW4tZnhVVlhmdElGRG55RzF6RU9iWHRmQUBwdWJsaWMuZ21hbmUub3Jn PgpSZXZpZXdlZC1ieTogTWljaGFsIEtvdXRuw70gPG1rb3V0bnktSUJpOVJHL2I2N2tAcHVibGlj LmdtYW5lLm9yZz4KQWNrZWQtYnk6IFNoYWtlZWwgQnV0dCA8c2hha2VlbGItaHBJcXNENEFLbGZR VDBkWlIrQWxmQUBwdWJsaWMuZ21hbmUub3JnPgotLS0KIGtlcm5lbC9jZ3JvdXAvY2dyb3VwLmMg fCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9rZXJuZWwvY2dyb3VwL2Nncm91cC5jIGIva2VybmVsL2Nncm91cC9jZ3JvdXAu YwppbmRleCBhZGI4MjBlOThmMjQuLjc1OTUxMjdjNWIzYSAxMDA2NDQKLS0tIGEva2VybmVsL2Nn cm91cC9jZ3JvdXAuYworKysgYi9rZXJuZWwvY2dyb3VwL2Nncm91cC5jCkBAIC01MzUzLDcgKzUz NTMsNyBAQCBzdGF0aWMgc3RydWN0IGNncm91cCAqY2dyb3VwX2NyZWF0ZShzdHJ1Y3QgY2dyb3Vw ICpwYXJlbnQsIGNvbnN0IGNoYXIgKm5hbWUsCiAKIAkvKiBhbGxvY2F0ZSB0aGUgY2dyb3VwIGFu ZCBpdHMgSUQsIDAgaXMgcmVzZXJ2ZWQgZm9yIHRoZSByb290ICovCiAJY2dycCA9IGt6YWxsb2Mo c3RydWN0X3NpemUoY2dycCwgYW5jZXN0b3JfaWRzLCAobGV2ZWwgKyAxKSksCi0JCSAgICAgICBH RlBfS0VSTkVMKTsKKwkJICAgICAgIEdGUF9LRVJORUxfQUNDT1VOVCk7CiAJaWYgKCFjZ3JwKQog CQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKIAotLSAKMi4zNi4xCgo=