From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD51C433F5 for ; Fri, 11 Feb 2022 07:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347858AbiBKHzf (ORCPT ); Fri, 11 Feb 2022 02:55:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347861AbiBKHze (ORCPT ); Fri, 11 Feb 2022 02:55:34 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1576ABFD for ; Thu, 10 Feb 2022 23:55:31 -0800 (PST) Received: from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DB4493; Fri, 11 Feb 2022 08:55:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644566129; bh=XjIGncWKVA4ecTJoSf+DOqoJj+MwKLrfumxgmT3hqJM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qrsMvUo1dazaGVw9eox4KDnUdVNuknSGThlhCo19azg5bzfrJzZFTR9oYK/4Zsdx7 mXsGK3U3Dk/B7UdTWMGfuFi9a0euYASDByrkqSUje47SDmtKVdxdORrbaseANs7/my /DZIdFIm3J86dyQwqRk9eYAYUBKaMXAqC9ybuc9o= Message-ID: Date: Fri, 11 Feb 2022 09:55:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Content-Language: en-US To: Jacopo Mondi Cc: Steve Longerbeam , laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi, hverkuil-cisco@xs4all.nl, mirela.rabulea@nxp.com, xavier.roumegue@oss.nxp.com, hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, aford173@gmail.com, festevam@gmail.com, Eugen.Hristev@microchip.com, jbrunet@baylibre.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org References: <20220210110458.152494-1-jacopo@jmondi.org> <5db6f493-ca45-311a-1f44-9138e01722a1@ideasonboard.com> <20220210171123.oi54lq47eyjucwpk@uno.localdomain> From: Tomi Valkeinen In-Reply-To: <20220210171123.oi54lq47eyjucwpk@uno.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 10/02/2022 19:11, Jacopo Mondi wrote: > Hi Tomi > > On Thu, Feb 10, 2022 at 03:00:21PM +0200, Tomi Valkeinen wrote: >> On 10/02/2022 13:04, Jacopo Mondi wrote: >>> v1: >>> https://patchwork.linuxtv.org/project/linux-media/list/?series=7249 >> >> You could rather point to lore.kernel.org, so that the intro letter and the >> discussions are also visible. > > Sure, here you go! > https://lore.kernel.org/linux-media/20220131143245.128089-1-jacopo@jmondi.org/ > >> >>> A branch for testing based on the most recent media-master is available at >>> https://git.sr.ht/~jmondi_/linux #jmondi/media-master/ov5640-v2 >>> >>> If anyone with a DVP setup could verify I have not broken their use case >>> I would very much appreciate that :) >>> >>> v1 -> v2: >>> - rework the modes definition to process the full pixel array >>> - rework get_selection to report the correct BOUND and DEFAULT targets >>> - implement init_cfg >>> - minor style changes as suggested by Laurent >>> - test with 1 data lane >> >> Very nice! I tested this on TI's DRA76 EVM (CSI-2). UYVY and RGB565, with >> the following resolutions: 160 120, 176 144, 320 240, 640 480, 720 480, 720 >> 576, 1024 768, 1280 720, 1920 1080. > > Great! A 2 data lanes setup I assume ? Have you been able to test the > framerate as well ? Yes, 2 data lanes. I can see that with 640x480 and 1024x768 I get ~30fps. Why does ov5640_enum_frame_interval() return an error if ov5640 is a csi sensor? Tomi