All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Roman Kagan <rvkagan@yandex-team.ru>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org, fam@euphon.net,
	stefanha@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	eblake@redhat.com
Subject: Re: [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection
Date: Thu, 8 Apr 2021 20:07:14 +0300	[thread overview]
Message-ID: <a7801f70-5a53-19ab-53c1-98cdad73e2e8@virtuozzo.com> (raw)
In-Reply-To: <YG83t4s9kYLFRqUC@rvkaganb.lan>

08.04.2021 20:04, Roman Kagan wrote:
> On Thu, Apr 08, 2021 at 05:08:27PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> We now have bs-independent connection API, which consists of four
>> functions:
>>
>>    nbd_client_connection_new()
>>    nbd_client_connection_unref()
>>    nbd_co_establish_connection()
>>    nbd_co_establish_connection_cancel()
>>
>> Move them to a separate file together with NBDClientConnection
>> structure which becomes private to the new API.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>
>> Hmm. I keep only Virtuozzo's copyright in a new file, as actually I've
>> developed nbd-reconnection code. Still probably safer to save all
>> copyrights. Let me now if you think so and I'll add them.
> 
> Not my call.
> 
>>   include/block/nbd.h     |  11 +++
>>   block/nbd.c             | 167 ----------------------------------
>>   nbd/client-connection.c | 192 ++++++++++++++++++++++++++++++++++++++++
>>   nbd/meson.build         |   1 +
>>   4 files changed, 204 insertions(+), 167 deletions(-)
>>   create mode 100644 nbd/client-connection.c
> 
> Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>
> 

Thanks a lot for reviewing!

-- 
Best regards,
Vladimir


  reply	other threads:[~2021-04-08 17:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 14:08 [PATCH v2 00/10] block/nbd: move connection code to separate file Vladimir Sementsov-Ogievskiy
2021-04-08 14:08 ` [PATCH v2 01/10] block/nbd: introduce NBDConnectThread reference counter Vladimir Sementsov-Ogievskiy
2021-04-08 15:31   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 02/10] block/nbd: BDRVNBDState: drop unused connect_err and connect_status Vladimir Sementsov-Ogievskiy
2021-04-08 15:33   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 03/10] util/async: aio_co_enter(): do aio_co_schedule in general case Vladimir Sementsov-Ogievskiy
2021-04-08 15:54   ` Roman Kagan
2021-04-09 14:38     ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 04/10] block/nbd: simplify waking of nbd_co_establish_connection() Vladimir Sementsov-Ogievskiy
2021-04-08 16:10   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 05/10] block/nbd: drop thr->state Vladimir Sementsov-Ogievskiy
2021-04-08 16:36   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 06/10] block/nbd: bs-independent interface for nbd_co_establish_connection() Vladimir Sementsov-Ogievskiy
2021-04-08 16:45   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 07/10] block/nbd: make nbd_co_establish_connection_cancel() bs-independent Vladimir Sementsov-Ogievskiy
2021-04-08 16:50   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection Vladimir Sementsov-Ogievskiy
2021-04-08 16:54   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 09/10] block/nbd: introduce nbd_client_connection_new() Vladimir Sementsov-Ogievskiy
2021-04-08 16:57   ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection Vladimir Sementsov-Ogievskiy
2021-04-08 17:04   ` Roman Kagan
2021-04-08 17:07     ` Vladimir Sementsov-Ogievskiy [this message]
2021-06-02 21:32   ` Eric Blake
2021-04-08 17:16 ` [PATCH v2 00/10] block/nbd: move connection code to separate file Roman Kagan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7801f70-5a53-19ab-53c1-98cdad73e2e8@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rvkagan@yandex-team.ru \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.