From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>
Subject: [PATCH 6/6] usb: dwc3: host: Set quirks base on version
Date: Thu, 08 Apr 2021 18:42:32 -0700 [thread overview]
Message-ID: <a792b1ea6b7083d400b3a6b38dcca70588fc5587.1617929509.git.Thinh.Nguyen@synopsys.com> (raw)
In-Reply-To: <cover.1617929509.git.Thinh.Nguyen@synopsys.com>
We can check for host quirks at runtime base on the controller IP and
version check. Set the following quirks for the DWC_usb31 IP host mode
before creating a platform device for the xHCI driver:
* XHCI_ISOC_BLOCKED_DISCONNECT
* XHCI_LIMIT_FS_BI_INTR_EP
* XHCI_LOST_DISCONNECT_QUIRK
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
drivers/usb/dwc3/host.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f29a264635aa..a486d7fbb163 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -9,6 +9,7 @@
#include <linux/acpi.h>
#include <linux/platform_device.h>
+#include <linux/usb/xhci-quirks.h>
#include "core.h"
@@ -42,6 +43,17 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
return irq;
}
+static void dwc3_host_init_quirks(struct dwc3 *dwc, struct xhci_plat_priv *priv)
+{
+ memset(priv, 0, sizeof(*priv));
+
+ if (DWC3_VER_IS_WITHIN(DWC31, ANY, 190A)) {
+ priv->quirks |= XHCI_ISOC_BLOCKED_DISCONNECT;
+ priv->quirks |= XHCI_LIMIT_FS_BI_INTR_EP;
+ priv->quirks |= XHCI_LOST_DISCONNECT_QUIRK;
+ }
+}
+
int dwc3_host_init(struct dwc3 *dwc)
{
struct property_entry props[4];
@@ -49,6 +61,7 @@ int dwc3_host_init(struct dwc3 *dwc)
int ret, irq;
struct resource *res;
struct platform_device *dwc3_pdev = to_platform_device(dwc->dev);
+ struct xhci_plat_priv dwc3_priv;
int prop_idx = 0;
irq = dwc3_host_get_irq(dwc);
@@ -87,6 +100,14 @@ int dwc3_host_init(struct dwc3 *dwc)
goto err;
}
+ dwc3_host_init_quirks(dwc, &dwc3_priv);
+
+ ret = platform_device_add_data(xhci, &dwc3_priv, sizeof(dwc3_priv));
+ if (ret) {
+ dev_err(dwc->dev, "couldn't add platform data to xHCI device\n");
+ goto err;
+ }
+
memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
if (dwc->usb3_lpm_capable)
--
2.28.0
next prev parent reply other threads:[~2021-04-09 1:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 1:41 [PATCH 0/6] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen
2021-04-09 1:41 ` [PATCH 1/6] usb: xhci: Move quirks definitions to common usb header Thinh Nguyen
2021-04-09 6:50 ` Greg Kroah-Hartman
2021-04-09 8:01 ` Thinh Nguyen
2021-04-09 16:26 ` kernel test robot
2021-04-09 16:26 ` kernel test robot
2021-04-09 19:54 ` kernel test robot
2021-04-09 19:54 ` kernel test robot
2021-04-09 1:42 ` [PATCH 2/6] usb: xhci: Check for blocked disconnection Thinh Nguyen
2021-04-09 1:42 ` [PATCH 3/6] usb: xhci: Workaround undercalculated BW for fullspeed BI Thinh Nguyen
2021-04-09 1:42 ` [PATCH 4/6] usb: xhci: Rename Compliance mode timer quirk Thinh Nguyen
2021-04-09 1:42 ` [PATCH 5/6] usb: xhci: Workaround lost disconnect port status Thinh Nguyen
2021-04-09 1:42 ` Thinh Nguyen [this message]
2021-04-09 6:53 ` [PATCH 6/6] usb: dwc3: host: Set quirks base on version Greg Kroah-Hartman
2021-04-09 8:01 ` Thinh Nguyen
2021-04-09 13:22 ` Greg Kroah-Hartman
2021-04-10 0:44 ` Thinh Nguyen
2021-04-10 0:46 ` [PATCH v2 0/7] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen
2021-04-10 0:46 ` [PATCH v2 1/7] usb: xhci: Move quirks definitions to common usb header Thinh Nguyen
2021-04-10 0:46 ` [PATCH v2 2/7] usb: xhci: Move xhci-plat header " Thinh Nguyen
2021-04-10 0:47 ` [PATCH v2 3/7] usb: xhci: Check for blocked disconnection Thinh Nguyen
2021-04-27 13:08 ` Mathias Nyman
2021-04-27 22:30 ` Thinh Nguyen
2021-04-28 13:32 ` Mathias Nyman
2021-04-29 0:54 ` Thinh Nguyen
2021-04-10 0:47 ` [PATCH v2 4/7] usb: xhci: Workaround undercalculated BW for fullspeed BI Thinh Nguyen
2021-04-28 11:57 ` Mathias Nyman
2021-04-10 0:47 ` [PATCH v2 5/7] usb: xhci: Rename Compliance mode timer quirk Thinh Nguyen
2021-04-10 0:47 ` [PATCH v2 6/7] usb: xhci: Workaround lost disconnect port status Thinh Nguyen
2021-04-28 13:48 ` Mathias Nyman
2021-04-29 1:00 ` Thinh Nguyen
2021-04-10 0:47 ` [PATCH v2 7/7] usb: dwc3: host: Set quirks base on version Thinh Nguyen
2021-04-19 21:07 ` [PATCH v2 0/7] usb: Set quirks for xhci/dwc3 host mode Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a792b1ea6b7083d400b3a6b38dcca70588fc5587.1617929509.git.Thinh.Nguyen@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.