From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86125C4338F for ; Thu, 19 Aug 2021 13:05:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D50B610FA for ; Thu, 19 Aug 2021 13:05:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D50B610FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.168759.308114 (Exim 4.92) (envelope-from ) id 1mGhjH-0007C7-4h; Thu, 19 Aug 2021 13:05:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 168759.308114; Thu, 19 Aug 2021 13:05:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGhjH-0007C0-1J; Thu, 19 Aug 2021 13:05:07 +0000 Received: by outflank-mailman (input) for mailman id 168759; Thu, 19 Aug 2021 13:05:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGhjE-0007Bu-R9 for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 13:05:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGhjD-0007y2-S8; Thu, 19 Aug 2021 13:05:03 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mGhjD-0006Wk-ML; Thu, 19 Aug 2021 13:05:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=T+y76dBxf7zSkrLvn7F3PzcOwV9xoryzjShDkuTFOdI=; b=bjZEsGoy0uU5TUm2nhZ71ymaQF fGfPpW57YZ+u12rTLUYO/GBOi6AXgpPyuvSTc6tGJFAQ/VmX243QSkCKFJqCw3v17WGCm3sXaNwGf ASv5ruqpPukgX2Uynp7tBEO5DaYCl7uO/kLADNMjvMg30C9ad/O81BHc7UWCG+dsymPc=; Subject: Re: [XEN RFC PATCH 02/40] xen/arm: Print a 64-bit number in hex from early uart To: Wei Chen , xen-devel@lists.xenproject.org, sstabellini@kernel.org, jbeulich@suse.com Cc: Bertrand.Marquis@arm.com References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-3-wei.chen@arm.com> From: Julien Grall Message-ID: Date: Thu, 19 Aug 2021 14:05:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210811102423.28908-3-wei.chen@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: > Current putn function that is using for early print > only can print low 32-bit of AArch64 register. This > will lose some important messages while debugging > with early console. For example: > (XEN) Bringing up CPU5 > - CPU 0000000100000100 booting - > Will be truncated to > (XEN) Bringing up CPU5 > - CPU 00000100 booting - > > In this patch, we increased the print loops and shift > bits to make putn print 64-bit number. > > Signed-off-by: Wei Chen Acked-by: Julien Grall > --- > xen/arch/arm/arm64/head.S | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index aa1f88c764..b32639d7d6 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -862,17 +862,18 @@ puts: > ret > ENDPROC(puts) > > -/* Print a 32-bit number in hex. Specific to the PL011 UART. > +/* Print a 64-bit number in hex. Specific to the PL011 UART. As you modify the line, can you take the opportunity to write: /* * Print a 64-bit... And also drop the second sentence as it the code has not been PL011 specific for quite a while now. > * x0: Number to print. > * x23: Early UART base address > * Clobbers x0-x3 */ > +#define PRINT_MASK 0xf000000000000000 > putn: > adr x1, hex > - mov x3, #8 > + mov x3, #16 > 1: > early_uart_ready x23, 2 > - and x2, x0, #0xf0000000 /* Mask off the top nybble */ > - lsr x2, x2, #28 > + and x2, x0, #PRINT_MASK /* Mask off the top nybble */ > + lsr x2, x2, #60 > ldrb w2, [x1, x2] /* Convert to a char */ > early_uart_transmit x23, w2 > lsl x0, x0, #4 /* Roll it through one nybble at a time */ > Cheers, -- Julien Grall