All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Jianyue (NSB - CN/Hangzhou)" <jianyue.wu@nokia-sbell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550
Date: Wed, 16 Jun 2021 12:59:36 +0000	[thread overview]
Message-ID: <a7a5f1a613cb48e08e289662f8dafb6a@intel.com> (raw)
In-Reply-To: <8604acf0977f4e49a9515113d451e0a1@nokia-sbell.com>

Comments inline.

From: Wu, Jianyue (NSB - CN/Hangzhou) <jianyue.wu@nokia-sbell.com>
Sent: Wednesday, June 16, 2021 1:04 PM
To: Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550

Hi, Qi,

OK, thanks indeed for the explanation, appreciated😊
BTW, I see patch is Superseded, does that mean it is not needed, or need update?

[Qi:] because I assume you are required to submit a new version base on previous comment anyway.

> 1.  why only enable this for x550, is it because you only need this or you already know other ixgbe device has the limitation?
I’m using this x550 device, but not sure if other device would have such limitation yet. But I’m sure that X550 can support it, because I had checked the doc, and also tested it in the ENV.

[Qi:]  I hope we can enable this for all the ixgbe family if we know there is no limitation, I think we need to check with ixgbe maintainer.

  >2 . As the patch expose the new feature of the driver, could you provide more test information?
I tested to create new Tx Queue after rte_eth_dev_start() done and use it in my code. But haven’t tested in DPDK code yet, like testpmd.
3.  You need to update document in your patch, these include
    1) doc/guides/nics/features/ixgbe.ini
    2) if only x550 support runtime queue configure, you’d better to explain this in doc/guides/nics/ixgbe.rst.
OK, thanks, will check the documents. BTW, I see that at least there is 82599, X540, X520 is 10GE, from http://doc.dpdk.org/guides/nics/ixgbe.html, I can check their documents, but better to have some further tests, is there any ENV I can use to test it? Thanks.

[Qi:], I don’t think we have any public environment for testing, anyways thanks for your contribution.

Best Regards,
Dave(Jianyue)

From: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
Sent: 2021年6月16日 8:31
To: Wu, Jianyue (NSB - CN/Hangzhou) <jianyue.wu@nokia-sbell.com<mailto:jianyue.wu@nokia-sbell.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550

Hi Jianyue:

 I think you can ignore those warning.

 Below are couple questions for this patch:
 1.  why only enable this for x550, is it because you only need this or you already know other ixgbe device has the limitation?
2 . As the patch expose the new feature of the driver, could you provide more test information?
3.  You need to update document in your patch, these include
    1) doc/guides/nics/features/ixgbe.ini
    2) if only x550 support runtime queue configure, you’d better to explain this in doc/guides/nics/ixgbe.rst.

Thanks
Qi

From: Wu, Jianyue (NSB - CN/Hangzhou) <jianyue.wu@nokia-sbell.com<mailto:jianyue.wu@nokia-sbell.com>>
Sent: Wednesday, May 26, 2021 1:30 PM
To: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550


Hello, Zhang, qi,



May I ask a question?

I see this patch is delegate to you.

It seems some cases are failed in this link, but are i40e cases, can we ignore them? Because seems not related with this patch. Thanks😊

http://patches.dpdk.org/project/dpdk/patch/20210524115329.40525-1-jianyue.wu@nokia-sbell.com/

https://lab.dpdk.org/results/dashboard/patchsets/17199/



Thanks,

Best regards,

Dave

  reply	other threads:[~2021-06-16 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  5:29 [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550 Wu, Jianyue (NSB - CN/Hangzhou)
2021-06-16  0:31 ` Zhang, Qi Z
2021-06-16  5:03   ` Wu, Jianyue (NSB - CN/Hangzhou)
2021-06-16 12:59     ` Zhang, Qi Z [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-24 11:53 Wu Jianyue
     [not found] <20210522071304.981-1-jianyue.wu@nokia-sbell.com>
2021-05-22  7:17 ` Wu, Jianyue (NSB - CN/Hangzhou)
     [not found] <20210521004041.159-1-jianyue.wu@nokia-sbell.com>
2021-05-21  0:53 ` Wu, Jianyue (NSB - CN/Hangzhou)
2021-05-21  0:59   ` Wu, Jianyue (NSB - CN/Hangzhou)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7a5f1a613cb48e08e289662f8dafb6a@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianyue.wu@nokia-sbell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.