All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>
Cc: "N, Harshapriya" <harshapriya.n@intel.com>,
	"M R, Sathya Prakash" <sathya.prakash.m.r@intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"biernacki@google.com" <biernacki@google.com>,
	"Bossart, Pierre-louis" <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH 1/2] ASoC: Intel: kbl: Add MST route change to kbl machine drivers
Date: Thu, 25 Mar 2021 17:05:15 -0500	[thread overview]
Message-ID: <a7ae7c3c-b80d-2a31-8482-b5b8d6da5dfa@linux.intel.com> (raw)
In-Reply-To: <SN6PR11MB28770F2E69C6D27984F3674FD6629@SN6PR11MB2877.namprd11.prod.outlook.com>




>>>
>>> -	{ "HDMI", NULL, "hif5 Output" },
>>> -	{ "DP", NULL, "hif6 Output" },
>>> -
>>
>> ... this doesn't:
>>
>> other machine drivers use this:
>>
>> 	{"HDMI1", NULL, "hif5-0 Output"},
>> 	{"HDMI2", NULL, "hif6-0 Output"},
>> 	{"HDMI2", NULL, "hif7-0 Output"},
>>
> Hello Pierre,
> Thanks for reviewing the patch.
> I looked through the change you suggested in bxt_da7219_max98357a.c machine, but I noticed  hif6-0 Output and hif7-0 Output are having same port HDMI2, This looks not correct.

D'oh! You're right, this makes no sense to me either. I see 4 
occurrences in the code.

bxt_da7219_max98357a.c:	{"HDMI1", NULL, "hif5-0 Output"},
bxt_da7219_max98357a.c:	{"HDMI2", NULL, "hif6-0 Output"},
bxt_da7219_max98357a.c:	{"HDMI2", NULL, "hif7-0 Output"},

bxt_rt298.c:	{"HDMI1", NULL, "hif5-0 Output"},
bxt_rt298.c:	{"HDMI2", NULL, "hif6-0 Output"},
bxt_rt298.c:	{"HDMI2", NULL, "hif7-0 Output"},

bxt_rt298.c:	{"HDMI1", NULL, "hif5-0 Output"},
bxt_rt298.c:	{"HDMI2", NULL, "hif6-0 Output"},
bxt_rt298.c:	{"HDMI2", NULL, "hif7-0 Output"},

glk_rt5682_max98357a.c:	{ "HDMI1", NULL, "hif5-0 Output" },
glk_rt5682_max98357a.c:	{ "HDMI2", NULL, "hif6-0 Output" },
glk_rt5682_max98357a.c:	{ "HDMI2", NULL, "hif7-0 Output" },

Harsha and team, the HDMI2 duplicates seem like recurring copy/paste 
mistakes, can you double check what the intent was? If this is indeed 
unintentional, we probably need a patch per file with a Fixes tag to 
have this applied to the stable kernel.

Thanks!

  reply	other threads:[~2021-03-25 22:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 17:51 [PATCH 0/2] kbl_da7219_max9357a machine changes for wov and MST vamshi.krishna.gopal
2021-03-24 17:51 ` [PATCH 1/2] ASoC: Intel: kbl: Add MST route change to kbl machine drivers vamshi.krishna.gopal
2021-03-24 18:34   ` Pierre-Louis Bossart
2021-03-25 18:07     ` Gopal, Vamshi Krishna
2021-03-25 22:05       ` Pierre-Louis Bossart [this message]
2021-03-31 18:49         ` Gopal, Vamshi Krishna
2021-03-24 17:52 ` [PATCH 2/2] ASoc: Intel: board: add BE DAI link for WoV vamshi.krishna.gopal
2021-03-24 18:43   ` Pierre-Louis Bossart
2021-03-24 23:39   ` kernel test robot
2021-03-24 23:39     ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2017-08-25 22:34 [PATCH 0/2] ASoC: Intel: kbl: Machine driver modifications to support MST Audio Naveen M
2017-08-25 22:34 ` [PATCH 1/2] ASoC: Intel: kbl: Add MST route change to kbl machine drivers Naveen M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7ae7c3c-b80d-2a31-8482-b5b8d6da5dfa@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=biernacki@google.com \
    --cc=broonie@kernel.org \
    --cc=harshapriya.n@intel.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=sathya.prakash.m.r@intel.com \
    --cc=vamshi.krishna.gopal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.