From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Kershner, David A" Subject: RE: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed Date: Fri, 19 Jun 2015 15:02:32 +0000 Message-ID: References: <1434141968-4133-1-git-send-email-david.kershner@unisys.com> <1434141968-4133-3-git-send-email-david.kershner@unisys.com> <20150619125513.GP28762@mwanda> In-Reply-To: <20150619125513.GP28762@mwanda> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-ID: To: Dan Carpenter Cc: "gregkh@linuxfoundation.org" , "Jes.Sorensen@redhat.com" , *S-Par-Maintainer , "driverdev-devel@linuxdriverproject.org" , "Romer, Benjamin M" > -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > Sent: Friday, June 19, 2015 8:55 AM > To: Kershner, David A > Cc: gregkh@linuxfoundation.org; Jes.Sorensen@redhat.com; *S-Par- > Maintainer; driverdev-devel@linuxdriverproject.org; Romer, Benjamin M > Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to > __packed >=20 > On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: > > It was noticed that iochannel.h was still using pragmas to > > pack the datastructures, should be using __packed instead. > > > > Signed-off-by: David Kershner >=20 > Could you take some time and figure out which structs should actually > be packed and which should not? For example, in net_pkt_rcv the > pointers are not aligned so it will cause a slow down on x86 and crash > on other arches (which we don't care about). >=20 > regards, > dan carpenter Dan,=20 Thanks for the find. Unfortunately, all the structs defined in iochannel.h need to be packed since they are shared across different OS and code instances. I'll look into changing the s-Par firmware and will update the iochannels structure as well. =20 Your reference to x86, does that include x86_64?=20 Thanks,=20 David