From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FF5C2D0EA for ; Wed, 8 Apr 2020 08:52:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D2C220769 for ; Wed, 8 Apr 2020 08:52:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="p8dZjsO6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D2C220769 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 79013825; Wed, 8 Apr 2020 10:51:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 79013825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586335954; bh=ySY+joU40yI+EghBT5irMpMuY/0ZXfrHbIXwSFKP9FA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p8dZjsO6BanfGYllCe5ROknAojKjFR1yyR2uYipuJXboM08uR2LoSHRbLBNaEDsQp BF//g1hJinkLgU2GxHlQYKzTHyz0ov7XYXDZyCDRjB8osxIKmt3T05wz/8WSnXILti QLH19RgzpSpj/OaGpBPErHdhFKmsg2vvdBAkRWM4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 06AC9F80142; Wed, 8 Apr 2020 10:51:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 40433F80143; Wed, 8 Apr 2020 10:51:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0EF47F80105 for ; Wed, 8 Apr 2020 10:51:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0EF47F80105 IronPort-SDR: 4K6BBVN5oX1o3786bLcpMNGzM/PAsHJB+HFJ8dht/j5YTM6E0d8WkYCVbLxvz3zzxoaDI98omJ mu6lCZnac1Lw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 01:51:30 -0700 IronPort-SDR: VVVLq9DGjj84f69mSu0cDtZ6idWZulcyc6c/GumD4a167miInOd2idGL0+IH9PZCfZRxHm+iDt Jh8HyH1lh6jw== X-IronPort-AV: E=Sophos;i="5.72,357,1580803200"; d="scan'208";a="398140142" Received: from aslawinx-mobl1.ger.corp.intel.com (HELO [10.249.156.141]) ([10.249.156.141]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 01:51:28 -0700 Subject: Re: [PATCH v2 0/6] ASoC: topology: Propagate error appropriately To: Pierre-Louis Bossart , Liam Girdwood , Mark Brown , Takashi Iwai References: <20200327204729.397-1-amadeuszx.slawinski@linux.intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: Date: Wed, 8 Apr 2020 10:51:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Ranjani Sridharan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/30/2020 6:38 PM, Pierre-Louis Bossart wrote: > > > On 3/27/20 3:47 PM, Amadeusz Sławiński wrote: >> v1: >>    Check if kstrdup succeeded. >> >> v2: >>    Remove unneeded freeing, which is performed in another place by dobj >>    handlers. >> >>    Additionally for functions which have return status which was ignored, >>    perform success checks and handle failures in appropriate way. >> >> Amadeusz Sławiński (6): >>    ASoC: topology: Add missing memory checks >>    ASoC: topology: Check return value of soc_tplg_create_tlv >>    ASoC: topology: Check return value of soc_tplg_*_create >>    ASoC: topology: Check soc_tplg_add_route return value >>    ASoC: topology: Check return value of pcm_new_ver >>    ASoC: topology: Check return value of soc_tplg_dai_config > > Looks good to me > > Reviewed-by: Pierre-Louis Bossart > > We probably want Ranjani to double-check this series though. > Hi Ranjani, can you take another look, I would like for this to get merged before I forget about it ;) >> >>   sound/soc/soc-topology.c | 113 ++++++++++++++++++++++++++++++--------- >>   1 file changed, 88 insertions(+), 25 deletions(-) >>