From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: Wayne Lin <Wayne.Lin@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Rodrigo.Siqueira@amd.com, jerry.zuo@amd.com, hersenxs.wu@amd.com,
Nicholas.Kazlauskas@amd.com
Subject: Re: [PATCH] drm/amd/dc: Read from DP_SINK_COUNT_ESI for DPDC r1.2 or higher
Date: Tue, 04 Aug 2020 09:55:33 -0400 [thread overview]
Message-ID: <a7b841e16e781f433f8f68a5e957232357bd71fb.camel@amd.com> (raw)
In-Reply-To: <20200804034218.612-1-Wayne.Lin@amd.com>
On Tue, 2020-08-04 at 11:42 +0800, Wayne Lin wrote:
> [Why]
> According to DP spec, DPRX with DPCD r1.2 or higher shall have the
> same Link/Sink Device Status field registers at DPCD Addresses 00200h
> through 00205h to the corresponding DPRX Event Status Indicator
> registers at DPCD Addresses 02002h through 0200Fh. We now only read
> from
> 02002h when DPCD revision number is r1.4 or higher while handling
> short
> HPD. Need to correct that.
>
> [How]
> Set to read from 02002h when DPCD is r1.2 or higher
>
> Signed-off-by: Wayne Lin <
> Wayne.Lin@amd.com
> >
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 2bfa4e35c2cf..9fb1543b4c73 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -1834,9 +1834,9 @@ static enum dc_status read_hpd_rx_irq_data(
> * fail, so we now explicitly read 6 bytes which is
> * the req from the above mentioned test cases.
> *
> - * For DP 1.4 we need to read those from 2002h range.
> + * For DPCD r1.2 or higher, we need to read those from 2002h
> range.
> */
> - if (link->dpcd_caps.dpcd_rev.raw < DPCD_REV_14)
> + if (link->dpcd_caps.dpcd_rev.raw < DPCD_REV_12)
> retval = core_link_read_dpcd(
> link,
> DP_SINK_COUNT,
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-04 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 3:42 [PATCH] drm/amd/dc: Read from DP_SINK_COUNT_ESI for DPDC r1.2 or higher Wayne Lin
2020-08-04 13:55 ` Aurabindo Pillai [this message]
2020-08-04 14:21 ` Wu, Hersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7b841e16e781f433f8f68a5e957232357bd71fb.camel@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=hersenxs.wu@amd.com \
--cc=jerry.zuo@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.