From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE73FC11F64 for ; Thu, 1 Jul 2021 18:14:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23CEE61357 for ; Thu, 1 Jul 2021 18:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23CEE61357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz1Cl-0001sL-51 for qemu-devel@archiver.kernel.org; Thu, 01 Jul 2021 14:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz1Bj-0001B6-KU for qemu-devel@nongnu.org; Thu, 01 Jul 2021 14:13:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz1Bf-0000Au-Cw for qemu-devel@nongnu.org; Thu, 01 Jul 2021 14:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625163197; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7er/8hW/Zj7AjuYSFTY2KEc0kOkas45MN22ObJBB2aE=; b=O0WA2sSJA0zobUyf36O5SgRXQVymVWh7IB1AR5yps7RXk3cJQiWygTwqFQpnNTWXrmQ3NG oUzcJ/vpiKGljvJ1mbAupnbgk3pNqb6gpP8wKkNSmtSPjCTyAesDx9uqIOG5mJFdrn7Nv/ trj0ks+YQxH3uaen4PD8FCei3ohyMP8= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-RXmaG_TdNySxUqnwaqbwjw-1; Thu, 01 Jul 2021 14:13:16 -0400 X-MC-Unique: RXmaG_TdNySxUqnwaqbwjw-1 Received: by mail-pg1-f199.google.com with SMTP id 137-20020a63058f0000b02902285c45652dso3322pgf.4 for ; Thu, 01 Jul 2021 11:13:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=7er/8hW/Zj7AjuYSFTY2KEc0kOkas45MN22ObJBB2aE=; b=Ri3XY7rvhf1hwpLgBb5HZB200phrM8srRmijy2DxHtSolXoqrNPcpFcemSts6EKO8N OA+DAND8AhGdRPyYPH/P3rkk9ZfYJLBg+fWbzD0Kq3M9i3zFoB7kPZdoxX6KTbS5jWt3 /dq9VW1LvUwgS/cfS/HKkc63UuilZYVx4ukvYFmB/OHrrXD37PnqMgJA79vZh809w5zf sgks+edpw4AKoCs4ppkjmrO0waZMjPO9QUAsiQi2oZZ4CPQteg6dOVGao0oR3st9kWdm BPBK+McUyWMLIUSk2Vv0TWbF30jsdpZ0QTh8h775fjktr2xIzDJ7YczCopTHmWhBKwSt l0yw== X-Gm-Message-State: AOAM532wTdzyOl1yNlur5TS72CbMZR31J3pm1/DrgYVYQJjwou70w/7W lfcDu/PAvvBfpQ01cT2pXSJyR7sU4WsDB5pGsGVzVGlpf/Cw5bl+wNltPazRl2jlsDe3wOxPrNt JUYQjlWdPTXlxF3Y= X-Received: by 2002:a62:4ec5:0:b029:309:7068:6dcb with SMTP id c188-20020a624ec50000b029030970686dcbmr1272776pfb.64.1625163195092; Thu, 01 Jul 2021 11:13:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywiWaiBq/xbf9PCpyUtr2ZAdnibjD4oulZpaJtPo/MFjWLVrFS0IPZmKIPTo63ej6LdQXQ+Q== X-Received: by 2002:a62:4ec5:0:b029:309:7068:6dcb with SMTP id c188-20020a624ec50000b029030970686dcbmr1272751pfb.64.1625163194777; Thu, 01 Jul 2021 11:13:14 -0700 (PDT) Received: from wainer-laptop.localdomain ([179.105.223.44]) by smtp.gmail.com with ESMTPSA id w14sm543609pgo.75.2021.07.01.11.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 11:13:14 -0700 (PDT) Subject: Re: [PATCH v4 2/4] avocado_qemu: Add SMMUv3 tests To: Eric Auger , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, philmd@redhat.com, crosa@redhat.com References: <20210629143621.907831-1-eric.auger@redhat.com> <20210629143621.907831-3-eric.auger@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Thu, 1 Jul 2021 15:13:08 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210629143621.907831-3-eric.auger@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.402, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wainersm@redhat.com Cc: wrampazz@redhat.com, peterx@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 6/29/21 11:36 AM, Eric Auger wrote: > Add new tests checking the good behavior of the SMMUv3 protecting > 2 virtio pci devices (block and net). We check the guest boots and > we are able to install a package. Different guest configs are tested: > standard, passthrough an strict=0. This is tested with both fedora 31 and > 33. The former uses a 5.3 kernel without range invalidation whereas the > latter uses a 5.8 kernel that features range invalidation. > > Signed-off-by: Eric Auger > > --- > > v3 -> v4: > - add tags for machine, distro in the class > - removed smp and memory overrides > - set default param value of common_vm_setup to False > > v1 -> v2: > - removed ssh import > - combined add_command_args() and common_vm_setup() > - moved tags in class' docstring and added tags=arch:aarch64 > - use self.get_default_kernel_params() > - added RIL tests with fed33 + introduce new tags > --- > tests/acceptance/smmu.py | 132 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 tests/acceptance/smmu.py Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta I tested it in a Fedora 32 aarch64 host. The execution output: # ./tests/venv/bin/avocado run tests/acceptance/smmu.py JOB ID     : 1625038f5a2ae17c8ba6c503d3df8661ff528942 JOB LOG    : /root/avocado/job-results/job-2021-07-01T13.38-1625038/job.log  (1/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril: PASS (175.54 s)  (2/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril_passthrough: WARN: Test passed but there were warnings during execution. Check the log for details. (168.39 s)  (3/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril_nostrict: WARN: Test passed but there were warnings during execution. Check the log for details. (161.58 s)  (4/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril: PASS (150.85 s)  (5/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril_passthrough: WARN: Test passed but there were warnings during execution. Check the log for details. (177.56 s)  (6/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril_nostrict: WARN: Test passed but there were warnings during execution. Check the log for details. (190.86 s) RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 4 | INTERRUPT 0 | CANCEL 0 JOB TIME   : 1026.50 s One thing that caught my attention was the amount of time spent on each test. It spend more than 2 minutes on the package installation (`self.ssh_command('dnf -y install numactl-devel')`) in the guest. Without that operation, it runs way faster: # ./tests/venv/bin/avocado run tests/acceptance/smmu.py JOB ID     : 24f22f99169ece37df64d72d2eb373921f378aac JOB LOG    : /root/avocado/job-results/job-2021-07-01T13.28-24f22f9/job.log  (1/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril: PASS (39.61 s)  (2/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril_passthrough: WARN: Test passed but there were warnings during execution. Check the log for details. (48.32 s)  (3/6) tests/acceptance/smmu.py:SMMU.test_smmu_noril_nostrict: WARN: Test passed but there were warnings during execution. Check the log for details. (48.10 s)  (4/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril: PASS (39.22 s)  (5/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril_passthrough: WARN: Test passed but there were warnings during execution. Check the log for details. (52.92 s)  (6/6) tests/acceptance/smmu.py:SMMU.test_smmu_ril_nostrict: WARN: Test passed but there were warnings during execution. Check the log for details. (50.96 s) RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 4 | INTERRUPT 0 | CANCEL 0 JOB TIME   : 280.62 s Install a package seems a good exerciser for disk I/O and networking, but maybe you can use another method for the sake of speed up the tests? - Wainer > > diff --git a/tests/acceptance/smmu.py b/tests/acceptance/smmu.py > new file mode 100644 > index 0000000000..c1d4b88e5f > --- /dev/null > +++ b/tests/acceptance/smmu.py > @@ -0,0 +1,132 @@ > +# SMMUv3 Functional tests > +# > +# Copyright (c) 2021 Red Hat, Inc. > +# > +# Author: > +# Eric Auger > +# > +# This work is licensed under the terms of the GNU GPL, version 2 or > +# later. See the COPYING file in the top-level directory. > + > +import os > + > +from avocado_qemu import LinuxTest, BUILD_DIR > + > +class SMMU(LinuxTest): > + """ > + :avocado: tags=accel:kvm > + :avocado: tags=cpu:host > + :avocado: tags=arch:aarch64 > + :avocado: tags=machine:virt > + :avocado: tags=distro:fedora > + :avocado: tags=smmu > + """ > + > + IOMMU_ADDON = ',iommu_platform=on,disable-modern=off,disable-legacy=on' > + kernel_path = None > + initrd_path = None > + kernel_params = None > + > + def set_up_boot(self): > + path = self.download_boot() > + self.vm.add_args('-device', 'virtio-blk-pci,bus=pcie.0,scsi=off,' + > + 'drive=drv0,id=virtio-disk0,bootindex=1,' > + 'werror=stop,rerror=stop' + self.IOMMU_ADDON) > + self.vm.add_args('-drive', > + 'file=%s,if=none,cache=writethrough,id=drv0' % path) > + > + def setUp(self): > + super(SMMU, self).setUp(None, 'virtio-net-pci' + self.IOMMU_ADDON) > + > + def common_vm_setup(self, custom_kernel=False): > + self.require_accelerator("kvm") > + self.vm.add_args("-accel", "kvm") > + self.vm.add_args("-cpu", "host") > + self.vm.add_args("-machine", "iommu=smmuv3") > + self.vm.add_args("-d", "guest_errors") > + self.vm.add_args('-bios', os.path.join(BUILD_DIR, 'pc-bios', > + 'edk2-aarch64-code.fd')) > + self.vm.add_args('-device', 'virtio-rng-pci,rng=rng0') > + self.vm.add_args('-object', > + 'rng-random,id=rng0,filename=/dev/urandom') > + > + if custom_kernel is False: > + return > + > + kernel_url = self.get_pxeboot_url() + 'vmlinuz' > + initrd_url = self.get_pxeboot_url() + 'initrd.img' > + self.kernel_path = self.fetch_asset(kernel_url) > + self.initrd_path = self.fetch_asset(initrd_url) > + > + def run_and_check(self): > + if self.kernel_path: > + self.vm.add_args('-kernel', self.kernel_path, > + '-append', self.kernel_params, > + '-initrd', self.initrd_path) > + self.launch_and_wait() > + self.ssh_command('cat /proc/cmdline') > + self.ssh_command('dnf -y install numactl-devel') > + > + > + # 5.3 kernel without RIL # > + > + def test_smmu_noril(self): > + """ > + :avocado: tags=smmu_noril > + :avocado: tags=smmu_noril_tests > + :avocado: tags=distro_version:31 > + """ > + self.common_vm_setup() > + self.run_and_check() > + > + def test_smmu_noril_passthrough(self): > + """ > + :avocado: tags=smmu_noril_passthrough > + :avocado: tags=smmu_noril_tests > + :avocado: tags=distro_version:31 > + """ > + self.common_vm_setup(True) > + self.kernel_params = self.get_default_kernel_params() + ' iommu.passthrough=on' > + self.run_and_check() > + > + def test_smmu_noril_nostrict(self): > + """ > + :avocado: tags=smmu_noril_nostrict > + :avocado: tags=smmu_noril_tests > + :avocado: tags=distro_version:31 > + """ > + self.common_vm_setup(True) > + self.kernel_params = self.get_default_kernel_params() + ' iommu.strict=0' > + self.run_and_check() > + > + # 5.8 kernel featuring range invalidation > + # >= v5.7 kernel > + > + def test_smmu_ril(self): > + """ > + :avocado: tags=smmu_ril > + :avocado: tags=smmu_ril_tests > + :avocado: tags=distro_version:33 > + """ > + self.common_vm_setup() > + self.run_and_check() > + > + def test_smmu_ril_passthrough(self): > + """ > + :avocado: tags=smmu_ril_passthrough > + :avocado: tags=smmu_ril_tests > + :avocado: tags=distro_version:33 > + """ > + self.common_vm_setup(True) > + self.kernel_params = self.get_default_kernel_params() + ' iommu.passthrough=on' > + self.run_and_check() > + > + def test_smmu_ril_nostrict(self): > + """ > + :avocado: tags=smmu_ril_nostrict > + :avocado: tags=smmu_ril_tests > + :avocado: tags=distro_version:33 > + """ > + self.common_vm_setup(True) > + self.kernel_params = self.get_default_kernel_params() + ' iommu.strict=0' > + self.run_and_check()