From: Andres Lagar-Cavilla <andres@lagarcavilla.org>
To: xen-devel@lists.xen.org
Cc: andres@gridcentric.ca, tim@xen.org
Subject: [PATCH 4 of 6] x86/mm/shadow: fix p2m/paging deadlock when updating shadow mode
Date: Fri, 13 Apr 2012 12:22:22 -0400 [thread overview]
Message-ID: <a7ca6ae7399224c08eba.1334334142@xdev.gridcentric.ca> (raw)
In-Reply-To: <patchbomb.1334334138@xdev.gridcentric.ca>
xen/arch/x86/mm/shadow/common.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
diff -r 964c6cbad926 -r a7ca6ae73992 xen/arch/x86/mm/shadow/common.c
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -2997,9 +2997,13 @@ static void sh_update_paging_modes(struc
void shadow_update_paging_modes(struct vcpu *v)
{
+ /* Avoid deadlock in shadow mode. When updating, we might need to resync an
+ * l1 and thus get_gfn on all the gfn's pointed to by the guest l1e pte's. */
+ p2m_lock(p2m_get_hostp2m(v->domain));
paging_lock(v->domain);
sh_update_paging_modes(v);
paging_unlock(v->domain);
+ p2m_unlock(p2m_get_hostp2m(v->domain));
}
/**************************************************************************/
next prev parent reply other threads:[~2012-04-13 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 16:22 [PATCH 0 of 6] x86/mm/shadow: fixes and synchronized p2m lookups Andres Lagar-Cavilla
2012-04-13 16:22 ` [PATCH 1 of 6] x86/mm: Print stack trace on a an mm-locks deadlock panic Andres Lagar-Cavilla
2012-04-18 15:55 ` Tim Deegan
2012-04-18 15:58 ` Andres Lagar-Cavilla
2012-04-13 16:22 ` [PATCH 2 of 6] x86/mm/shadow: enclose an OOS function in the proper conditional ifdef Andres Lagar-Cavilla
2012-04-14 14:08 ` Gianluca Guida
2012-04-18 15:52 ` Tim Deegan
2012-04-13 16:22 ` [PATCH 3 of 6] x86/mm/shadow: fix potential p2m/paging deadlock when emulating page table writes Andres Lagar-Cavilla
2012-04-18 16:13 ` Tim Deegan
2012-04-18 16:25 ` Andres Lagar-Cavilla
2012-04-19 14:51 ` Tim Deegan
2012-04-19 15:07 ` Andres Lagar-Cavilla
2012-04-13 16:22 ` Andres Lagar-Cavilla [this message]
2012-04-13 16:22 ` [PATCH 5 of 6] x86/mm/shadow: fix p2m/paging deadlock when updating shadow cr3 Andres Lagar-Cavilla
2012-04-13 16:22 ` [PATCH 6 of 6] x86/mm: Locking p2m lookups in shadow mode Andres Lagar-Cavilla
2012-04-18 16:03 ` Tim Deegan
2012-04-13 17:35 ` [PATCH 0 of 6] x86/mm/shadow: fixes and synchronized p2m lookups Tim Deegan
2012-04-13 17:37 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ca6ae7399224c08eba.1334334142@xdev.gridcentric.ca \
--to=andres@lagarcavilla.org \
--cc=andres@gridcentric.ca \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.