From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB1EC10DCE for ; Sun, 15 Mar 2020 10:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0365206E9 for ; Sun, 15 Mar 2020 10:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="b5O729U+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728221AbgCOKBW (ORCPT ); Sun, 15 Mar 2020 06:01:22 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:40008 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbgCOKBV (ORCPT ); Sun, 15 Mar 2020 06:01:21 -0400 Received: by mail-lf1-f68.google.com with SMTP id j17so11441833lfe.7 for ; Sun, 15 Mar 2020 03:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=71ORSjZ3Dn1AeJ5HCzovvghC6s/uKrTIuOwAzA8cnlc=; b=b5O729U+kA6wNZMWkRMZ2f+9gLV2ekOaJTecFIJtCJuzYBWqPUm8CzUVYcJgBisJWT GLuL7jk9X1V0nyATtENYx1uBjEs+rCulddzR0yw0WgnGPQjAABnlVb1uNPyCJLkl1iok vMDJWuaIuZEsGdABO+3ZXiUIs8oCGiqETweY2dNRwfDh9OMBi06mpi19FPeUeyQYg5TJ ZuQiARjLsFNIP3icVlxCX9Tyb63CL0JW9/XUZr95bpntxgXQZvWniZB/6a9QKtOZAWh2 5rUPRevjrLAiCDo3iiqmCdYyN1SAcz4M/58X8ub1ba3YqijNeICS9FmqqSczcfipFrZB E4SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=71ORSjZ3Dn1AeJ5HCzovvghC6s/uKrTIuOwAzA8cnlc=; b=pDsFY6P1t76eAvQZYuwjjdsnWQBRv/SBHWvtKEFs9YxoX/RdqvlfiWL+Tfpm+/DSX+ ckAzD+TW4b4PDKd6ATT+QpKV8cQAIcygQ48wHhSTDJuxC+qK4rIOXOlNefjEC7rXnQ7y Ixmvhnvl6HZqNqAeLpmE8W5sB5FpZXm/nFRTFwz/QRaJMvmP/1LBKafjg/WKKbyBehyh 3NTK2htEdCouoTfB5SE+It44MggkwpqYaJXStmeB8cwcr0y7pWS4lmTjyEi5iHvgiyOR gkDiwIOsGCKrnX9XpxFi0oqGC7qyzikunA/g29YfAMMjqg2BCFuSfx1dBoGAcTfLcfgX VrbA== X-Gm-Message-State: ANhLgQ3b/eKjNJzE+iMqPVnD+8GNLtVacFYjzPXrYgCxfoVJQ/IEgF0q vkTDIo5rx4fzcEzdl7RdyrZZXAVw/46MMw== X-Google-Smtp-Source: ADFU+vuZsCqDScD5JeOlek4PJ1cGVfZOBeUno5n2lRms8OCKw1HTXMMiaSeqFlVPKJo2nj/7Ihtp3A== X-Received: by 2002:a19:ca46:: with SMTP id h6mr1688652lfj.108.1584266477579; Sun, 15 Mar 2020 03:01:17 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:86a:1c7c:64a6:f77:4be8:4439? ([2a00:1fa0:86a:1c7c:64a6:f77:4be8:4439]) by smtp.gmail.com with ESMTPSA id t15sm3353585lfl.79.2020.03.15.03.01.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2020 03:01:16 -0700 (PDT) Subject: Re: [PATCH v2 1/4] drivers: provide devm_platform_ioremap_and_get_resource() To: Dejin Zheng , gregkh@linuxfoundation.org, rafael@kernel.org, hminas@synopsys.com, mathias.nyman@intel.com, bgolaszewski@baylibre.com, arnd@arndb.de, geert@linux-m68k.org, mchehab+samsung@kernel.org, treding@nvidia.com, tglx@linutronix.de, suzuki.poulose@arm.com, hdegoede@redhat.com, linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20200314052638.6008-1-zhengdejin5@gmail.com> <20200314052638.6008-2-zhengdejin5@gmail.com> From: Sergei Shtylyov Message-ID: Date: Sun, 15 Mar 2020 13:01:14 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200314052638.6008-2-zhengdejin5@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 14.03.2020 8:26, Dejin Zheng wrote: > Since commit "drivers: provide devm_platform_ioremap_resource()", > It was wrap platform_get_resource() and devm_ioremap_resource() as ^^ it > single helper devm_platform_ioremap_resource(). but now, many drivers > still used platform_get_resource() and devm_ioremap_resource() > together in the kernel tree. The reason can not be replaced is they > still need use the resource variables obtained by platform_get_resource(). > so provide this helper. Not really sure that's worth the effort... > Signed-off-by: Dejin Zheng > --- > drivers/base/platform.c | 18 ++++++++++++++++++ > include/linux/platform_device.h | 3 +++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 7fa654f1288b..b3e2409effae 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -62,6 +62,24 @@ struct resource *platform_get_resource(struct platform_device *dev, > EXPORT_SYMBOL_GPL(platform_get_resource); > > #ifdef CONFIG_HAS_IOMEM > +/** > + * devm_platform_ioremap_and_get_resource - call devm_ioremap_resource() for a > + * platform device and get resource > + * > + * @pdev: platform device to use both for memory resource lookup as well as > + * resource management > + * @index: resource index > + * @res: get the resource > + */ > +void __iomem * > +devm_platform_ioremap_and_get_resource(struct platform_device *pdev, > + unsigned int index, struct resource **res) > +{ > + *res = platform_get_resource(pdev, IORESOURCE_MEM, index); > + return devm_ioremap_resource(&pdev->dev, *res); > +} > +EXPORT_SYMBOL_GPL(devm_platform_ioremap_and_get_resource); That looks more like devm_platform_get_and_ioremap_resource(). [...] MBR, Sergei