From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter Date: Tue, 15 Jan 2019 11:21:19 -0500 Message-ID: References: <20190112025542.397-1-xiyou.wangcong@gmail.com> <2c84f3cc-b1ad-5316-4813-e7e433bf9f5e@mojatatu.com> <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Martin Olsson , Jiri Pirko , Lucas Bates To: Cong Wang Return-path: Received: from mail-it1-f169.google.com ([209.85.166.169]:55066 "EHLO mail-it1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731450AbfAOQVW (ORCPT ); Tue, 15 Jan 2019 11:21:22 -0500 Received: by mail-it1-f169.google.com with SMTP id i145so5893746ita.4 for ; Tue, 15 Jan 2019 08:21:21 -0800 (PST) In-Reply-To: <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2019-01-15 10:59 a.m., Jamal Hadi Salim wrote: > On 2019-01-13 4:08 p.m., Cong Wang wrote: >> On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim [..] > I agree with your rationale. > Lets have Lucas give this a run and we can move > forward. And as an addendum - Martin corrected me, he did have a "continue" after the vlan pop (not illegal to do). So i think your patch is fine; lets not mix it up with vlan not correctly matching (two separate issues). Lets have Lucas create the tdc test, then add my Ack. cheers, jamal