From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8822C64EC7 for ; Tue, 28 Feb 2023 12:46:22 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90685410D4; Tue, 28 Feb 2023 13:46:21 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2068.outbound.protection.outlook.com [40.107.93.68]) by mails.dpdk.org (Postfix) with ESMTP id 7C8F04021F for ; Tue, 28 Feb 2023 13:46:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WleJbAC1y/yHTyF0pbOt2UOGItq33kroo0daonWfvDe8q/cFy4LWFQD5NTjyeuoD43FKj8G6LdroiBQcxGJifBoDRxFvF6Whx4Tnp0fd7x5gFjhqsxkDprmfyy41m1LauLiRpr1sVlQwGQYiI42IDEKUXYLsQCyFVJQN8jBdsHlGqM8q7KiI9UvGmNYjHlYbYjNiizuLiu+pqnBk31hVWZ05NtRwvYdTsPJ3wSxxKsYDQvRxXSGn8UwGnCEhegfZWyuVD5Af6l7B9oYj7Zv6F9JDDpL0iZoZP+7dBqgp/PeTJbQ/Z5X/sFr7XJWpXNwjy83OAMZptfPBGuihqg4fqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/Mk39XZt26Z79u44yOd5X4rxR1N6eXvydZAlZkL/OY=; b=MyG0wmdRpPmlKYMdildy8j2XdYwqw02WImYQXFRzYtBI/Mj+LoETu/QsJnuzzAV4TLUmOkEQRjn+IJNEcaEjSXpyFldqxUIblsMVw7+M+Rt5eXVDZCrsFNNlWR1puEc1wHvC8OISjQkuQ1mQ0YVlQTaDZeni9E3ps3DbPnWE2vCu+asBtVinBzx2Q6swoUfFOEl6dVm/5AXFX0Md3GHkrufeMvfIV6XB+G5oPs0BRAwxjgx2NC6x1M/ysJ+yFU4jZ4EakrQ73/Uxm61CVffQlK5YnzTZj6DgSoRDYyZoBHIJjrZdWYoN8kcyOZeR5g1/ZPDJKgFeliRXY0V3j3B0EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/Mk39XZt26Z79u44yOd5X4rxR1N6eXvydZAlZkL/OY=; b=hUr1WB/DihoWCZiimNJ1bsAdKaVBVb72cBI/FGCIgq6xjxMSBFdKJloyKpP9+7m7BLfSFwbRK8NDARQ1NJAOWNXwvSH+svnFWmZk37K/xgh30iX1oYYcBpqaq94HirZa39doMFHYl+8E0JzGU/e4iu1N8dnu2fRtFb8KsknOpVY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by CY5PR12MB6108.namprd12.prod.outlook.com (2603:10b6:930:27::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Tue, 28 Feb 2023 12:46:17 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 12:46:17 +0000 Message-ID: Date: Tue, 28 Feb 2023 12:46:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/2] ethdev: fix null pointer dereference Content-Language: en-US To: David Marchand Cc: Ankur Dwivedi , dev@dpdk.org, Thomas Monjalon , jerinj@marvell.com, Ali Alnubani , "Li, WeiyuanX" References: <20230223123029.2117781-1-adwivedi@marvell.com> <20230223123029.2117781-2-adwivedi@marvell.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0039.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::18) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|CY5PR12MB6108:EE_ X-MS-Office365-Filtering-Correlation-Id: 35e8df39-0b16-4e61-f436-08db1989c8ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrijIhaqlwhosjzf0kTRqOk15FeS7C/wnrsbVQ/KMkaIUOmiFeCcV3Z4E/Wna+dGhdm6GTkjPcOLBV4wqf2abhl0HYXJqj8zLuGITxdaDfyElbJ/btqvR56EiFPC+PRS4VHTnEWpPuZhTGMf3FGoqSZmJyKa8mxNnKFOJHmwxEgbqaCsapZ9huc2ptr0AO4Q+ICvKjah6K0OPuAqt3tJdTafDtAyosAXReE7BhXzOMEHBRO4zwRl5IoKTYI6fqen3RYqS5jw0ZOv2Qhrclx3dfQpqhYSUuVqI44olSSp9x1J3JadZL80vPHx3XwNAxscDTzA/EMpbGHqQa6OQrQNP6qGMVwYsZcHZX11xLnuxIvGsp9Vco7HHzK3YZUpTtbeEz8rvgNWnKVSNrx/UGWQvZNsGOT6IrEoCBxJgqg+jfD6nnRJyGQ1VpIU8Mo0jiWUlVee+fvfpydahj2alsNlD5dQ9nh0L94J/P0uUvsuvxtUPQgvHjVdGqa1UywiGyv2jS8CUoPNZtJPpYobsGVHsxYIfM2QHYC/78tAwMZgbc5NUGM5DLAXKkI+pct8lfs/RbQcAPWF+OSj9OJmy8vg/BgsbPgLefMCm/x9hTwLbyd9SzGrRHqD8smypVbiVG9wNi/vuQ2/Q3bjma/XgpS+HscWIMZQQXXhkD/U57v1HDG2CBVbNyWwPEmw7LbeOJAXkxRvtjolTnpBCLi48RkryrOqn7zujPK/VN8NNvRF3JA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199018)(6486002)(31686004)(186003)(8936002)(66946007)(478600001)(41300700001)(66476007)(31696002)(6916009)(4326008)(8676002)(66556008)(36756003)(86362001)(6506007)(6666004)(966005)(44832011)(53546011)(38100700002)(2616005)(6512007)(2906002)(316002)(54906003)(5660300002)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3hCYVF3T0pueGVUdXlXUExGMklERkpjS1JSUGhFd2I5MUhBRE5sekQreXVT?= =?utf-8?B?ZDRjdm9WWXk4Tm8yUWNraUtxeDFTRXh0TlhMTlRuWVB5ZFFXaldieUJDY3Yw?= =?utf-8?B?L2U5NmhlejJzbkZkRnI2SDdiTkF6RGRiQk1adE1QaGdhQmRIclFNMEdlMWN4?= =?utf-8?B?SktHbDFxYmR4Z2prMnIvWlFCaVgwUStrNXRXZ0dlc3dxZUtvVUZCazcydUxv?= =?utf-8?B?K3c5dG9IeGRDdjdwdUc1dHhIcnoybUdSNGk4N2pzemErN0JxVGVEOEMrYWdy?= =?utf-8?B?OWt1ZmpoMlVCOFQreUoybXpDWEI1SStaME9YNUhpNHpuMmJhUlQ2Ny9pbVFC?= =?utf-8?B?WnlzNzdpOWFQMXIwbC9uTHJTYndubEord1lKVjdFd1VlMllQdFVJL3UvVnNn?= =?utf-8?B?T0dNUG1wcWErMUFBYStmVkwwZFZOZFc3M1BsaUllMDNnV1dYcjJzWm9aUmNt?= =?utf-8?B?ZjlqanZHRENuMmxuR25aYTdTNkhGWFlITnlTMVd1WDByZ0kxVHhVL1V6THp5?= =?utf-8?B?dVdUMDBsWndnN3lYTnJsUi9tNDc1bGgzbXVoQ0FaZ2NPRFZGbW9jdFVsazJk?= =?utf-8?B?SS9SM2JIWkh4U0JGSDhoL1RSU1JsT2dPZzdOKzVvVS9WS0hudFJOMGNIQWtC?= =?utf-8?B?ajBPdUQrdmgyMTRuMnRQMG5IWUZoOXdMS2R5VmtPL2V1ZWdYSHZrSGluVU9y?= =?utf-8?B?N1psUldsbVJhU0JObmVFMzR1Zzh4NkRNMGVLS0F2US96VE5FaG02TzI5WVJw?= =?utf-8?B?dFZxczlac2pWd3hQc2l5clhiQ1M5aGRCQ2F3aGpHSjUxVytRQ1psa0dDR29U?= =?utf-8?B?YVJWZktDbmhFZGVYQlRIaUIwd09pYyszdEZ0dVZJeVFPVmZIQWUyNTBDZE5Q?= =?utf-8?B?ekhBMEhtdlFHNC85WnBFem4wZTNxcmo4ejYvbjRZQTRUZFFtZ3YvcEo0SHov?= =?utf-8?B?Mi9ENHBEOXpzeERXWHh2dnJBZXBWd05DTHFteE9UVmJjWk5lNUtYTDNtYk8v?= =?utf-8?B?SSt4R3NXQTU2M2pPWWRyVDAwcXY5ZHFETnkrNFdmMGJHdTJVM2lDd1p3M3Nm?= =?utf-8?B?K21leWRPZEFVRnZKVUN4aUZUS1BBcm5wSUg0aytlWFRma1I2VWNZSFNBc3F3?= =?utf-8?B?Yk5LZWpLNFQvaE1HSXFZRURSZG93aGhRaXp0RFBSTG1mTCtpZzVsOEp2ZGVI?= =?utf-8?B?aE5RTFVCdHdkL0JxbG8rUDk0QjJtSy9mUU5qUmQrcXlHTU1kMWd1VEJxYi9C?= =?utf-8?B?c1ppektpQVd6VFg0NFhlMzFHSWpMdHZZQmJVR3dNSXJodmFiQTAzeW90M0xs?= =?utf-8?B?WGlOQkg2dFNqZDlMcklEVEtSYVRkRU9VOTF3dVBZUkN1Y0IvY1k1VmZsRXBY?= =?utf-8?B?ZlJ6Mmx6cjdMVU1JbG13WmZpR1dQbkY2aGJVWHVuR0RwUjVMRERabE1NTEcy?= =?utf-8?B?b0hEamZhWTlOeWszZDA1WHk3MWFoNS91bVRseGRGSUgvR204ekpNb0MzaFl3?= =?utf-8?B?ODd0b0djT2Rkd3R0VHpJVlZickNzM0ZaQWhTWWZlVlRwNUtsVjVNU2lXMU1z?= =?utf-8?B?Ny9xREhHV09KRFR2QlZWWXZIQWk1YkVnR1NzcUNXZHIxcFBiZ0xVbnU4dnBS?= =?utf-8?B?eWZNZXBPR1dWSk1nLytLcEVoZWNubE11K0dXUnBWbkkvVEkvMEhkSUxRUFNa?= =?utf-8?B?MG9Jbnd0RjJ3WmErem1ma01wRTNpb2ZZZXd3cWh5L3ZtNHF3M1MxcHdUTlVF?= =?utf-8?B?bVdFbUpXMW9rSmZMUmFVc1V5Ukx0R1RHbjFDNXdNdXZWRTZBZUJzZWxOVkhL?= =?utf-8?B?RjN5MCtmVFdJQ0hneUhlOHZiUEFzUmZOS0VWUDJzYlptcHd4aVJIQm1VbjNo?= =?utf-8?B?bmF6aktzd0tsU00vdmx4S09kZEMzc0FoRWdVSmFUT0pyL25zcE5EVGY4WlRV?= =?utf-8?B?RG11T252Tko3NXRWTEUxYW0xS21HMENWUlJ3akpOYWVteU5SanViTW4xUGY1?= =?utf-8?B?c3BiUTB6L0MvakJEZXFQdHlDcGp6a2lWbTdmN3VSK1JCVGpHenFXdVhSNTVH?= =?utf-8?B?cFFUbDNNSXNNS0FBc3Z3L0sxOFpCQzV1UTVPYnFGTEdRaTlua2hyazZaSlo1?= =?utf-8?Q?P+6UgL86zJO3lDrMxsr/Kptad?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35e8df39-0b16-4e61-f436-08db1989c8ec X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 12:46:17.6961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uKBTOHkwmFme5tXT9SgeX+JEhRs9EiGpiFXu/9ckr5mXf83XwPXYGKL9OUIIx3Jo X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6108 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2023 11:29 AM, David Marchand wrote: > On Tue, Feb 28, 2023 at 12:05 PM Ferruh Yigit wrote: >> >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>> The speed_fec_capa pointer can be null. So dereferencing the pointer is >>> removed and only the pointer is captured in trace function. >>> Fixed few more trace functions in which null pointer can be dereferenced. >>> >>> Coverity issue: 383238 >>> Bugzilla ID: 1162 >>> Fixes: 6679cf21d608 ("ethdev: add trace points") >>> Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") >>> >>> Signed-off-by: Ankur Dwivedi >> >> Hi Ankur, >> >> There is another bug report: https://bugs.dpdk.org/show_bug.cgi?id=1167 >> >> >> As far as I can see that is caused by '__rte_trace_point_register()' is >> calling 'register_fn()' [1]. >> >> At registering trace point stage, most of the pointers can be invalid, >> and this can crash other locations too. > > I remember hitting this issue when running with UBsan. > >> >> Why 'register_fn()' called withing the trace point register? Can we >> remove it? > > IIRC, this is used to evaluate the size of the trace point event. > > Yes, as checked with Jerin, it is used to evaluate size and some sanity checks fro size. We need either find a way to calculate size without really reading the pointer content during register phase, all convert all pointer tracing to emit_ptr(). I prefer first option if we can.