From: Johannes Sixt <j6t@kdbg.org>
To: "Junio C Hamano" <gitster@pobox.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] userdiff: add built-in pattern for rust
Date: Tue, 28 May 2019 22:31:25 +0200 [thread overview]
Message-ID: <a7d42d82-7d84-bf25-55ce-5c57a7ce70e9@kdbg.org> (raw)
In-Reply-To: <xmqqtvde4jxv.fsf@gitster-ct.c.googlers.com>
Am 28.05.19 um 18:34 schrieb Junio C Hamano:
> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
>> Ok, I am adding:
>> ...
>> sure, I thought it was already covered.
>> ...
>> I think that would be fine, ok I am changing it
>
> Thanks, both.
>
> The previous round has already hit 'next' (which means that we won't
> replacing the patch wholesale), so whatever you do, please make the
> update relative to / on top of what is queued as d74e7860
> ("userdiff: add built-in pattern for rust", 2019-05-17).
Ok. So, Marc-André, would you mind resending an incremental patch,
because the word-regexp that is currently in 'next' would catch certain
expressions that should be multiple words as a single word?
-- Hannes
next prev parent reply other threads:[~2019-05-28 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 17:04 [PATCH v3] userdiff: add built-in pattern for rust marcandre.lureau
2019-05-20 19:52 ` Johannes Sixt
2019-05-21 10:57 ` Marc-André Lureau
2019-05-28 16:34 ` Junio C Hamano
2019-05-28 20:31 ` Johannes Sixt [this message]
2019-05-28 21:01 ` Marc-André Lureau
2019-05-30 16:44 ` [PATCH] userdiff: two simplifications of patterns " Johannes Sixt
2019-05-30 18:59 ` Ævar Arnfjörð Bjarmason
2019-05-30 20:32 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7d42d82-7d84-bf25-55ce-5c57a7ce70e9@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcandre.lureau@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.