From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5976AC3A59C for ; Fri, 16 Aug 2019 09:59:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AB752133F for ; Fri, 16 Aug 2019 09:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AB752133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyZ0t-0003OT-DA for qemu-devel@archiver.kernel.org; Fri, 16 Aug 2019 05:59:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34184) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyYzs-0002HO-4v for qemu-devel@nongnu.org; Fri, 16 Aug 2019 05:58:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyYzq-0006TF-Uy for qemu-devel@nongnu.org; Fri, 16 Aug 2019 05:58:12 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39524) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyYzq-0006SK-Nh for qemu-devel@nongnu.org; Fri, 16 Aug 2019 05:58:10 -0400 Received: by mail-wr1-f66.google.com with SMTP id t16so981493wra.6 for ; Fri, 16 Aug 2019 02:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Foo7mqc4L4owvltcL+chmVAdJxdrnYoZDMnBcLnmc5c=; b=KsV4ucR/FlUCyMVNGLfIhr43p5efHTUT0SBsPLgqz2hIKSAhpgy04EM9IzzFwgafFj /kUnPhe1vI74hYuEWCGeCBcxFO0e/ckLWrSkKq2VtI6dOk1A/hjl0ZGr8nMzyL03B6S0 KSVcWlCKPNzK8/BHjnhCTfE+/dD7RI4NjYNvOg9A2/uyxyYR4RqdRX0Eu9HfZmnDjjJO zkQkDfZ8ttAk9EseGNAAn/i6a9UiATq+C1KKjMBEzy2KLpWKnIHGo4a37FMxfb++kbOc Bbgh/WAwRgKVuHN8eiiJwGKM1fp3kIkFkPzj+QS5YuNyHb/3gHvP97cBYpC4RrbU+t6I J1Gg== X-Gm-Message-State: APjAAAU6apOKmVvM15VP0ggO//8s1BHzzGv3F2jM5HU0IydoBeLkFQuw an/Wk8cRRfNTDmMt0eexPt/MNQ== X-Google-Smtp-Source: APXvYqxEtH9z2rQcNW2PoiyLykUukmpcl5g1WXvMOKgN8N7tudUZZZ63JDl5GzOk7+ZQwUPBP9c8/A== X-Received: by 2002:adf:82d4:: with SMTP id 78mr9141289wrc.85.1565949489545; Fri, 16 Aug 2019 02:58:09 -0700 (PDT) Received: from [192.168.1.39] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id z1sm5419150wrp.51.2019.08.16.02.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 02:58:08 -0700 (PDT) To: tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Fri, 16 Aug 2019 11:58:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 Subject: Re: [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, jasowang@redhat.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, jan.kiszka@web.de, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, amarkovic@wavecomp.com, peter.chubb@nicta.com.au, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, green@moxielogic.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, lersek@redhat.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, pbonzini@redhat.com, stefanb@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Tony, On 8/16/19 8:28 AM, tony.nguyen@bt.com wrote: > This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE. > > v7: [...] > - Re-declared many native endian devices as little or big endian. This is why > v7 has +16 patches. Why are you doing that? What is the rational? Anyhow if this not required by your series, you should split it out of it, and send it on your principal changes are merged. I'm worried because this these new patches involve many subsystems (thus maintainers) and reviewing them will now take a fair amount of time. > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > targets from the set of target/hw/*/device.o. > > If the set of targets are all little or all big endian, re-declare > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN > respectively. If only little endian targets use a device, that doesn't mean the device is designed in little endian... Then if a big endian target plan to use this device, it will require more work and you might have introduced regressions... I'm not sure this is a safe move. > This *naive* deduction may result in genuinely native endian devices > being incorrectly declared as little or big endian, but should not > introduce regressions for current targets. Regards, Phil. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200A0C3A59C for ; Fri, 16 Aug 2019 09:58:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F29DF2171F for ; Fri, 16 Aug 2019 09:58:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F29DF2171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyYzu-0003zw-Nh; Fri, 16 Aug 2019 09:58:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyYzt-0003zo-RI for xen-devel@lists.xenproject.org; Fri, 16 Aug 2019 09:58:13 +0000 X-Inumbo-ID: 5a580fb8-c00c-11e9-8bb3-12813bfff9fa Received: from mail-wr1-f65.google.com (unknown [209.85.221.65]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a580fb8-c00c-11e9-8bb3-12813bfff9fa; Fri, 16 Aug 2019 09:58:10 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id s18so999600wrn.1 for ; Fri, 16 Aug 2019 02:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Foo7mqc4L4owvltcL+chmVAdJxdrnYoZDMnBcLnmc5c=; b=Ror6Xpp4eYr6ky3x2EqIAV7FNYSuQJczmKCFoF7bgMqtcGE/MaUFuzSj+1jAZBeSP+ 1JabYpDGU/ZmxljdzgRKUyXb3WiYngsaKz0DZ+pMwS7UxvR1BR8QKjWUUizhdUPH7L0i S6+7Bvnb8jIvZ4kcQu6DUfCNwYjyEjfunEg36ItvddYNqytWyE3MfOBehqPE70+yc+yT CkcNW2Wi7n6rH068pDJC+7lf7TDnKUhQBauRLvt5VTxM5KkbszpzpNTdo+ECP7iFR+cv 0ZB1wlf6kTkKtEkVzHB2+EIDEHMmy2eu7BEsN4FeirH3ijZS3+Prbn1YHmylUn94OP6Z m3Og== X-Gm-Message-State: APjAAAUXUjstaYp2GKagGq+sck5iTEV6jUVqaAREUHkn8+X5OUnnqLrA p3tv1hy2UseKaHbmlhCYR/ehlw== X-Google-Smtp-Source: APXvYqxEtH9z2rQcNW2PoiyLykUukmpcl5g1WXvMOKgN8N7tudUZZZ63JDl5GzOk7+ZQwUPBP9c8/A== X-Received: by 2002:adf:82d4:: with SMTP id 78mr9141289wrc.85.1565949489545; Fri, 16 Aug 2019 02:58:09 -0700 (PDT) Received: from [192.168.1.39] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id z1sm5419150wrp.51.2019.08.16.02.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 02:58:08 -0700 (PDT) To: tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Fri, 16 Aug 2019 11:58:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> Content-Language: en-US Subject: Re: [Xen-devel] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, balrogg@gmail.com, jasowang@redhat.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, balaton@eik.bme.hu, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, marcel.apfelbaum@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, jan.kiszka@web.de, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, amarkovic@wavecomp.com, peter.chubb@nicta.com.au, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, green@moxielogic.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, lersek@redhat.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, pbonzini@redhat.com, stefanb@linux.ibm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" SGkgVG9ueSwKCk9uIDgvMTYvMTkgODoyOCBBTSwgdG9ueS5uZ3V5ZW5AYnQuY29tIHdyb3RlOgo+ IFRoaXMgcGF0Y2hzZXQgaW1wbGVtZW50cyB0aGUgSUUgKEludmVydCBFbmRpYW4pIGJpdCBpbiBT UEFSQ3Y5IE1NVSBUVEUuCj4gCj4gdjc6ClsuLi5dCj4gLSBSZS1kZWNsYXJlZCBtYW55IG5hdGl2 ZSBlbmRpYW4gZGV2aWNlcyBhcyBsaXR0bGUgb3IgYmlnIGVuZGlhbi4gVGhpcyBpcyB3aHkKPiAg IHY3IGhhcyArMTYgcGF0Y2hlcy4KCldoeSBhcmUgeW91IGRvaW5nIHRoYXQ/IFdoYXQgaXMgdGhl IHJhdGlvbmFsPwoKQW55aG93IGlmIHRoaXMgbm90IHJlcXVpcmVkIGJ5IHlvdXIgc2VyaWVzLCB5 b3Ugc2hvdWxkIHNwbGl0IGl0IG91dCBvZgppdCwgYW5kIHNlbmQgaXQgb24geW91ciBwcmluY2lw YWwgY2hhbmdlcyBhcmUgbWVyZ2VkLgpJJ20gd29ycmllZCBiZWNhdXNlIHRoaXMgdGhlc2UgbmV3 IHBhdGNoZXMgaW52b2x2ZSBtYW55IHN1YnN5c3RlbXMgKHRodXMKbWFpbnRhaW5lcnMpIGFuZCBy ZXZpZXdpbmcgdGhlbSB3aWxsIG5vdyB0YWtlIGEgZmFpciBhbW91bnQgb2YgdGltZS4KCj4gRm9y IGVhY2ggZGV2aWNlIGRlY2xhcmVkIHdpdGggREVWSUNFX05BVElWRV9FTkRJQU4sIGZpbmQgdGhl IHNldCBvZgo+IHRhcmdldHMgZnJvbSB0aGUgc2V0IG9mIHRhcmdldC9ody8qL2RldmljZS5vLgo+ Cj4gSWYgdGhlIHNldCBvZiB0YXJnZXRzIGFyZSBhbGwgbGl0dGxlIG9yIGFsbCBiaWcgZW5kaWFu LCByZS1kZWNsYXJlCj4gdGhlIGRldmljZSBlbmRpYW5uZXNzIGFzIERFVklDRV9MSVRUTEVfRU5E SUFOIG9yIERFVklDRV9CSUdfRU5ESUFOCj4gcmVzcGVjdGl2ZWx5LgoKSWYgb25seSBsaXR0bGUg ZW5kaWFuIHRhcmdldHMgdXNlIGEgZGV2aWNlLCB0aGF0IGRvZXNuJ3QgbWVhbiB0aGUgZGV2aWNl CmlzIGRlc2lnbmVkIGluIGxpdHRsZSBlbmRpYW4uLi4KClRoZW4gaWYgYSBiaWcgZW5kaWFuIHRh cmdldCBwbGFuIHRvIHVzZSB0aGlzIGRldmljZSwgaXQgd2lsbCByZXF1aXJlCm1vcmUgd29yayBh bmQgeW91IG1pZ2h0IGhhdmUgaW50cm9kdWNlZCByZWdyZXNzaW9ucy4uLgoKSSdtIG5vdCBzdXJl IHRoaXMgaXMgYSBzYWZlIG1vdmUuCgo+IFRoaXMgKm5haXZlKiBkZWR1Y3Rpb24gbWF5IHJlc3Vs dCBpbiBnZW51aW5lbHkgbmF0aXZlIGVuZGlhbiBkZXZpY2VzCj4gYmVpbmcgaW5jb3JyZWN0bHkg ZGVjbGFyZWQgYXMgbGl0dGxlIG9yIGJpZyBlbmRpYW4sIGJ1dCBzaG91bGQgbm90Cj4gaW50cm9k dWNlIHJlZ3Jlc3Npb25zIGZvciBjdXJyZW50IHRhcmdldHMuCgpSZWdhcmRzLAoKUGhpbC4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMu eGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1hyYzu-0002Mh-Ev for mharc-qemu-riscv@gnu.org; Fri, 16 Aug 2019 05:58:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34186) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyYzs-0002HP-6E for qemu-riscv@nongnu.org; Fri, 16 Aug 2019 05:58:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyYzq-0006TK-V8 for qemu-riscv@nongnu.org; Fri, 16 Aug 2019 05:58:12 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33117) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyYzq-0006SI-O1 for qemu-riscv@nongnu.org; Fri, 16 Aug 2019 05:58:10 -0400 Received: by mail-wr1-f66.google.com with SMTP id u16so999171wrr.0 for ; Fri, 16 Aug 2019 02:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Foo7mqc4L4owvltcL+chmVAdJxdrnYoZDMnBcLnmc5c=; b=nebf2DgmHUwg57QL86rXbuBlP+dYskb56dN4bei/qDupt7HSTCOoGrYWmzSKnrrO1g XvuwKH9ZYyV/L4Lp/a65wU0LlKH1YtkqUWRWLGavLgmKftBnfQIB3qjA0Guzx66qGPPX fQnVenC5krDRVSxxcnM0SobmZYU6bpvl0fgdy2gJGZhvrrha81U272EBkyUq8p8ptERj IluRRNrzrRU7hPZU2ezfcZfwVizQE3NVjgu5+oKV6CukcLNrGst3JYua9i0FY1t/7WbM CGMs3pDhGRa6vY4Tel6fsPSBcO+OXAy0YXGd1fGnEw2A2YIDJfYyNnjaiTj0jXsVzI9o 0GsQ== X-Gm-Message-State: APjAAAWBTru4bvKSMz5yTVClWJOm29uMEIbNXXfAoMfeBvJ1WokTad6S 3qpO9yg0sHnK3KEdq5w9zfl+BQ== X-Google-Smtp-Source: APXvYqxEtH9z2rQcNW2PoiyLykUukmpcl5g1WXvMOKgN8N7tudUZZZ63JDl5GzOk7+ZQwUPBP9c8/A== X-Received: by 2002:adf:82d4:: with SMTP id 78mr9141289wrc.85.1565949489545; Fri, 16 Aug 2019 02:58:09 -0700 (PDT) Received: from [192.168.1.39] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id z1sm5419150wrp.51.2019.08.16.02.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2019 02:58:08 -0700 (PDT) To: tony.nguyen@bt.com, qemu-devel@nongnu.org Cc: rth@twiddle.net, pbonzini@redhat.com, mst@redhat.com, imammedo@redhat.com, marcel.apfelbaum@gmail.com, xiaoguangrong.eric@gmail.com, alistair@alistair23.me, peter.maydell@linaro.org, b.galvani@gmail.com, clg@kaod.org, andrew@aj.id.au, joel@jms.id.au, i.mitsyanko@gmail.com, robh@kernel.org, peter.chubb@nicta.com.au, sundeep.lkml@gmail.com, jan.kiszka@web.de, balrogg@gmail.com, eric.auger@redhat.com, kraxel@redhat.com, michael@walle.cc, kwolf@redhat.com, mreitz@redhat.com, jsnow@redhat.com, keith.busch@intel.com, marcandre.lureau@redhat.com, Andrew.Baumann@microsoft.com, edgar.iglesias@gmail.com, antonynpavlov@gmail.com, chouteau@adacore.com, frederic.konrad@adacore.com, huth@tuxfamily.org, mark.cave-ayland@ilande.co.uk, hpoussin@reactos.org, arikalo@wavecomp.com, balaton@eik.bme.hu, gxt@mprc.pku.edu.cn, david@gibson.dropbear.id.au, deller@gmx.de, ehabkost@redhat.com, sstabellini@kernel.org, anthony.perard@citrix.com, paul.durrant@citrix.com, aurelien@aurel32.net, amarkovic@wavecomp.com, magnus.damm@gmail.com, berto@igalia.com, minyard@acm.org, pburton@wavecomp.com, jslaby@suse.cz, jcd@tribudubois.net, andrew.smirnov@gmail.com, green@moxielogic.com, jasowang@redhat.com, dmitry.fleytman@gmail.com, sw@weilnetz.de, jiri@resnulli.us, crwulff@gmail.com, marex@denx.de, lersek@redhat.com, proljc@gmail.com, shorne@gmail.com, yuval.shaia@oracle.com, palmer@sifive.com, sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de, walling@linux.ibm.com, cohuck@redhat.com, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, fam@euphon.net, hare@suse.com, atar4qemu@gmail.com, stefanb@linux.ibm.com, alex.williamson@redhat.com, jcmvbkbc@gmail.com, laurent@vivier.eu, claudio.fontana@suse.com, stefanha@redhat.com, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Fri, 16 Aug 2019 11:58:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:58:13 -0000 Hi Tony, On 8/16/19 8:28 AM, tony.nguyen@bt.com wrote: > This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE. > > v7: [...] > - Re-declared many native endian devices as little or big endian. This is why > v7 has +16 patches. Why are you doing that? What is the rational? Anyhow if this not required by your series, you should split it out of it, and send it on your principal changes are merged. I'm worried because this these new patches involve many subsystems (thus maintainers) and reviewing them will now take a fair amount of time. > For each device declared with DEVICE_NATIVE_ENDIAN, find the set of > targets from the set of target/hw/*/device.o. > > If the set of targets are all little or all big endian, re-declare > the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN > respectively. If only little endian targets use a device, that doesn't mean the device is designed in little endian... Then if a big endian target plan to use this device, it will require more work and you might have introduced regressions... I'm not sure this is a safe move. > This *naive* deduction may result in genuinely native endian devices > being incorrectly declared as little or big endian, but should not > introduce regressions for current targets. Regards, Phil.