From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/perf: reintroduce wait on OA configuration completion
Date: Fri, 28 Feb 2020 13:27:09 +0200 [thread overview]
Message-ID: <a7dc64c2-536e-ef2b-1766-9dab4221fe8b@intel.com> (raw)
In-Reply-To: <158288714402.24106.13125137836039850454@skylake-alporthouse-com>
On 28/02/2020 12:52, Chris Wilson wrote:
> Quoting Chris Wilson (2020-02-27 17:04:42)
>> Quoting Lionel Landwerlin (2020-02-27 12:43:56)
>>> We still need to wait for the initial OA configuration to happen
>>> before we enable OA report writes to the OA buffer.
>> I can confirm this fixes the hang Lionel reported on Skylake [still odd
>> that we can only get this to be an issue on skl]. However, Lionel
>> mentioned that we should be more careful and ensure the emit_oa_config()
>> request is scheduled last. We're currently looking at different ways we
>> can do that.
> Fwiw, this patch works and fixes the problem. I prefer not adding
> a single use temporary to i915_perf_stream, but I leave that choice to
> Lionel.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
Thanks Chris!
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-28 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:43 [Intel-gfx] [PATCH] drm/i915/perf: reintroduce wait on OA configuration completion Lionel Landwerlin
2020-02-27 16:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-27 16:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-27 17:04 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-28 10:52 ` Chris Wilson
2020-02-28 11:27 ` Lionel Landwerlin [this message]
2020-02-28 19:13 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7dc64c2-536e-ef2b-1766-9dab4221fe8b@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.