From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbdDMMDc (ORCPT ); Thu, 13 Apr 2017 08:03:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:34340 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753241AbdDMMD3 (ORCPT ); Thu, 13 Apr 2017 08:03:29 -0400 Subject: Re: [PATCH 1/9] mm: remove return value from init_currently_empty_zone To: Michal Hocko , linux-mm@kvack.org References: <20170410110351.12215-1-mhocko@kernel.org> <20170410110351.12215-2-mhocko@kernel.org> Cc: Andrew Morton , Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko From: Vlastimil Babka Message-ID: Date: Thu, 13 Apr 2017 14:03:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170410110351.12215-2-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2017 01:03 PM, Michal Hocko wrote: > From: Michal Hocko > > init_currently_empty_zone doesn't have any error to return yet it is > still an int and callers try to be defensive and try to handle potential > error. Remove this nonsense and simplify all callers. > > This patch shouldn't have any visible effect > > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 8E7976B03B1 for ; Thu, 13 Apr 2017 08:03:29 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id 187so3019825wmn.5 for ; Thu, 13 Apr 2017 05:03:29 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id v63si12823485wma.79.2017.04.13.05.03.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Apr 2017 05:03:28 -0700 (PDT) Subject: Re: [PATCH 1/9] mm: remove return value from init_currently_empty_zone References: <20170410110351.12215-1-mhocko@kernel.org> <20170410110351.12215-2-mhocko@kernel.org> From: Vlastimil Babka Message-ID: Date: Thu, 13 Apr 2017 14:03:26 +0200 MIME-Version: 1.0 In-Reply-To: <20170410110351.12215-2-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko On 04/10/2017 01:03 PM, Michal Hocko wrote: > From: Michal Hocko > > init_currently_empty_zone doesn't have any error to return yet it is > still an int and callers try to be defensive and try to handle potential > error. Remove this nonsense and simplify all callers. > > This patch shouldn't have any visible effect > > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org