From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A0CC2D0EC for ; Fri, 27 Mar 2020 13:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C632520658 for ; Fri, 27 Mar 2020 13:43:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GKvNLfr9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbgC0Nn5 (ORCPT ); Fri, 27 Mar 2020 09:43:57 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:32862 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbgC0Nn5 (ORCPT ); Fri, 27 Mar 2020 09:43:57 -0400 Received: by mail-lj1-f195.google.com with SMTP id f20so10286022ljm.0; Fri, 27 Mar 2020 06:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h3HMsR6HZU31G+xQ5I9GeaveOctSpxG3dZcbeLk7cIc=; b=GKvNLfr95azbSrXv7DMgjchOFqCOYfl5grnsAA+bRFz4Y8CAnxX8hIy7GbIiGA7Jay ouZ/DX2BUCgA5AT3f8ClxcDjBXt7/0xFWn1NZCynNwmEqvSI6f7+2yAYii4lz+G0I2wo fGlOVaAlVe+kyJTmvrquB/unfkjv7JS7xysAzgUKeT10Ajb0n7xz8fMjf6y3Lb+6ZOOR vGK1eBTQnXPYcuvwp3IoZLAfwTSFafGkxmm//RvwOfX5rKTBHZ/cl/CWhwqTpvrqxUNz 9fNbg3hRnCA/3bXyoGVJiPSo8cOjbBosw9oOTbAxSsS6MGzjOuNScX8eBazI6Jv7wygg ynNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3HMsR6HZU31G+xQ5I9GeaveOctSpxG3dZcbeLk7cIc=; b=Sz5wTm66BsRZyycHMZ0vsCAt+Z6WAbnQYPOu/SI4L1AMdDrpdhv55GZOrgDEKWDnIV p7JdCcJ1Qdrv2iYe89vZhNz/CVy05hpTP1IKOwICWErOwqPUk5DGqV+7apJGpRg0aBY2 exptjo8cO5jpGxqJpfLJAwg93Qq/pxjnnIxWkLPqxepipMFHiKR+WWmbyKs+2iw55xsO VjkEZB+xxOw1DOpjvKvX4Vn/Lsn84E2NZy8twlqOSBAZb2D7AF7YzCZmFYAbrM5Iqfd+ xp9hzn4BXQUh+a8Zn7XlUwFV9y2aPqaVSUzBtsFeQrB+1dFwW9KR3lQksmyUKpA1iWVL /dTg== X-Gm-Message-State: AGi0PuaZLgNpDJQ4OaG4sKDTnYk+Nvya7Zk/Kc5x5kgA0mG5VfSULuTG IRfqhUwHbqJb4DYUMp1ESLI= X-Google-Smtp-Source: APiQypK3GwcTU1z2CorSBvReY5Rip+JCow1O1vGOD2yzZmUWOFpm6JEGznsM60IM52m//93WnEJQTQ== X-Received: by 2002:a2e:3012:: with SMTP id w18mr8713173ljw.100.1585316635323; Fri, 27 Mar 2020 06:43:55 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id o192sm870042lfa.89.2020.03.27.06.43.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 06:43:54 -0700 (PDT) Subject: Re: [PATCH v9 52/55] input: touchscreen: atmel_mxt_ts: Added sysfs entry for touchscreen status From: Dmitry Osipenko To: "Wang, Jiada" , nick@shmanahar.org, dmitry.torokhov@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com, bsz@semihalf.com, rydberg@bitmath.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com References: <20200325133334.19346-1-jiada_wang@mentor.com> <20200325133334.19346-53-jiada_wang@mentor.com> <4aeda6f1-25d8-9437-5cd0-560e43dbe081@gmail.com> <5b03bf10-d4f1-fb3d-4561-1097630c195a@gmail.com> Message-ID: Date: Fri, 27 Mar 2020 16:43:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <5b03bf10-d4f1-fb3d-4561-1097630c195a@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.03.2020 16:37, Dmitry Osipenko пишет: > 27.03.2020 15:49, Wang, Jiada пишет: >>>> +static void mxt_watchdog_work(struct work_struct *work) >>>> +{ >>>> +    struct mxt_data *data = >>>> +        container_of(work, struct mxt_data, watchdog_work); >>>> +    u16 info_buf; >>>> +    int ret = 0; >>>> +    u8 size = 2; There is no need to initialize the ret variable. >>>> +    if (data->suspended || data->in_bootloader) >>>> +        return; >>>> + >>>> +    ret = __mxt_read_reg(data->client, 0, size, &info_buf); The "size" argument could be replaced with "sizeof(info_buf)".