All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Vidya Sagar <vidyas@nvidia.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH V2] PCI: tegra: Fix building Tegra194 PCIe driver
Date: Wed, 9 Jun 2021 11:23:27 +0100	[thread overview]
Message-ID: <a80788e4-b0a9-b8d9-46d0-873b5cc6035b@nvidia.com> (raw)
In-Reply-To: <303946c4-29a1-4f5b-6a4c-be451ece20fe@nvidia.com>


On 08/06/2021 21:11, Jon Hunter wrote:

...

> Furthermore, I wonder if we should just move the code
> that is required for ACPI into it's own file like
> drivers/pci/controller/dwc/pcie-tegra194-acpi.c?

I have been doing some testing and the above works fine. IMO moving the
ACPI specific code to its own file is a lot cleaner and simplifies the
Makefile and Kconfig. Especially seeing as the ACPI quirk code is
independent of the actual Tegra194 PCIe driver. Therefore, unless you
have any objections I will send a patch to fix this by doing just that
tomorrow. Also let me know if you have any concerns about the file name
or location drivers/pci/controller/dwc/pcie-tegra194-acpi.c.

That will at least fix the issue with v5.13. If we do that, then for
v5.14 I will clean-up the Kconfig and place everything under a single
CONFIG_PCIE_TEGRA194 entry (which I can send out once the initial
problem is fixed). And finally I will remove the unnecessary cast in the
probe function.

Jon

-- 
nvpublic

  reply	other threads:[~2021-06-09 10:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  9:01 [PATCH V2] PCI: tegra: Fix building Tegra194 PCIe driver Jon Hunter
2021-05-20  9:57 ` Krzysztof Wilczyński
2021-05-20 22:19 ` Bjorn Helgaas
2021-05-21 13:11   ` Jon Hunter
2021-06-07 23:50     ` Bjorn Helgaas
2021-06-08  7:44       ` Jon Hunter
2021-06-08 13:02         ` Bjorn Helgaas
2021-06-08 13:20           ` Jon Hunter
2021-06-08 18:34             ` Vidya Sagar
2021-06-08 20:11               ` Jon Hunter
2021-06-09 10:23                 ` Jon Hunter [this message]
2021-06-09 14:00                   ` Vidya Sagar
2021-06-09 16:18                 ` Bjorn Helgaas
2021-06-09 17:07                   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a80788e4-b0a9-b8d9-46d0-873b5cc6035b@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.