From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761315AbdAIHMn (ORCPT ); Mon, 9 Jan 2017 02:12:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:59410 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbdAIHMk (ORCPT ); Mon, 9 Jan 2017 02:12:40 -0500 Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-3-jgross@suse.com> Cc: konrad.wilk@oracle.com, roger.pau@citrix.com, wei.liu2@citrix.com, paul.durrant@citrix.com, netdev@vger.kernel.org From: Juergen Gross Message-ID: Date: Mon, 9 Jan 2017 08:12:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/17 22:57, Boris Ostrovsky wrote: > On 01/06/2017 10:05 AM, Juergen Gross wrote: >> Today a Xenstore watch event is delivered via a callback function >> declared as: >> >> void (*callback)(struct xenbus_watch *, >> const char **vec, unsigned int len); >> >> As all watch events only ever come with two parameters (path and token) >> changing the prototype to: >> >> void (*callback)(struct xenbus_watch *, >> const char *path, const char *token); >> >> is the natural thing to do. >> >> Apply this change and adapt all users. >> >> Cc: konrad.wilk@oracle.com >> Cc: roger.pau@citrix.com >> Cc: wei.liu2@citrix.com >> Cc: paul.durrant@citrix.com >> Cc: netdev@vger.kernel.org >> >> Signed-off-by: Juergen Gross > > >> >> @@ -903,24 +902,24 @@ static int process_msg(void) >> body[msg->hdr.len] = '\0'; >> >> if (msg->hdr.type == XS_WATCH_EVENT) { >> - msg->u.watch.vec = split(body, msg->hdr.len, >> - &msg->u.watch.vec_size); >> - if (IS_ERR(msg->u.watch.vec)) { >> - err = PTR_ERR(msg->u.watch.vec); >> + if (count_strings(body, msg->hdr.len) != 2) { >> + err = -EINVAL; > > xenbus_write_watch() returns -EILSEQ when this type of error is > encountered so perhaps for we should return the same error here. Not since 9a6161fe73bdd3ae4a1e18421b0b20cb7141f680. :-) > > Either way > > Reviewed-by: Boris Ostrovsky Thanks, Juergen