From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subhash Jadavani Subject: Re: [PATCH 2/4] phy: qcom-ufs: Correct usage of regulator_get() Date: Fri, 20 Jan 2017 14:50:44 -0800 Message-ID: References: <20170119104739.4376-1-bjorn.andersson@linaro.org> <20170119104739.4376-2-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35864 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdATWuq (ORCPT ); Fri, 20 Jan 2017 17:50:46 -0500 In-Reply-To: <20170119104739.4376-2-bjorn.andersson@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vivek Gautam On 2017-01-19 02:47, Bjorn Andersson wrote: > When regulator_get() tries to resolve a regulator supply but fail to > find a matching property in DeviceTree it returns a dummy regulator, if > a matching supply is specified but unavailable the regulator core will > return an error. > > Based on this we should not ignore errors upon failing to acquire the > optional "vddp-ref-clk" supply. > > Cc: Subhash Jadavani > Cc: Vivek Gautam > Signed-off-by: Bjorn Andersson > --- > drivers/phy/phy-qcom-ufs.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c > index 4d7f3c018223..bbd317158084 100644 > --- a/drivers/phy/phy-qcom-ufs.c > +++ b/drivers/phy/phy-qcom-ufs.c > @@ -210,8 +210,9 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy > *phy_common) > } > EXPORT_SYMBOL_GPL(ufs_qcom_phy_init_clks); > > -static int __ufs_qcom_phy_init_vreg(struct device *dev, > - struct ufs_qcom_phy_vreg *vreg, const char *name, bool optional) > +static int ufs_qcom_phy_init_vreg(struct device *dev, > + struct ufs_qcom_phy_vreg *vreg, > + const char *name) > { > int err = 0; > > @@ -221,9 +222,7 @@ static int __ufs_qcom_phy_init_vreg(struct device > *dev, > vreg->reg = devm_regulator_get(dev, name); > if (IS_ERR(vreg->reg)) { > err = PTR_ERR(vreg->reg); > - vreg->reg = NULL; > - if (!optional) > - dev_err(dev, "failed to get %s, %d\n", name, err); > + dev_err(dev, "failed to get %s, %d\n", name, err); > goto out; > } > > @@ -263,12 +262,6 @@ static int __ufs_qcom_phy_init_vreg(struct device > *dev, > return err; > } > > -static int ufs_qcom_phy_init_vreg(struct device *dev, > - struct ufs_qcom_phy_vreg *vreg, const char *name) > -{ > - return __ufs_qcom_phy_init_vreg(dev, vreg, name, false); > -} > - > int ufs_qcom_phy_init_vregulators(struct ufs_qcom_phy *phy_common) > { > int err; > @@ -284,9 +277,9 @@ int ufs_qcom_phy_init_vregulators(struct > ufs_qcom_phy *phy_common) > if (err) > goto out; > > - /* vddp-ref-clk-* properties are optional */ > - __ufs_qcom_phy_init_vreg(phy_common->dev, &phy_common->vddp_ref_clk, > - "vddp-ref-clk", true); > + err = ufs_qcom_phy_init_vreg(phy_common->dev, > &phy_common->vddp_ref_clk, > + "vddp-ref-clk"); > + > out: > return err; > } Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project