From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f54.google.com ([209.85.214.54]:39544 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726807AbeH1U7x (ORCPT ); Tue, 28 Aug 2018 16:59:53 -0400 Received: by mail-it0-f54.google.com with SMTP id h1-v6so1501717itj.4 for ; Tue, 28 Aug 2018 10:07:18 -0700 (PDT) Subject: Re: 14Gb of space lost after distro upgrade on BTFS root partition (long thread with logs) To: Noah Massey Cc: menion@gmail.com, Chris Murphy , linux-btrfs References: From: "Austin S. Hemmelgarn" Message-ID: Date: Tue, 28 Aug 2018 13:07:14 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 2018-08-28 12:05, Noah Massey wrote: > On Tue, Aug 28, 2018 at 11:47 AM Austin S. Hemmelgarn > wrote: >> >> On 2018-08-28 11:27, Noah Massey wrote: >>> On Tue, Aug 28, 2018 at 10:59 AM Menion wrote: >>>> >>>> [sudo] password for menion: >>>> ID gen top level path >>>> -- --- --------- ---- >>>> 257 600627 5 /@ >>>> 258 600626 5 /@home >>>> 296 599489 5 >>>> /@apt-snapshot-release-upgrade-bionic-2018-08-27_15:29:55 >>>> 297 599489 5 >>>> /@apt-snapshot-release-upgrade-bionic-2018-08-27_15:30:08 >>>> 298 599489 5 >>>> /@apt-snapshot-release-upgrade-bionic-2018-08-27_15:33:30 >>>> >>>> So, there are snapshots, right? The time stamp is when I have launched >>>> do-release-upgrade, but it didn't ask anything about snapshot, neither >>>> I asked for it. >>> >>> This is an Ubuntu thing >>> `apt show apt-btrfs-snapshot` >>> which "will create a btrfs snapshot of the root filesystem each time >>> that apt installs/removes/upgrades a software package." >> Not Ubuntu, Debian. It's just that Ubuntu installs and configures the >> package by default, while Debian does not. > > Ubuntu also maintains the package, and I did not find it in Debian repositories. > I think it's also worth mentioning that these snapshots were created > by the do-release-upgrade script using the package directly, not as a > result of the apt configuration. Meaning if you do not want a snapshot > taken prior to upgrade, you have to remove the apt-btrfs-snapshot > package prior to running the upgrade script. You cannot just update > /etc/apt/apt.conf.d/80-btrfs-snapshot Hmm... I could have sworn that it was in the Debian repositories. That said, it's kind of stupid that the snapshot is not trivially optional for a release upgrade. Yes, that's where it's arguably the most important, but it's still kind of stupid to have to remove a package to get rid of that behavior and then reinstall it again afterwards.