All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edgar Bonet <bonet@grenoble.cnrs.fr>
To: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 02/28] configs/acmesystems_acqua_a5_512mb_defconfig: enable NEON/VFPV4 FPU strategy
Date: Tue, 18 Jan 2022 13:58:47 +0100	[thread overview]
Message-ID: <a81bcbfc-f5ac-f013-7831-5bc5321e2a43@grenoble.cnrs.fr> (raw)
In-Reply-To: <20220118104338.2081259-3-giulio.benetti@benettiengineering.com>

Hi!

[Replying to list only, hoping it is the right etiquette.]

Giulio Benetti wrote:
> --- a/configs/acmesystems_acqua_a5_512mb_defconfig
> +++ b/configs/acmesystems_acqua_a5_512mb_defconfig
> @@ -1,6 +1,7 @@
>  BR2_arm=y
>  BR2_cortex_a5=y
>  BR2_ARM_ENABLE_VFP=y
> +BR2_ARM_FPU_NEON_VFPV4=y
>  BR2_ARM_INSTRUCTIONS_THUMB2=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y
>  BR2_SYSTEM_DHCP="eth0"

I think this may be missing some dependencies, as this change does not
survive `save defconfig'. I tried the following from a clean tree:

    git pull # from master
    git am ~/tmp/saved-patch.email  # the patch above
    make acmesystems_acqua_a5_512mb_defconfig
    make nconfig
        # no changes to configuration
        <F6> Save
        <F9> Exit
    make savedefconfig
    git diff

And git showed me that the patch had just been reverted on the worktree.
According to arch/Config.in.arm, BR2_ARM_FPU_NEON_VFPV4 depends on
BR2_ARM_CPU_HAS_NEON, which is not mentioned in my .config. It also
appears that BR2_ARM_ENABLE_NEON selects BR2_ARM_CPU_HAS_NEON. Would
BR2_ARM_ENABLE_NEON be the canonical way of making
BR2_ARM_FPU_NEON_VFPV4 acceptable? I am a bit confused by the VFP
selection logic in arch/Config.in.arm, so I am not sure that would be
the right approach.

As a follow up question, if this issue is fixed, what would be the
simplest way of testing the floating point implementation on the board?
I was thinking about adding gnuplot, which doesn't have any
dependencies, and having it do some computations. I do not know,
however, whether this would exercise the NEON SIMD extensions.

Best regards,

Edgar.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-18 13:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 10:43 [Buildroot] [PATCH 00/28] Use the best FPU strategies on 32-bits Arm Cortex Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 01/28] configs/acmesystems_acqua_a5_256mb_defconfig: enable NEON/VFPV4 FPU strategy Giulio Benetti
2022-01-18 17:33   ` Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 02/28] configs/acmesystems_acqua_a5_512mb_defconfig: " Giulio Benetti
2022-01-18 12:58   ` Edgar Bonet [this message]
2022-01-18 13:28   ` Edgar Bonet
2022-01-18 13:35     ` Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 03/28] configs/bananapi_m2_plus_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 04/28] configs/bananapi_m2_ultra_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 05/28] configs/beagleboardx15_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 06/28] configs/beagleboneai_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 07/28] configs/chromebook_snow_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 08/28] configs/freescale_imx7dsabresd_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 09/28] configs/friendlyarm_nanopi_m1_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 10/28] configs/friendlyarm_nanopi_m1_plus_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 11/28] configs/friendlyarm_nanopi_neo_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 12/28] configs/friendlyarm_nanopi_r1_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 13/28] configs/grinn_liteboard_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 14/28] configs/licheepi_zero_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 15/28] configs/microchip_sama5d27_wlsom1_ek_mmc_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 16/28] configs/microchip_sama5d27_wlsom1_ek_mmc_dev_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 17/28] configs/microchip_sama5d2_icp_mmc_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 18/28] configs/microchip_sama5d2_icp_mmc_dev_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 19/28] configs/orangepi_lite_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 20/28] configs/orangepi_one_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 21/28] configs/orangepi_pc_defconfig: " Giulio Benetti
2022-01-23 18:39   ` Sergey Kuzminov
2022-01-18 10:43 ` [Buildroot] [PATCH 22/28] configs/orangepi_pc_plus_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 23/28] configs/orangepi_plus_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 24/28] configs/orangepi_r1_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 25/28] configs/orangepi_zero_defconfig: " Giulio Benetti
2022-01-23 18:07   ` Sergey Kuzminov
2022-01-23 19:12     ` Giulio Benetti
2022-01-23 20:57       ` Yann E. MORIN
2022-01-18 10:43 ` [Buildroot] [PATCH 26/28] configs/stm32mp157a_dk1_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 27/28] configs/stm32mp157c_dk2_defconfig: " Giulio Benetti
2022-01-18 10:43 ` [Buildroot] [PATCH 28/28] configs/stm32mp157c_odyssey_defconfig: " Giulio Benetti
2022-01-22 14:32 ` [Buildroot] [PATCH 00/28] Use the best FPU strategies on 32-bits Arm Cortex Thomas Petazzoni
2022-01-25 20:55   ` Yann E. MORIN
2022-01-25 21:48     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a81bcbfc-f5ac-f013-7831-5bc5321e2a43@grenoble.cnrs.fr \
    --to=bonet@grenoble.cnrs.fr \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.