From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F277C38145 for ; Fri, 2 Sep 2022 13:34:17 +0000 (UTC) Received: from localhost ([::1]:34812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU6oK-0000cl-DR for qemu-devel@archiver.kernel.org; Fri, 02 Sep 2022 09:34:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU6iJ-00023s-1S for qemu-devel@nongnu.org; Fri, 02 Sep 2022 09:28:03 -0400 Received: from prt-mail.chinatelecom.cn ([42.123.76.226]:56290 helo=chinatelecom.cn) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU6i7-00052n-L3 for qemu-devel@nongnu.org; Fri, 02 Sep 2022 09:27:57 -0400 HMM_SOURCE_IP: 172.18.0.188:45710.503253820 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-10.133.8.31 (unknown [172.18.0.188]) by chinatelecom.cn (HERMES) with SMTP id 99AC028008F; Fri, 2 Sep 2022 21:27:34 +0800 (CST) X-189-SAVE-TO-SEND: huangy81@chinatelecom.cn Received: from ([172.18.0.188]) by app0023 with ESMTP id bbd4ba033829438cb81e86f1919a4694 for armbru@redhat.com; Fri, 02 Sep 2022 21:27:37 CST X-Transaction-ID: bbd4ba033829438cb81e86f1919a4694 X-Real-From: huangy81@chinatelecom.cn X-Receive-IP: 172.18.0.188 X-MEDUSA-Status: 0 Message-ID: Date: Fri, 2 Sep 2022 21:27:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1 2/8] qapi/migration: Introduce x-vcpu-dirty-limit parameters To: Markus Armbruster Cc: qemu-devel , Peter Xu , Juan Quintela , "Dr. David Alan Gilbert" , Eric Blake , Thomas Huth , Laurent Vivier , Paolo Bonzini , "Daniel P. Berrange" References: <58009ed32bc30ce40228b191fdd9cacc259ac859.1662052189.git.huangy81@chinatelecom.cn> <875yi6xkwz.fsf@pond.sub.org> From: Hyman Huang In-Reply-To: <875yi6xkwz.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=42.123.76.226; envelope-from=huangy81@chinatelecom.cn; helo=chinatelecom.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/9/2 16:03, Markus Armbruster 写道: > huangy81@chinatelecom.cn writes: > >> From: Hyman Huang(黄勇) >> >> Introduce "x-vcpu-dirty-limit" migration parameter used >> to limit dirty page rate during live migration. >> >> "x-vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are >> two dirty-limit-related migration parameters, which can >> be set before and during live migration by qmp >> migrate-set-parameters. >> >> This two parameters are used to help implement the dirty >> page rate limit algo of migration. >> >> Signed-off-by: Hyman Huang(黄勇) > [...] >> diff --git a/qapi/migration.json b/qapi/migration.json >> index 332c087..8554d33 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -779,6 +779,9 @@ >> # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. >> # Defaults to 500ms. (Since 7.1) >> # >> +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. >> +# Defaults to 1. (Since 7.1) >> +# >> # Features: >> # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period >> # are experimental. >> @@ -801,7 +804,8 @@ >> 'max-cpu-throttle', 'multifd-compression', >> 'multifd-zlib-level', 'multifd-zstd-level', >> 'block-bitmap-mapping', >> - { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] } ] } >> + { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] }, >> + 'x-vcpu-dirty-limit'] } > > Shouldn't 'x-vcpu-dirty-limit-period' have feature 'unstable', too? > Yes, i missed that, thanks very much. > Same below. > >> >> ## >> # @MigrateSetParameters: >> @@ -949,6 +953,9 @@ >> # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. >> # Defaults to 500ms. (Since 7.1) >> # >> +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. >> +# Defaults to 1. (Since 7.1) >> +# >> # Features: >> # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period >> # are experimental. >> @@ -987,7 +994,8 @@ >> '*multifd-zstd-level': 'uint8', >> '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], >> '*x-vcpu-dirty-limit-period': { 'type': 'uint64', >> - 'features': [ 'unstable' ] } } } >> + 'features': [ 'unstable' ] }, >> + '*x-vcpu-dirty-limit': 'uint64'} } >> >> ## >> # @migrate-set-parameters: >> @@ -1155,6 +1163,9 @@ >> # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. >> # Defaults to 500ms. (Since 7.1) >> # >> +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. >> +# Defaults to 1. (Since 7.1) >> +# >> # Features: >> # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period >> # are experimental. >> @@ -1191,7 +1202,8 @@ >> '*multifd-zstd-level': 'uint8', >> '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], >> '*x-vcpu-dirty-limit-period': { 'type': 'uint64', >> - 'features': [ 'unstable' ] } } } >> + 'features': [ 'unstable' ] }, >> + '*x-vcpu-dirty-limit': 'uint64'} } >> >> ## >> # @query-migrate-parameters: > -- Best regard Hyman Huang(黄勇)