From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbdLFVec (ORCPT ); Wed, 6 Dec 2017 16:34:32 -0500 Received: from mout.web.de ([212.227.15.14]:50979 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbdLFVeb (ORCPT ); Wed, 6 Dec 2017 16:34:31 -0500 Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , kernel-janitors@vger.kernel.org References: From: SF Markus Elfring Message-ID: Date: Wed, 6 Dec 2017 22:33:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:XFT1oP0k70kP7s+SxCZgGYJveaEw/Xx2bqqeSQiJBly6fesoIwH jRpOHkkx5khqZoHQh70IODrE1pzIiegfURGp4hEUfe2H5Tj/4gVGdKTGF+MR8U+1qpGBwqi W9qSIkwshtQnPERzs8e03gJcWugn9bzPrs2tRzp4damoHpCh1HK+gKFfqaK046VrRSjeSOl Xn1rZN4PU4g+OYm7mUetQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MujBelnutPE=:QxfMt/OtOs/2VvR96+KLg3 HiT96W0zdiZwIYuTILEUKOq1CA/lW4sG1OpZGXuzArxuT7SI+keitQBXYJoiXfl3grLV6YfFt oVzXyiLroam6jSOSa3bkGxw1Ux8jQuTiFYR0KUNCpiau+audAjjgvZEcT8kUeWaBiQnPJk9HI mRLHT1VndmBSrDEKYkPKM8ic9GeeBD4apIbDsD6ceX3yhh+kqAZvr9oZflSQo/VVqUNM2K3Wx x+s7txnL6rM1hqKA/C6QJ3ES+6NboBseF1cotDOLHk7kv7a+FQbDjNPDaTUXBluTf1fpHBbsi 9NQ65O+IslGk3OAI4T9BmP2ds228/qFg7aO4s4eZ7vrNa0pE/sRM3n2IYtevsCFoc4PIYEHrt 86NKeYuC2lCDmNJnjg0PCoKwwh9IUXr5SGIw+ydx0C79Alnroh2ycBTHs1Q6o8+Q+JM5J+1Tf Cc7utkCUAe39KgfdP+4Nxt5BMSKbEgrnTmNaSZLrQzTVjDsPM98JSYlZ6OnImiRaCeuRTr5l2 7b33imzmf4Rk7NFquWK1mJmapswW72BXp77UwuXCeYCpLubUNrHBs7+HO8AOCdtP9jZSXt39b X8oOszBfL4/FczoxH0hLbL4RuES9yK3hGhgm0vQp9hCrtTt0TJIO82cy7PgshXq09JZ17e/np 4qfabo3rEZx49l5oNw4Lr6vFHtqxnEpgc/M/6WlROd3fnp/WeGpUHisV/x57qq8qgWdwshO7W nB6F4bAMzvok09szmJgQFXIEUjJuthwziKKa40Ao5H8w2hBb8UteNUobNNK0os4u/ubWbUGeI yAAZJt3qa6aWJCEsNtnbCbcBH4lP4Oy97K0I/rsriY2yVgdILk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Does the existing memory allocation error message include the >>> &udev->dev device name and driver name? If it doesn't, there will be >>> no way for the user to tell that the error message is related to the >>> device failure. >> >> No, but the effect is similar. >> >> OOM does a dump_stack() so this function's call tree is shown. > > A call stack doesn't tell you which device was being handled. Do you find a default Linux allocation failure report insufficient then? Would you like to to achieve that the requested information can be determined from a backtrace? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 06 Dec 2017 21:33:26 +0000 Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Message-Id: List-Id: References: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net> In-Reply-To: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , kernel-janitors@vger.kernel.org >>> Does the existing memory allocation error message include the >>> &udev->dev device name and driver name? If it doesn't, there will be >>> no way for the user to tell that the error message is related to the >>> device failure. >> >> No, but the effect is similar. >> >> OOM does a dump_stack() so this function's call tree is shown. > > A call stack doesn't tell you which device was being handled. Do you find a default Linux allocation failure report insufficient then? Would you like to to achieve that the requested information can be determined from a backtrace? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() From: SF Markus Elfring Message-Id: Date: Wed, 6 Dec 2017 22:33:26 +0100 To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , kernel-janitors@vger.kernel.org List-ID: Pj4+IERvZXMgdGhlIGV4aXN0aW5nIG1lbW9yeSBhbGxvY2F0aW9uIGVycm9yIG1lc3NhZ2UgaW5j bHVkZSB0aGUgCj4+PiAmdWRldi0+ZGV2IGRldmljZSBuYW1lIGFuZCBkcml2ZXIgbmFtZT8gIElm IGl0IGRvZXNuJ3QsIHRoZXJlIHdpbGwgYmUgCj4+PiBubyB3YXkgZm9yIHRoZSB1c2VyIHRvIHRl bGwgdGhhdCB0aGUgZXJyb3IgbWVzc2FnZSBpcyByZWxhdGVkIHRvIHRoZSAKPj4+IGRldmljZSBm YWlsdXJlLgo+Pgo+PiBObywgYnV0IHRoZSBlZmZlY3QgaXMgc2ltaWxhci4KPj4KPj4gT09NIGRv ZXMgYSBkdW1wX3N0YWNrKCkgc28gdGhpcyBmdW5jdGlvbidzIGNhbGwgdHJlZSBpcyBzaG93bi4K PiAKPiBBIGNhbGwgc3RhY2sgZG9lc24ndCB0ZWxsIHlvdSB3aGljaCBkZXZpY2Ugd2FzIGJlaW5n IGhhbmRsZWQuCgpEbyB5b3UgZmluZCBhIGRlZmF1bHQgTGludXggYWxsb2NhdGlvbiBmYWlsdXJl IHJlcG9ydCBpbnN1ZmZpY2llbnQgdGhlbj8KCldvdWxkIHlvdSBsaWtlIHRvIHRvIGFjaGlldmUg dGhhdCB0aGUgcmVxdWVzdGVkIGluZm9ybWF0aW9uIGNhbiBiZSBkZXRlcm1pbmVkCmZyb20gYSBi YWNrdHJhY2U/CgpSZWdhcmRzLApNYXJrdXMKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBs aXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9m IGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGlu Zm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=