From: Lubomir Rintel <lkundrak@v3.sk>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libertas: remove ifdef OLPC noise
Date: Wed, 16 Jan 2019 17:20:50 +0100 [thread overview]
Message-ID: <a82a40694727e90b851789d5a0a8334fd526c4c7.camel@v3.sk> (raw)
In-Reply-To: <87zhs04mhr.fsf@codeaurora.org>
On Wed, 2019-01-16 at 18:04 +0200, Kalle Valo wrote:
> Lubomir Rintel <lkundrak@v3.sk> writes:
>
> > <asm/olpc.h> provides machine_is_olpc() stub for CONFIG_OLPC=n,
> > compiler should just optimize the unneeded bits away.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> > drivers/net/wireless/marvell/libertas/if_usb.c | 10 ----------
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
> > index 220dcdee8d2b..7b61c599948e 100644
> > --- a/drivers/net/wireless/marvell/libertas/if_usb.c
> > +++ b/drivers/net/wireless/marvell/libertas/if_usb.c
> > @@ -12,9 +12,7 @@
> > #include <linux/usb.h>
> > #include <linux/olpc-ec.h>
> >
> > -#ifdef CONFIG_OLPC
> > #include <asm/olpc.h>
> > -#endif
>
> Using asm directory looked odd to me so I did some investigation:
>
> $ find -name olpc.h
> ./arch/x86/include/asm/olpc.h
>
> Did you build this on something else than x86? For example, will the
> compiler find olpc.h when building for arm?
Uh, no. You're right, this indeed breaks on non-x86.
Perhaps olpc-ec.h should provide something that could tell whether the
EC is available that could be used instead of machine_is_olpc(), or the
olpc.h moved outside arch/x86.
For now, please just ignore the patch..
Lubo
prev parent reply other threads:[~2019-01-16 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 15:16 [PATCH] libertas: remove ifdef OLPC noise Lubomir Rintel
2019-01-16 16:04 ` Kalle Valo
2019-01-16 16:20 ` Lubomir Rintel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a82a40694727e90b851789d5a0a8334fd526c4c7.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=kvalo@codeaurora.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.