From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euOdZ-0000MW-Fs for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:29:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euOdW-0006x2-CI for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:29:09 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euOdW-0006wk-21 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:29:06 -0500 References: <20171228180814.9749-1-lukeshu@lukeshu.com> <20171228180814.9749-6-lukeshu@lukeshu.com> From: Laurent Vivier Message-ID: Date: Fri, 9 Mar 2018 21:28:54 +0100 MIME-Version: 1.0 In-Reply-To: <20171228180814.9749-6-lukeshu@lukeshu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luke Shumaker , qemu-devel@nongnu.org Cc: Luke Shumaker , Riku Voipio Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > There are 3 parts to this change: > - Add a comment showing the relative sizes and positions of the blocks of > memory > - introduce and use new aligned_{start,size} instead of adjusting > real_{start_size} > - When we clean up (on failure), munmap(real_start, real_size) instead of > munmap(aligned_start, aligned_size). It *shouldn't* make any > difference, but I will admit that this does mean we are making the > syscall with different values, so this isn't quite a no-op patch. > > Signed-off-by: Luke Shumaker > --- > linux-user/elfload.c | 43 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 33 insertions(+), 10 deletions(-) > Applied to my 'linux-user-for-2.12' branch. Thanks, Laurent