From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB153C4332F for ; Wed, 22 Dec 2021 16:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbhLVQEO (ORCPT ); Wed, 22 Dec 2021 11:04:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhLVQEN (ORCPT ); Wed, 22 Dec 2021 11:04:13 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3BE3C061574; Wed, 22 Dec 2021 08:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=AkU5CTbPfYwafp7kpDyjYaPsr7IDWP2wJvX6uVQ3YIY=; b=WRjbGkNilG0DyVIjWOUkSgxnJo 1DwQO9+FsVdowuuRWJYP7ElOF8R52M8ocYk2gtfgup++AuulT3VZVP8KA3I0rnh0OuWj8teKHyFeL z8CT/AD/0liCVDN3yPDyFAOLWT0lt0GuE8rrGWZM59mVttkt6cW+YycrIisHE+zkEHuE=; Received: from p54ae97a7.dip0.t-ipconnect.de ([84.174.151.167] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1n0463-0003Xq-S5; Wed, 22 Dec 2021 17:04:07 +0100 Message-ID: Date: Wed, 22 Dec 2021 17:04:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , john@phrozen.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211220211854.89452-1-nbd@nbd.name> <20211220211854.89452-4-nbd@nbd.name> <04137b5dd876899af0da15f7dbc159fc@kernel.org> From: Felix Fietkau Subject: Re: [PATCH v8 03/14] ARM: dts: Add basic support for Airoha EN7523 In-Reply-To: <04137b5dd876899af0da15f7dbc159fc@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-12-21 16:02, Marc Zyngier wrote: > On 2021-12-20 21:18, Felix Fietkau wrote: >> From: John Crispin >> >> Add basic support for Airoha EN7523, enough for booting to console. >> >> The UART is basically 8250-compatible, except for the clock selection. >> A clock-frequency value is synthesized to get this to run at 115200 >> bps. >> >> Signed-off-by: John Crispin >> Signed-off-by: Bert Vermeulen >> Signed-off-by: Felix Fietkau >> --- >> arch/arm/boot/dts/Makefile | 2 + >> arch/arm/boot/dts/en7523-evb.dts | 27 ++++++++ >> arch/arm/boot/dts/en7523.dtsi | 114 +++++++++++++++++++++++++++++++ >> 3 files changed, 143 insertions(+) >> create mode 100644 arch/arm/boot/dts/en7523-evb.dts >> create mode 100644 arch/arm/boot/dts/en7523.dtsi >> > > [...] > >> + gic: interrupt-controller@9000000 { >> + compatible = "arm,gic-v3"; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + reg = <0x09000000 0x20000>, <0x09080000 0x80000>; > > You are missing the 3 extra regions implemented by the A53 cores > (GICC, GICV, GICH). Please see the binding and the A53 TRM. The SoC memory map documentation contains an address for GICC, but not for the other two. Maybe this CPU doesn't implement them. I will add GICC in v9 >> + interrupts = ; >> + }; >> + >> + timer { >> + compatible = "arm,armv7-timer"; > > This is an ARMv8 CPU, even when used in 32bit mode. > >> + interrupt-parent = <&gic>; >> + interrupts = , >> + , >> + , >> + ; >> + clock-frequency = <25000000>; > > Why isn't this properly configured by the firmware? I don't know. - Felix From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0F9AC433F5 for ; Wed, 22 Dec 2021 16:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Rn6U9syY4833bNJQNjVfPd+CBZ6emtvHryx6qIfCA0=; b=rb/9pQOGGwpiC+ K1xIs9bNoq6RCJbwOKR6C6kgk5M17pz5wczpFg4OxcszdGm39PPOcpHfORWXA51Cr1ZiCSgc42KNB LV8tX5yF5oz1XVSY3f97QnUnX+LMDBZHxN13Jr0uo/6uHvp2paPzSs53px1gQfjPv90/R4VGfuxlM zePSNE2QtPwV6IpTEv2t/z64BOLLazcBKC8r+5W+f55EUfkrGDP9hosPamcKrt5aN++61VKUaEGHc iadPTFJOGCdKibGUYAQqvIbFg49HRUVieDAVDsjQeMlfBM1kxGcj2Q6nBvKg/6IXmyyQP1Uo6BVtm Kna+p28OCBG7iGbLh6Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0469-00AoxB-V9; Wed, 22 Dec 2021 16:04:14 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0466-00Aowb-MI for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 16:04:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=AkU5CTbPfYwafp7kpDyjYaPsr7IDWP2wJvX6uVQ3YIY=; b=WRjbGkNilG0DyVIjWOUkSgxnJo 1DwQO9+FsVdowuuRWJYP7ElOF8R52M8ocYk2gtfgup++AuulT3VZVP8KA3I0rnh0OuWj8teKHyFeL z8CT/AD/0liCVDN3yPDyFAOLWT0lt0GuE8rrGWZM59mVttkt6cW+YycrIisHE+zkEHuE=; Received: from p54ae97a7.dip0.t-ipconnect.de ([84.174.151.167] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1n0463-0003Xq-S5; Wed, 22 Dec 2021 17:04:07 +0100 Message-ID: Date: Wed, 22 Dec 2021 17:04:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , john@phrozen.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211220211854.89452-1-nbd@nbd.name> <20211220211854.89452-4-nbd@nbd.name> <04137b5dd876899af0da15f7dbc159fc@kernel.org> From: Felix Fietkau Subject: Re: [PATCH v8 03/14] ARM: dts: Add basic support for Airoha EN7523 In-Reply-To: <04137b5dd876899af0da15f7dbc159fc@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_080410_925417_39C55E8C X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-21 16:02, Marc Zyngier wrote: > On 2021-12-20 21:18, Felix Fietkau wrote: >> From: John Crispin >> >> Add basic support for Airoha EN7523, enough for booting to console. >> >> The UART is basically 8250-compatible, except for the clock selection. >> A clock-frequency value is synthesized to get this to run at 115200 >> bps. >> >> Signed-off-by: John Crispin >> Signed-off-by: Bert Vermeulen >> Signed-off-by: Felix Fietkau >> --- >> arch/arm/boot/dts/Makefile | 2 + >> arch/arm/boot/dts/en7523-evb.dts | 27 ++++++++ >> arch/arm/boot/dts/en7523.dtsi | 114 +++++++++++++++++++++++++++++++ >> 3 files changed, 143 insertions(+) >> create mode 100644 arch/arm/boot/dts/en7523-evb.dts >> create mode 100644 arch/arm/boot/dts/en7523.dtsi >> > > [...] > >> + gic: interrupt-controller@9000000 { >> + compatible = "arm,gic-v3"; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + reg = <0x09000000 0x20000>, <0x09080000 0x80000>; > > You are missing the 3 extra regions implemented by the A53 cores > (GICC, GICV, GICH). Please see the binding and the A53 TRM. The SoC memory map documentation contains an address for GICC, but not for the other two. Maybe this CPU doesn't implement them. I will add GICC in v9 >> + interrupts = ; >> + }; >> + >> + timer { >> + compatible = "arm,armv7-timer"; > > This is an ARMv8 CPU, even when used in 32bit mode. > >> + interrupt-parent = <&gic>; >> + interrupts = , >> + , >> + , >> + ; >> + clock-frequency = <25000000>; > > Why isn't this properly configured by the firmware? I don't know. - Felix _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel